graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
sebas/processid
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.10%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 13 May 2017 04:00:22 +
Build duration: 6.5 sec
CHANGE SET
Revision dcdb9e3323aecd715e08a16d
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/888/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 13 May 2017 02:37:39 +
Build duration: 16 min
CHANGE SET
Revision 5324f52ea789f80bddbf164d2f56ce3a54
davidedmundson added a comment.
> but now that it is all here already, let's just call this a prototype, for
someone who knows C/kevent/kqueue to fix.
So what doesn't work?
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5825
To: tcberner, #freebsd, graes
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
pid (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5818
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, les
tcberner retitled this revision from "Include signal.h for kill." to "Include
signal.h for kill(), and prototype kqueue/kevent stuff... ".
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5825
To: tcberner, #freebsd, graesslin
Cc: plasma-devel, ZrenBot, spstarr, pr
tcberner edited the summary of this revision.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D5825
To: tcberner, #freebsd, graesslin
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
All there in the title.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5825
AFFECTED FILES
hein updated this revision to Diff 14447.
hein added a comment.
Add missing roles to dataChanged on pid changes.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5818?vs=14426&id=14447
BRANCH
pid (branched from master)
REVISION DETAIL
https://p
davidedmundson added inline comments.
INLINE COMMENTS
> waylandtasksmodel.cpp:292
> +appDataCache.remove(window);
> +this->dataChanged(window, AppPid);
> +}
this could also cause the icon to change, who emits a signal for that?
REPOSITORY
R120 Plasma Workspace
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:b5af0296cb2f: When building menu hyerarchies, parent
menus to their containers (authored by mart).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5806?vs=14384&id=1
mart retitled this revision from "[WIP] when building menu hyerarchies, parent
menus to their containers" to "When building menu hyerarchies, parent menus to
their containers".
REPOSITORY
R263 KXmlGui
BRANCH
phab/reparentmenus
REVISION DETAIL
https://phabricator.kde.org/D5806
To: mart,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:680a8a9e2832: [WIP] workarounds for menu positioning
(authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5773?vs=1&id=14445
R
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
*hierarchy
looks sensible. Add a comment in the code as to why we're doing this.
REPOSITORY
R263 KXmlGui
BRANCH
phab/reparentmenus
REVISION DETAIL
https://phabri
davidedmundson added a comment.
don't keep [WIP} in the title though :)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D5773
REVISION DETAIL
https://phabricator.kde.org/D5773
To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #framework
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D5773
REVISION DETAIL
https://phabricator.kde.org/D5773
To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel
mart updated this revision to Diff 1.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- remove duplication
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5773?vs=14438&id=1
B
Hi
We could probably do something with kqueue/EVFILT_SIGNAL:
https://www.freebsd.org/cgi/man.cgi?query=kqueue&sektion=2
EVFILT_SIGNAL Takes the signal number to monitor as the identifier
and returns when the given signal is
delivered to the
sebas updated this revision to Diff 14442.
sebas added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- Update docs: the pid is just set, but doesn't logically change
- ws--
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricat
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> plasmawindowmodel.cpp:84
>
> +
> QObject::connect(window, &PlasmaWindow::activeChanged, q,
Unrelated newline
> plasma-window-management.xml:263
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:6ac39e82ff06: Set no stepper button for GTK3 scrollbars on
gtk >=3.20 (authored by rikmills).
REPOSITORY
R98 Breeze for Gtk
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5128?vs=12678&id=1
davidedmundson added inline comments.
INLINE COMMENTS
> qmenu.cpp:117
> +m_menu->windowHandle()->setTransientParent(item->window());
> +}
> }
we always do this in ::open()
so why have this chunk?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.k
mart updated this revision to Diff 14438.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- more aggressive reparenting in open()
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5773?v
graesslin accepted this revision.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
fix_deprecations (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5743
To: markg, davidedmundson, graesslin
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-
graesslin added a comment.
Your tests in plasma window management do not test the new requests.
INLINE COMMENTS
> test_wayland_windowmanagement.cpp:483
> +using namespace KWayland::Server;
> +// this test verifies setting the showing desktop state
> +QVERIFY(!m_window->isKeepAbove
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
fix_deprecations (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5743
To: markg, davidedmundson
Cc: plasma-devel, Zr
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
cpp11_override (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5742
To: markg, davidedmundson
Cc: plasma-devel, Zren
davidedmundson added inline comments.
INLINE COMMENTS
> view.cpp:237
> +if (!s) {
> +return PlasmaQuick::Dialog::event(event);
> }
return retval.
otherwise you're processsing it twice.
> view.cpp:248
> +//positionOnScreen tried to position i
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fd2e850156ac: recreate plasmashellsurf on exposed, destoy
on hidden (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5745?vs=14
mart updated this revision to Diff 14435.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
comments
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5745?vs=14247&id=14435
BRANCH
arcp
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
some code comments would be good.
you can copy update https://phabricator.kde.org/T6064
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/recreateshell
REVISION
hein accepted this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5807
To: heikobecker, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, les
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Plasma 5.10 branch too. Do you have commit access?
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D5128
To: rikmills, #plasma, davidedmundson
Am 2017-05-12 09:18, schrieb Tobias C. Berner:
Hi there
I think this review introduced some Linux-only features: signalfd() is
only present on Linux.
So this breaks kcheckpass on FreeBSD (and probably everything non-Linux
too).
Would it be possible to have the long-running auth stuff hidden b
On Fri, May 12, 2017 at 11:09 PM, David Edmundson
wrote:
> Following up from Ben's email where we won't have master of frameworks in
> buidling master of Plasma.
>
>> If this affects you, please start a
> new thread (CC'ing sysadmin and kde-core-devel along with your
> Product's main list) stating
vitali added a comment.
So, what do we want to do with this patch?
I've been using it for a week now, and didn't notice any problems. Has anyone
else been testing it?
As for the link, I am for keeping the http version, as it is the one used by
NatGeo, so it would be less likely to be b
Following up from Ben's email where we won't have master of frameworks in
buidling master of Plasma.
> If this affects you, please start a
new thread (CC'ing sysadmin and kde-core-devel along with your
Product's main list) stating which specific repositories you need and
providing one to two lines
On Sun, May 7, 2017 at 4:55 AM, Martin Flöser wrote:
> Am 2017-05-06 11:37, schrieb Ben Cooksley:
>>
Hi Martin,
>> This is the second point that requires your attention. If your
>> development process is dependent on using the latest development
>> version of something which is located in anothe
On Fri, May 12, 2017 at 9:18 AM, Tobias C. Berner
wrote:
> Hi there
>
> I think this review introduced some Linux-only features: signalfd() is
> only present on Linux.
> So this breaks kcheckpass on FreeBSD (and probably everything non-Linux
> too).
>
> Would it be possible to have the long-runni
https://bugs.kde.org/show_bug.cgi?id=379740
Bhushan Shah changed:
What|Removed |Added
Resolution|--- |FIXED
Latest Commit|
Hi there
I think this review introduced some Linux-only features: signalfd() is
only present on Linux.
So this breaks kcheckpass on FreeBSD (and probably everything non-Linux too).
Would it be possible to have the long-running auth stuff hidden behind a
check_include_file("sys/signalfd.h" HAVE_
https://bugs.kde.org/show_bug.cgi?id=379740
Christophe Giboudeaux changed:
What|Removed |Added
CC||j...@jriddell.org
--- Comment #1 from C
43 matches
Mail list logo
