D5579: Introduce QQuickItem to nest kwin_wayland

2017-05-03 Thread Bhavisha Dhruve
bdhruve added a comment. Ping. Do i have to make any more changes? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5579 To: bdhruve, #plasma_on_wayland, #kwin Cc: plasma-devel, kwin, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts,

D5706: DBusMenuImporter: Use unique connection for QMenu::aboutToHide

2017-05-03 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise the signal is sent multiple times. TEST PLAN Only one aboutToHide is received in apps REPOSITORY R120 Plasma Workspace BRANCH

D5704: Improve the x11 timestamp handling

2017-05-03 Thread Thomas Lübking
luebking added a comment. > Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh Should have scrolled down the mail ;-) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5704

D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

2017-05-03 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This workaround is there (according to the comment) for Firefox, but I still don't get any appmenu in Firefox at all. It breaks applications

D5704: Improve the x11 timestamp handling

2017-05-03 Thread Thomas Lübking
luebking added a comment. This should also mitigate the "idiotic client confused X11 time with epoch" condition (iirc some ssh per script?), yesno? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5704 To: graesslin, #kwin, #plasma Cc: luebking, plasma-devel, kwin, spst

D5704: Improve the x11 timestamp handling

2017-05-03 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin only updated the x11 timestamp if the new timestamp is larger than the existing one. While this is a useful thing it creates

D5697: Fix Output::geometry() when dealing with a scaled monitor

2017-05-03 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D5697 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, ab

D5699: Remove obsolete add_dependencies

2017-05-03 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY History suggests this originated in the kde-workspace repo. Now that khotkeys and kmenuedit are split, kmenuedit doesn't know any kded_

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2017-05-03 Thread Rog131
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #5 from Rog131 --- Dublicate / same kind of as Bug 374300 - Option to change the font color on the lock screen - https://bugs.kde.org/show_bug.cgi?id=374300 -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 374300] Option to change the font color on the lock screen

2017-05-03 Thread Rog131
https://bugs.kde.org/show_bug.cgi?id=374300 Rog131 changed: What|Removed |Added CC||samrog...@hotmail.com --- Comment #3 from Rog131 ---

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

2017-05-03 Thread David Rosca
drosca updated this revision to Diff 14109. drosca added a comment. Fix issue pointed by Zren REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5695?vs=14105&id=14109 BRANCH auto-raise-volume (branched from master) REVISION DETAIL http

D5698: Fix compile warning of treating boolean like an integer

2017-05-03 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D5698 To: davidedmundson, #plasma, mart Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

2017-05-03 Thread David Rosca
drosca added a comment. In https://phabricator.kde.org/D5695#106714, @Zren wrote: > I'm guessing the side effect of this method is that if you uncheck "force boost" when the volume is 150%, it will stay at 150% volume until you manually slide it down to below 100%? If it does, wouldn't i

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

2017-05-03 Thread Chris Holland
Zren added a comment. Hmmm, this seems better than my solution since mine stays in the boosted state (slide.maxValue=150%) after the volume when back below 100%. I'm guessing the side effect of this method is that if you uncheck "force boost" when the volume is 150%, it will stay at 150%

D5698: Fix compile warning of treating boolean like an integer

2017-05-03 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY m_modeChanges is treated like a ref counter and incremented and decremented. The type clearly should not be bool. REPOSITORY R110 K

D5697: Fix Output::geometry() when dealing with a scaled monitor

2017-05-03 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When a monitor is scaled the "size" is not the same as the mode size, we want things in global co-ordinates. This is only relevan

D5696: Update version number for 5.8.6 GIT_SILENT

2017-05-03 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. stupid arc. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D5696 To: davidedmundson Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D5696: Update version number for 5.8.6 GIT_SILENT

2017-05-03 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Update version number for 5.9.3 GIT_SILENT merge Plasma/5.8 Merge Plasma/5.9 REPOSITORY R110 KScreen Library REVISION DETA

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

2017-05-03 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When volume is above the maximum volume set in applet, moving the volume slider will only lower it to the maximum applet volume. This change

D4676: Applet: Remember last active tab

2017-05-03 Thread David Rosca
drosca abandoned this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4676 To: drosca, #vdg, #plasma Cc: mart, bshah, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5605: Allow multiple categories with the same name

2017-05-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R304:36f23700babd: Allow multiple categories with the same name (authored by mart). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5605?vs=14070&id=14103 REVISION DET

D5605: Allow multiple categories with the same name

2017-05-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH arcpatch-D5605 REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasma, leinir, whiting, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, spsta

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. Ah well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5694 To: sitter, #plasma Cc: mart, graesslin, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Marco Martin
mart added a comment. unless we add some kind of "activescreen" extension to the plasma shell wayand protocol.. (and i guess do an x11 fallback based upon kwindowsystem) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5694 To: sitter, #plasma Cc: mart, gr

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Marco Martin
mart added a comment. i fear it would need to use libtaskmanager directly, that can make things quite complicated :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5694 To: sitter, #plasma Cc: mart, graesslin, plasma-devel, spstarr, progwolff, Zren, leslie

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Harald Sitter
sitter added a comment. How to get the current screen number of the screen with the focused window? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5694 To: sitter, #plasma Cc: mart, graesslin, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Marco Martin
mart added a comment. -1 for activating all as well. I think it should try to find first a launcher on the same screen the window with focus belongs, and the current random first if not found REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5694 To: sitter

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Kai Uwe Broulik
broulik added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5694 To: sitter, #plasma Cc: graesslin, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Martin Gräßlin
graesslin added a comment. as the one who implemented this, I have to say that I disagree with the argumentation. I think it is wrong to activate all and fear that this could result in annoying issues especially as launchers close when losing focus. This could result in random launcher activ

D5694: activate all suitable launchers instead of only the first encountered

2017-05-03 Thread Harald Sitter
sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When using multiple screens, each with a default panel and thus a launcher of their own activating only one launcher makes no sense. We do no