D5540: Add a KSharedConfigPtr for kcminputrc to KWin::Application

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There are a few places where KWin needs to read values from kcminputrc. As I need to add yet another one it makes more sense to properly

D5403: Support blocking of screen edges on active fullscreen windows also for touch

This revision was automatically updated to reflect the committed changes. Closed by commit R108:e9a44a275e74: Support blocking of screen edges on active fullscreen windows also for touch (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5403

D5528: Don't map screenedge approach window if edge is only used for touch

This revision was automatically updated to reflect the committed changes. Closed by commit R108:eec6afe6f5fe: Don't map screenedge approach window if edge is only used for touch (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5528?vs=13653

D5438: [plugins/qpa] Do not replace a valid FBO with an invalid one

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ac08c5ac9d45: [plugins/qpa] Do not replace a valid FBO with an invalid one (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5438?vs=13411&id=136

D5315: Add support for keyboard layout switching policy "window"

This revision was automatically updated to reflect the committed changes. Closed by commit R108:c8274dbe5798: Add support for keyboard layout switching policy "window" (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5315?vs=13131&id=13686#toc REPOSITORY R108 KWi

D5365: Add support for keyboard layout switching policy "winclass"

This revision was automatically updated to reflect the committed changes. Closed by commit R108:b132fe7c245c: Add support for keyboard layout switching policy "winclass" (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5365?vs=13262&id=1368

D5301: Introduce support for keyboard layout switching policies

This revision was automatically updated to reflect the committed changes. Closed by commit R108:bf99d9ffdd91: Introduce support for keyboard layout switching policies (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5301?vs=13245&id=13685

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #12 from Martin Gräßlin --- Assuming the signal handler is the reason the steps to reproduce are: Let screen lock through idle timeout and during grace period lock the screen through shortcut -- You are receiving this mail because: You are

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #11 from Martin Gräßlin --- In the case of sigusr1 it could happen that memory gets allocated from the signal handler. -- You are receiving this mail because: You are the assignee for the bug.

Re: [KWin Quest. - Update] - KWin authorize external docks to manipulate tasks and windows

Am 2017-04-21 15:05, schrieb Michail Vourlakos: Following the previous discussion concerning this topic: https://www.mail-archive.com/plasma-devel@kde.org/msg62432.html https://www.reddit.com/r/kde/comments/668yul/common_developer_forum_for_docks_wayland_case/?st=j1ru5ogg&sh=5771f221 Based on

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #10 from r...@alum.mit.edu --- Note that frame 5 is a signal handler, so it's hardly surprising that frame 4 and frame 7 are unrelated. I don't know this code, but it sure looks to me like something (in the second trace, isValidBusName; in t

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #9 from Martin Gräßlin --- or another explanation could be memory corruption or even defect RAM. -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

https://bugs.kde.org/show_bug.cgi?id=378445 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #8 from

[kio-extras] [Bug 363593] In dolphin-16.04.1-1.fc25.x86_64, Unknown error code 150 when copying from phone to computer

https://bugs.kde.org/show_bug.cgi?id=363593 Elvis Angelaccio changed: What|Removed |Added Version|16.12.2 |unspecified CC|

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

https://bugs.kde.org/show_bug.cgi?id=378445 --- Comment #7 from r...@alum.mit.edu --- Still happens with kscreenlocker (and powerdevil) 5.9.4. It's rare, so I can't reproduce it reliably. And I don't have the debuginfo packages -- my normal source for KDE packages doesn't have the debuginfo pack

D5538: Implement QPlatformTheme::fileIconPixmap()

eshalygin added a comment. Ready. Works. REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5538: Implement QPlatformTheme::fileIconPixmap()

eshalygin updated this revision to Diff 13677. eshalygin added a comment. use QFileInfo::absoluteFilePath() always CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5538?vs=13676&id=13677 REVISION DETAIL https://phabricator.kde.org/D5538 AFFECTED FILES src/platformtheme/kdeplatfor

D5538: Implement QPlatformTheme::fileIconPixmap()

eshalygin added a comment. Not ready yet. REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5538: Implement QPlatformTheme::fileIconPixmap()

eshalygin updated this revision to Diff 13676. eshalygin added a comment. Fix a typo in function name CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5538?vs=13675&id=13676 REVISION DETAIL https://phabricator.kde.org/D5538 AFFECTED FILES src/platformtheme/kdeplatformtheme.cpp

D5538: Implement QPlatformTheme::fileIconPixmap()

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks OK to me. Wait for a second accept though. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, mar

D5528: Don't map screenedge approach window if edge is only used for touch

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH no-approach-touch REVISION DETAIL https://phabricator.kde.org/D5528 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening,

D5538: Implement QPlatformTheme::fileIconPixmap()

eshalygin updated this revision to Diff 13675. eshalygin added a comment. Use KIO::iconForURL() REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5538?vs=13672&id=13675 REVISION DETAIL https://phabricator.kde.org/D5538 AFF

D5438: [plugins/qpa] Do not replace a valid FBO with an invalid one

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH qpa-fbo-valid REVISION DETAIL https://phabricator.kde.org/D5438 To: graesslin, #plasma, #kwin, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, je

D5403: Support blocking of screen edges on active fullscreen windows also for touch

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH touch-edge-blocking REVISION DETAIL https://phabricator.kde.org/D5403 To: graesslin, #plasma, #kwin, leinir, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed,

D5365: Add support for keyboard layout switching policy "winclass"

mart accepted this revision. This revision is now accepted and ready to land. BRANCH keyboard-layout-policy-application REVISION DETAIL https://phabricator.kde.org/D5365 To: graesslin, #plasma, #kwin, mart Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D5315: Add support for keyboard layout switching policy "window"

mart accepted this revision. This revision is now accepted and ready to land. BRANCH keyboard-layout-policy-window REVISION DETAIL https://phabricator.kde.org/D5315 To: graesslin, #plasma, #kwin, mart Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D5301: Introduce support for keyboard layout switching policies

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH keyboard-layout-policy-desktop REVISION DETAIL https://phabricator.kde.org/D5301 To: graesslin, #plasma, #kwin, mart Cc: hein, plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-

D5063: [sddm-theme] Improve positioning of Clock

mart added a comment. this has been implemented differently, can be dropped REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5063 To: graesslin, #plasma Cc: mart, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5538: Implement QPlatformTheme::fileIconPixmap()

broulik added a comment. I would rather not support `DontUseCustomDirectoryIcons` than reimplementing all of this logic :) Perhaps we could just special-case it for `inode/directory` to return a generic folder icon. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

Re: [KWin Quest. - Update] - KWin authorize external docks to manipulate tasks and windows

I can't see that interface changing, short of bug fixes. We do want to restrict it so that not every app can (ab)use it.You positioning a panel explicitly isn't different from a supposedly sandboxed app positioning a padlock logo above the firefox address bar. How we restrict extensions but allow

D5538: Implement QPlatformTheme::fileIconPixmap()

eshalygin added a comment. In https://phabricator.kde.org/D5538#103838, @markg wrote: > But please do look at KIO::iconNameForUrl [1] (like also suggested by Kai on reviewboard). Much of the code can likely be replaced by just using that instead. It can't support QPlatformTheme::

D5538: Implement QPlatformTheme::fileIconPixmap()

markg added a comment. It pains me a bit to say this since it looks like you've spend quite a bit of time writing that code. But please do look at KIO::iconNameForUrl [1] (like also suggested by Kai on reviewboard). Much of the code can likely be replaced by just using that instead. [

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/ --- (Updated April 21, 2017, 3:57 p.m.) Status -- This change has been d

D5538: Implement QPlatformTheme::fileIconPixmap()

eshalygin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work. TEST PLAN Manual testing REPOSITORY R135 Integration for Qt

[KWin Quest. - Update] - KWin authorize external docks to manipulate tasks and windows

Following the previous discussion concerning this topic: https://www.mail-archive.com/plasma-devel@kde.org/msg62432.html https://www.reddit.com/r/kde/comments/668yul/common_developer_forum_for_docks_wayland_case/?st=j1ru5ogg&sh=5771f221 Based on the latest information, external docks can use t

D4893: Layout and animations on the on screen keyboard

graesslin added a comment. In https://phabricator.kde.org/D4893#103772, @mart wrote: > In https://phabricator.kde.org/D4893#103745, @graesslin wrote: > > > Just verified: reverting this change also fixes the issues mentioned for Wayland. > > > i think i found the problem, it was

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 116 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/116/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Apr 2017 12:03:44 + Build duration: 6 min 57 sec CHANGE SET Revision 71908e79626b240d1

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #7 from Kai Uwe Broulik --- We could do some horrible RegExp thing I suppose (oh I already look forward to the outcry how you cannot use regular expressions with XML :P), I'll try to come up with something. -- You are receiving this mail b

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #6 from Christian --- (In reply to Kai Uwe Broulik from comment #4) > We run QXmlStreamReader over the page to find the og:image of the picture. > > However, HTML isn't strictly XML and so it chokes on the lines which come > before the "og:

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #5 from Christian --- (In reply to Clemens from comment #3) > In my case, it does not work at all. > Even after I reboot, the picture is not available. > > Plasma Version 5.9.4 I guess I wasn't being clear. Even before it started not worki

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

> On April 21, 2017, 11:12 a.m., Kai Uwe Broulik wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 122 > > > > > > Why is this only built in 5.7 and below? Was this removed in 5.8? > > (didn't check Qt cod

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

> On April 21, 2017, 9:12 vorm., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > Plasma reviews are nowadays handled on https://phabricator.kde.org/ - could > > you perhaps upload it there again? I just don't want it to get lost here :/ > > > > Also, I'm not sure about having a separ

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

> On April 21, 2017, 11:12 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > Plasma reviews are nowadays handled on https://phabricator.kde.org/ - could > > you perhaps upload it there again? I just don't want it to get lost here :/ > > > > Also, I'm not sure about having a separ

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

> On April 21, 2017, 11:12 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > Plasma reviews are nowadays handled on https://phabricator.kde.org/ - could > > you perhaps upload it there again? I just don't want it to get lost here :/ > > > > Also, I'm not sure about having a separ

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 866 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/866/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Apr 2017 09:39:48 + Build duration: 6 min 51 sec CHANGE SET Revision 3671cbdbe50712933ac77a77675d

D4893: Layout and animations on the on screen keyboard

mart added a comment. In https://phabricator.kde.org/D4893#103745, @graesslin wrote: > Just verified: reverting this change also fixes the issues mentioned for Wayland. i think i found the problem, it was looking for VirtualKeyboard.qml in the wrong path, now it should work REPO

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 Kai Uwe Broulik changed: What|Removed |Added Ever confirmed|0 |1 CC|

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/#review103073 --- Thanks for your patch! Plasma reviews are nowadays handled

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

> On April 21, 2017, 11:01 a.m., Mark Gaiser wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 422 > > > > > > foreach OR for (... : qAsConst(m_standardPathItems)) > > Or use std::vector and keep the fo

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/ --- (Updated April 21, 2017, 11:11 a.m.) Review request for Plasma. Changes

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/#review103072 --- src/platformtheme/kdeplatformtheme.cpp (line 421)

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 Clemens changed: What|Removed |Added CC||em...@clemens-karner.eu --- Comment #3 from Clemens

Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/ --- Review request for Plasma. Repository: plasma-integration Description -