D4712: Ungrab mouse on menu close

2017-04-19 Thread Anthony Fieroni
anthonyfieroni added a comment. Why QTimer is better solution? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4712 To: anthonyfieroni, #plasma, mart, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D5520: [platforms/x11] Do not grab touch events

2017-04-19 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Grabbing the touch events seems to cause issues. It seems to also grab pointer events from touchpad and breaks touch input on other even

D4893: Layout and animations on the on screen keyboard

2017-04-19 Thread Martin Gräßlin
graesslin added a comment. I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and on Wayland it's impossible to unlock the screen. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4893

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 123 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/123/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 03:29:43 + Build duration: 18 min CHANGE SET Revision 1e031b905565204aeb15ecd87

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 862 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/862/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 02:18:44 + Build duration: 36 min CHANGE SET Revision e9e3ea254124538ff5165366adb7a31095

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 721 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/721/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 02:18:29 + Build duration: 9 min 32 sec CHANGE SET Revision 0463667e5a82058550d71cbafc9f59

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R495:ef8548fadc39: Nextcloud upload purpose plugin (authored by Lim Yuen Hoe ). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5464?vs=13598&id=13619 REVISION D

D4712: Ungrab mouse on menu close

2017-04-19 Thread David Edmundson
davidedmundson added a comment. Well, now that I understand the bug, I would say this isn't right. If I dismiss the menu by clicking something else in the original qtquick scene, the events won't happen in the order you want. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim added a comment. Sure! I was planning to. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, #plasma, apol Cc: davidedmundson, graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 122 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/122/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 20:12:25 + Build duration: 17 min CHANGE SET Revision 076091e8ee8be54e6c92c1026

[Powerdevil] [Bug 378976] New: Crash after resume from suspend

2017-04-19 Thread Thomas Mitterfellner
https://bugs.kde.org/show_bug.cgi?id=378976 Bug ID: 378976 Summary: Crash after resume from suspend Product: Powerdevil Version: 5.9.4 Platform: Other OS: Linux Status: UNCONFIRMED Severity: crash

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-19 Thread Anthony Fieroni
anthonyfieroni added a comment. https://phabricator.kde.org/D4712 https://phabricator.kde.org/D4711 It has one unfixible case, dismiss context menu by clicking on onther window. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmu

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-19 Thread Michail Vourlakos
mvourlakos added a comment. I had reported qts faulty behavior concerning centextmenus at: https://bugreports.qt.io/browse/QTBUG-59044 I think it is the mentioned case... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmundson

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-19 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There was an unidentified bug where when opening a context menu in response to a mousePress event led to the nex

D4806: [greeter] Send the auth result through the server instead return value

2017-04-19 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:d666fe879d46: [greeter] Send the auth result through the server instead return value (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4

D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

2017-04-19 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:5e3c7b337c95: Use seccomp for implementing a sandbox for kscreenlocker_greet (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5029?vs=13189&id=13604#toc REPOSITORY R13

D4997: Support for long running kcheckpass supporting multiple authentications

2017-04-19 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:07d38ba65adc: Support for long running kcheckpass supporting multiple authentications (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

Re: Make xdg-desktop-portal-kde part of Plasma release

2017-04-19 Thread Harald Sitter
+1 On Wed, Apr 19, 2017 at 2:08 PM, Jan Grulich wrote: > Hi, > > I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into > Plasma to have it released with Plasma 5.10 and so on. > > What is xdg-desktop-portal-kde: > It's a KDE implementation of Flatpak portals backend [2], cu

D5510: Improve how we set up the flatpak backend

2017-04-19 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove the scope semantic and make the installation part of each resource. REPOSITORY R134 Discover Software Store BRANCH flatpak-installati

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Okay, let's integrate it and then we see how it works. Can you maybe blog about it so the world knows? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

2017-04-19 Thread Eike Hein
hein added a comment. Will fix lukas' error tomorrow, please review past it in the meantime in case there's more :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5505 To: hein, #plasma, davidedmundson, lukas Cc: lukas, plasma-devel, spstarr, progwolff, lesl

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 861 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/861/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 13:46:38 + Build duration: 14 min CHANGE SET Revision e72aedace91651eefc711912cede12ae04

Re: Make xdg-desktop-portal-kde part of Plasma release

2017-04-19 Thread Aleix Pol
On Wed, Apr 19, 2017 at 3:35 PM, Jonathan Riddell wrote: > On Wed, Apr 19, 2017 at 02:08:52PM +0200, Jan Grulich wrote: >> Hi, >> >> I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into >> Plasma to have it released with Plasma 5.10 and so on. > > why the name xdg-desktop-p

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 860 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/860/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 13:30:41 + Build duration: 15 min CHANGE SET Revision 4d3760c8aa9d6a99e5239019fb9a29aab2

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 114 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/114/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 13:36:35 + Build duration: 5 min 44 sec CHANGE SET Revision ecbcf6f831020b415

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 113 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 13:27:45 + Build duration: 6 min 35 sec CHANGE SET Revision 4d3760c8aa9d6a99e

Re: Make xdg-desktop-portal-kde part of Plasma release

2017-04-19 Thread Jonathan Riddell
On Wed, Apr 19, 2017 at 02:08:52PM +0200, Jan Grulich wrote: > Hi, > > I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into > Plasma to have it released with Plasma 5.10 and so on. why the name xdg-desktop-portal? Isn't flatpak-something more appropriate? Jonathan

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim updated this revision to Diff 13598. yuenlim added a comment. Oops minor mistake. Forgot to remove the declaration of createTargetUrl REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5464?vs=13596&id=13598 REVISION DETAIL https://phabricato

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim marked 2 inline comments as done. yuenlim added a comment. Hope the translation domain part is correct. I only found it in the phabricator plugin's CMakeLists, most of the other plugins don't seem to have it. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kd

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Yuen Hoe Lim
yuenlim updated this revision to Diff 13596. yuenlim added a comment. Addressed comments! REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5464?vs=13470&id=13596 REVISION DETAIL https://phabricator.kde.org/D5464 AFFECTED FILES src/plugins/CMakeL

Re: Make xdg-desktop-portal-kde part of Plasma release

2017-04-19 Thread Jonathan Riddell
On 19 April 2017 at 13:08, Jan Grulich wrote: > I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into > Plasma to have it released with Plasma 5.10 and so on. > > What is xdg-desktop-portal-kde: > It's a KDE implementation of Flatpak portals backend [2], currently with > sup

Re: Make xdg-desktop-portal-kde part of Plasma release

2017-04-19 Thread Aleix Pol
On Wed, Apr 19, 2017 at 2:08 PM, Jan Grulich wrote: > Hi, > > I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into > Plasma to have it released with Plasma 5.10 and so on. > > What is xdg-desktop-portal-kde: > It's a KDE implementation of Flatpak portals backend [2], curren

Make xdg-desktop-portal-kde part of Plasma release

2017-04-19 Thread Jan Grulich
Hi, I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] into Plasma to have it released with Plasma 5.10 and so on. What is xdg-desktop-portal-kde: It's a KDE implementation of Flatpak portals backend [2], currently with support of AppChooser, FileChooser, Notification and

D5504: Introduce a HasLauncher data role.

2017-04-19 Thread David Edmundson
davidedmundson added a comment. appsMatch depends on AppId and LauncherURLWithoutIcon You're handling launcherTasksModel changing, but can we rely on this data being static for a proxyIndex? If not, we need to connect to TasksModel::dataChanged for those roles and potentially then e

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

2017-04-19 Thread Lukáš Tinkl
lukas requested changes to this revision. lukas added a comment. This revision now requires changes to proceed. See the inline comment INLINE COMMENTS > main.qml:92 > +property int logicalLauncherCount: { > +if (plasmoid.configuration.seperateLaunchers) { > +

D5507: Don't even try to scale images that we created ad-hoc

2017-04-19 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D5507 AFFECTED FILES src/desktopicon.cpp To: apol, #kirigami, mart C

D5497: Improved Suggestions Model

2017-04-19 Thread Aleix Pol Gonzalez
apol added a comment. Okay, well, you know your code, but it all looks fishy. Maybe it would be interesting for you to have upstream mycroft people involved. REPOSITORY R846 Mycroft Plasma integration REVISION DETAIL https://phabricator.kde.org/D5497 To: Aiix Cc: apol, plasma-devel, s

D5464: Nextcloud Upload Purpose Plugin

2017-04-19 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. +1 Please look at David's comments and we'll integrate it. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D5464 To: yuenlim, #plasma, apol Cc: davi

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

2017-04-19 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY When "Keep launchers seperate" is disabled, startup notifications replace launchers at their original position. This changes the layout for this mode to keep the startup notification item the size

D5504: Introduce a HasLauncher data role.

2017-04-19 Thread Eike Hein
hein added a dependent revision: D5505: Keep startup notifications launcher-sized when inserting at launcher position.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5504 To: hein, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-

D5504: Introduce a HasLauncher data role.

2017-04-19 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This is implemented by TasksModel and allows clients to reliably query whether a row has an associated launcher. Useful for things like Pin/Unpin action state or layout decisions. Previously cli

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 112 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 10:38:04 + Build duration: 20 min CHANGE SET Revision e34b0064d6ff787270127d2

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 859 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/859/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 10:38:49 + Build duration: 9 min 14 sec CHANGE SET Revision e34b0064d6ff787270127d261be6

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 720 - Still Unstable!

2017-04-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/720/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 07:17:34 + Build duration: 7 min 32 sec CHANGE SET Revision df9cee28e120167414a5ae79e4835c

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 940 - Fixed!

2017-04-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/940/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 04:07:02 + Build duration: 9 min 51 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 940 - Fixed!

2017-04-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/940/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 04:07:02 + Build duration: 9 min 51 sec CHANGE SET No changes JUNIT RESULTS Name:

D5499: Fix new checkbox for file content indexing in kcm_baloofile

2017-04-19 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R119:df9cee28e120: Fix new checkbox for file content indexing in kcm_baloofile (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5499?vs=13578&i