dvogel updated this revision to Diff 13586.
dvogel added a comment.
Addition of a QTimer set by default to 1 sec to filter setBrightness calls:
the actual DDC communication happens 1 sec after the last setBrightness() call.
This solves brightness flickering when scrolling quickly on the batt
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/858/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 22:04:33 +
Build duration: 42 min
CHANGE SET
Revision 3468d970dbebf9892a3b1648973adcb226
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/111/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 22:00:03 +
Build duration: 44 min
CHANGE SET
Revision 58206408a35a0900b567823
Aiix added a comment.
In https://phabricator.kde.org/D5497#103180, @apol wrote:
> Isn't mycroft supposed to do the language parts? is it mandatory to have
this huge list?
mycroft is doing the language parts, but i don't think currently i can
utilize its skills output capability y
davidedmundson added inline comments.
INLINE COMMENTS
> CMakeLists.txt:8
> +
> +
you need to set the translation domain (copy and paste the line from another
CMakeLists)
> nextcloudjob.cpp:82
> +
> +void NextcloudJob::checkTargetFile(const int suffix, const QUrl& local,
> KJob* j)
> +{
Repla
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/939/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 18:27:37 +
Build duration: 14 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (root
yuenlim added a comment.
Ping :) Think someone can help me review this?
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D5464
To: yuenlim, #plasma, apol
Cc: graesslin, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, a
apol added a comment.
Isn't mycroft supposed to do the language parts? is it mandatory to have this
huge list?
REPOSITORY
R846 Mycroft Plasma integration
REVISION DETAIL
https://phabricator.kde.org/D5497
To: Aiix
Cc: apol, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jens
broulik closed this revision.
broulik added a comment.
https://cgit.kde.org/plasma-workspace.git/commit/?id=550860f6366cc99d3f0ff19f74fd3fc3d1bfc0ad
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5481
To: broulik, #plasma, davidedmundson
Cc: plasma-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:58206408a35a: When deleting the panel the notifications
applet is in, the containment is… (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5321?vs=13155&id=13582#toc
REPOS
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:ffd101f129a9: Make sure the backend has been set up
properly (authored by apol).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5495?vs=13572&id=135
leszeklesner edited the summary of this revision.
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D5490
To: leszeklesner, broulik
Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel,
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, ab
ltoscano added a comment.
While you fix the issue with the code, please add a line
BUG: 372635
in the summary instead of the other reference to the bug; this should send a
notification and close the bug when the review is accepted.
REPOSITORY
R112 Milou
REVISION DETAIL
https://
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5499
To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreut
fvogt created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Needs a new connection to enable the "Apply" button.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5499
AFFECTED FILES
kcms/baloo/kcm.cpp
To: fvo
https://bugs.kde.org/show_bug.cgi?id=376344
--- Comment #13 from fbr ---
(In reply to Elvis Angelaccio from comment #12)
> (In reply to fbr from comment #11)
> > (In reply to mathojojo from comment #10)
> > > Hello,
> > >
> > > Just wondering... Why is this bug still in "UNCONFIRMED" Status ?? T
https://bugs.kde.org/show_bug.cgi?id=376344
--- Comment #12 from Elvis Angelaccio ---
(In reply to fbr from comment #11)
> (In reply to mathojojo from comment #10)
> > Hello,
> >
> > Just wondering... Why is this bug still in "UNCONFIRMED" Status ?? The bug
> > has been reported here many times,
Aiix created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ref https://phabricator.kde.org/T5892
Provide suggestions and randomization on each char text entry, Match
characters and inital predict wor
https://bugs.kde.org/show_bug.cgi?id=376344
--- Comment #11 from fbr ---
(In reply to mathojojo from comment #10)
> Hello,
>
> Just wondering... Why is this bug still in "UNCONFIRMED" Status ?? The bug
> has been reported here many times, and on duplicates as well...
I agree with you... many pe
apol abandoned this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5492
To: apol, jgrulich
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
davidedmundson added a comment.
RE: your message on IRC this morning.
Yes, you should submit this.
I explained in my comment why it's needed. It's not quite for the reason you
initially said, but the solution is still valid.
Ideally fix your comment about the containment being gone
apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5495
AFFECTED FILES
libdiscover/backends/FlatpakBackend
apol updated this revision to Diff 13571.
apol added a comment.
- Better assert on flatpak successfully set up
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5492?vs=13567&id=13571
BRANCH
master
REVISION DETAIL
https://phabricator.kde.
Am 2017-04-18 13:55, schrieb Luca Beltrame:
Hi everyone,
this is basically the same discussion as already took place for 5.8.
According to distrowatch, it looks very much like we're currently the
_only_
remaining Top 10 distro with KDE (Plasma+Apps) installed and used by
default.
Not only has
On Tue, Apr 18, 2017 at 1:55 PM, Luca Beltrame wrote:
> Hi everyone,
>
> this is basically the same discussion as already took place for 5.8.
>
> According to distrowatch, it looks very much like we're currently the _only_
> remaining Top 10 distro with KDE (Plasma+Apps) installed and used by defa
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/857/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 11:37:23 +
Build duration: 18 min
CHANGE SET
Revision 71dda89bb80d69bd8fe0d77c3e28075341
leszeklesner added a comment.
In https://phabricator.kde.org/D5490#103059, @lfurmetz wrote:
> In https://phabricator.kde.org/D5490#103053, @anthonyfieroni wrote:
>
> > You can do this:
> >
> > property bool moved: false
> > onMovedChanged: if (moved) {
> > listView.cu
lfurmetz added a comment.
In https://phabricator.kde.org/D5490#103053, @anthonyfieroni wrote:
> You can do this:
>
> property bool moved: false
> onMovedChanged: if (moved) {
> listView.currentIndex = index
> }
> onPositionChanged: {
> ...
> moved = true;
leszeklesner updated this revision to Diff 13568.
leszeklesner edited the summary of this revision.
REPOSITORY
R112 Milou
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5490?vs=13561&id=13568
REVISION DETAIL
https://phabricator.kde.org/D5490
AFFECTED FILES
lib/qml/ResultDelegate
apol abandoned this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5492
To: apol, jgrulich
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/719/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 09:32:41 +
Build duration: 27 min
CHANGE SET
Revision 87f4c65282b97abc1c292f635df1960de57c
anthonyfieroni added a comment.
You can do this:
property bool moved: false
onMovedChanged: if (moved) {
listView.currentIndex = index
}
onPositionChanged: {
...
moved = true;
}
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D5490
jgrulich added a comment.
We still do need this, in flatpak backend this library is used on many places.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5492
To: apol, jgrulich
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterb
leszeklesner added a comment.
In https://phabricator.kde.org/D5490#103049, @davidedmundson wrote:
> Yes, and you have this boolean separately for each delegate.
>
> So I can see how this supresses that initial selection in your bug report;
but surely it will also supress every other n
davidedmundson added a comment.
Yes, and you have this boolean separately for each delegate.
So I can see how this supresses that initial selection in your bug report;
but surely it will also supress every other normal case after that.
When we move from one delegate to another the fi
apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5492
AFFECTED FILES
CMakeLists.txt
To: apol, jgrulich
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:639bf33c0192: Queue some connections which cannot be
autodetected (authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5409?vs=13386&id=13566#toc
REPOSITORY
R134 Discover Sof
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Go for it, let's see how it goes.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5409
To: leinir, #discover_software_store, apol
Cc: plasma-devel, sps
leszeklesner added a comment.
In https://phabricator.kde.org/D5490#103036, @davidedmundson wrote:
> Yes, I can see what the code is doing, but I don't see how that means it
works.
>
> > will be then set to true so that when you move the mouse on an item
onContainsMouseChanged is call
davidedmundson added a comment.
Yes, I can see what the code is doing, but I don't see how that means it
works.
> will be then set to true so that when you move the mouse on an item
onContainsMouseChanged is called again and because __moved is now true sets the
index accordingly.
W
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:e5574b458abb: Improve password dialogs (authored by
jgrulich).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5382?vs=13317&id=13565
REVIS
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
password-dialogs
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich, #vdg, #plasma, mart
Cc: fabianr, mart, broulik, plasma-devel, spstarr, pro
Hi everyone,
this is basically the same discussion as already took place for 5.8.
According to distrowatch, it looks very much like we're currently the _only_
remaining Top 10 distro with KDE (Plasma+Apps) installed and used by default.
Not only has Ubuntu switched to GNOME, for openSUSE there's
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/110/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 08:20:01 +
Build duration: 27 min
CHANGE SET
Revision 1a26abe5b0e6af45eab95a6
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/856/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 18 Apr 2017 08:19:36 +
Build duration: 27 min
CHANGE SET
Revision e99f396713db6d13b0ba620df96b1513e1
fabianr added a comment.
+1, other then the spacing mentioned above, I like the change.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D5382
To: jgrulich, #vdg, #plasma
Cc: fabianr, mart, broulik, plasma-devel, spstarr, progwolff, lesliezhai,
leszeklesner added a comment.
In https://phabricator.kde.org/D5490#103017, @davidedmundson wrote:
> Copying my reply from RB, to keep this in one place:
>
> Sorry for being dim, but I don't understand how this is meant to work.
Basically it should not set the currentIndex to in
davidedmundson added a comment.
Copying my reply from RB, to keep this in one place:
Sorry for being dim, but I don't understand how this is meant to work.
In order for __moved to be true in containsMouseChanged:
You're either expecting to get a hoverMoveEvent followed by a
hoverEn
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c06013e88e4f: Don't forward keys until the recipient is
ready (authored by leinir).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5408?vs=13374&id=13562
REVISION
leszeklesner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Use a new variable __moved to detect if mouse moved and only change index if
the mouse moved. This helps preventing index changes when on
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D5408
To: leinir, #kirigami, apol, mart
Cc: plasma-devel, apol
mart accepted this revision.
This revision now requires changes to proceed.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D5408
To: leinir, #kirigami, apol, mart
Cc: plasma-devel, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:87f4c65282b9: Adding an option to show popular
documents/apps for Kicker and Dash (authored by ivan).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5378?vs=
hein accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D5378
To: ivan, mart, hein
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:27efb8b19577: [Plasma Windowed] Emit
contextualActionsAboutToShow before showing them (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:71dda89bb80d: [Plasma Windowed] Disable standard actions
on SNI (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5333?vs=13198&id=1355
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e99f396713db: [Notifications] Introduce "settings" action
(authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5424?vs=13377&id=13556
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1a26abe5b0e6: Fix losing wallpaper selection when
clicking "Apply". (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5440?vs=13440&id=135
fabianr added a comment.
I like the change, the text button was too striking. the icon is much better
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5424
To: broulik, #vdg, #plasma, markg, mck182
Cc: fabianr, andreaska, mck182, markg, plasma-devel, spstarr,
andreaska added a comment.
look good to me +1
thanks for the improvement
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5424
To: broulik, #vdg, #plasma, markg, mck182
Cc: andreaska, mck182, markg, plasma-devel, spstarr, progwolff, lesliezhai,
ali-moha
60 matches
Mail list logo
