D5488: Improve the escape key handling for breaking constrained pointers

2017-04-17 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin started to filter out the escape key as soon as it gets pressed. This was done by unsetting keyboard focus. The idea was to

D5487: Set xrdb XFT.DPI value as integer

2017-04-17 Thread Lukas Hetzenecker
hetzenecker added a comment. Awesome! Looks good, this fixes the wrong icon sizes in plasma. "xrdb -query" reports the correct size and .config/kcmfonts now also stores the integer value. This means the "Force fonts DPI" size is now also shown in the Fonts systemsettings module. Tes

D5487: Set xrdb XFT.DPI value as integer

2017-04-17 Thread David Edmundson
davidedmundson updated this revision to Diff 13550. davidedmundson added a comment. fixup REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5487?vs=13549&id=13550 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5487 AFFECTED FILES kcm/src/s

D5487: Set xrdb XFT.DPI value as integer

2017-04-17 Thread Lukas Hetzenecker
hetzenecker added inline comments. INLINE COMMENTS > scalingconfig.cpp:124 > { > -return scaleFactor() * 96.0; > +return qRound(scaleFactor()) * 96.0; > } I'd propse qRound(scaleFactor() * 96.0) to get int values. If the scaleFactor is rounded, we only get multiplies of 96 as DPI.

D5487: Set xrdb XFT.DPI value as integer

2017-04-17 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QXcbScreen when loading uses QByteArray.toInt(). QByteArray("152.23").toInt() returns 0, rather than a rounded version, this mean

D5440: Fix losing wallpaper selection when clicking "Apply".

2017-04-17 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D5440 To: hein, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, spstarr, progwolff, leslie

D5481: [Media Controller] Use double for length instead of int

2017-04-17 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5481 To: broulik, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 855 - Still Unstable!

2017-04-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/855/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Apr 2017 11:18:43 + Build duration: 20 min CHANGE SET Revision 14d3df9854a1151ba977cdc249c1ae0e58

D5481: [Media Controller] Use double for length instead of int

2017-04-17 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5481 To: broulik, #plasma Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5481: [Media Controller] Use double for length instead of int

2017-04-17 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Length is in microseconds, so watching a long video (in excess of like 30-40 minutes) will break the slider. BUG: 377623 FIXED-IN: 5.8.