broulik added a comment.
> (We should look into contributing that.)
https://doc.qt.io/qt-5/qml-qt-labs-platform-standardpaths.html
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5170
To: Zren, hein
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mo
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/676/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 25 Mar 2017 02:00:33 +
Build duration: 6 min 17 sec
CHANGE SET
Revision d04dc0a5bcfae610d58898dd2cb94c
hein added a comment.
I think it would be OK to add an enum to SystemSettings and Q_ENUM it, and
initialize the values to QStandardPath enum values. It's not pretty but then
the entire thing isn't - it exists in the hope that upstream will add a
Qt.standardLocation() or so so we can drop it.
Zren added a comment.
Thought you might want that, but wasn't sure how to expose QStandardPaths to
QML. Got an example handy? All I can find is:
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmacomponents/enums.h
https://github.com/KDE/plasma-framework/
hein added a comment.
Instead of having lots of invokables, it would probably be nicer to just
register the enum and make one invokable (standardLocation), then port the
callsite in Kicker.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5170
To: Zren, hein
Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In TiledMenu, I need access to the localized home directories so I can link
to the right folders in the bottom left area above the power icon.
cfeck added inline comments.
INLINE COMMENTS
> kpci.cpp:96
> // line.setAscii(nameBuffer); //not work,
> workaround below
> - line = QString::fromAscii(pci_lookup_name(PCIAccess,
> nameBuffer, NAME_BUFFER_SIZE, PCI_LOOKUP_VENDOR, info->cooked.vendor, 0, 0,
rthomsen updated this revision to Diff 12779.
rthomsen added a comment.
Add KCrash integration.
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5169?vs=12777&id=12779
REVISION DETAIL
https://phabricator.kde.org/D5169
AFFECTED FILES
CMakeLists.txt
cfeck added a comment.
Please add KCrash integration (which was done automatically for KApplication,
but not for QApplication).
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D5169
To: rthomsen, #plasma, elvisangelaccio
Cc: cfeck, plasma-devel, progwolff, leslie
rthomsen created this revision.
rthomsen added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Remove dependency on KDELibs4Support.
NOTE: I didn't port the `RAW1394` module, since I can't build that.
TEST PLAN
Everything works and looks norma
mart added a comment.
In https://phabricator.kde.org/D5166#97372, @apol wrote:
> Shouldn't we make the ApplicationWindow use the ApplicationItem instead of
fully forking the code?
I'm not sure it's possible, as it would change the parent/child relationships
of contentItem/header/
apol added a comment.
Shouldn't we make the ApplicationWindow use the ApplicationItem instead of
fully forking the code?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D5166
To: mart, #kirigami, leinir, apol
Cc: plasma-devel, apol
mart created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This item, can emulate ApplicationWindow and
is supposed to be used in applications that for some reason
need the UI to be loaded in QQuickV
graesslin added a comment.
In https://phabricator.kde.org/D4806#96684, @subdiff wrote:
> Since there seem to be not many others I'll try to give you reviews for
this and your following patches, but first I've to understand this stuff.
>
> Tell me if the following is right:
>
> Unt
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5088
To: apol, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, hein, plasma-devel, progwol
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
BRANCH
screenedge-touch-xinput
REVISION DETAIL
https://phabricator.kde.org/D5137
To: graesslin, #plasma, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensre
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/97/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 15:03:07 +
Build duration: 10 min
CHANGE SET
Revision 0754179a134bb9be149cd7a932
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/675/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 15:04:07 +
Build duration: 9 min 46 sec
CHANGE SET
Revision 0ae49bb4fbc5f1f798cb7e8907db7e
graesslin updated this revision to Diff 12767.
graesslin added a comment.
Next try
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5137?vs=12748&id=12767
BRANCH
screenedge-touch-xinput
REVISION DETAIL
https://phabricator.kde.org/D5137
AFFECTED FILES
gestures.h
plugins/platf
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xinputintegration.cpp:132
> you've reordered this now.
>
> const auto last = m_lastTouchPositions.value(e->detail);
>
> needs to happen before you update m_lastTouchPositions
argh, it gets embarrassing
REVISION DETAIL
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/674/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 14:04:26 +
Build duration: 16 min
CHANGE SET
Revision b80a8aa51456804e25385d6386df8afac1d7
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b80a8aa51456: Port custom image mode to IconItem.
(authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5162?vs=12764&id=12766
REVISION DETAIL
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5162
To: hein, #plasma, broulik, mart
Cc: mart, apol, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
denisshienkov added a comment.
ping
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4939
To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai,
ali-mohamed, jensreuterbe
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bc33f0470d4d: Set implicit size from source size for
image/SVG URL sources. (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D51
hein updated this revision to Diff 12764.
hein added a comment.
Use speed trick suggested by apol.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5162?vs=12754&id=12764
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5162
AFFECTED F
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/100/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 12:10:15 +
Build duration: 22 min
CHANGE SET
Revision 37ac27c59d97db3bb173ae1
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/816/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 10:27:38 +
Build duration: 14 min
CHANGE SET
Revision 64d4217e35d2cf6a8aa1f15d2cb3ec736ab
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/816/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 10:27:38 +
Build duration: 14 min
CHANGE SET
Revision 64d4217e35d2cf6a8aa1f15d2cb3ec736ab
mart added a comment.
+1
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5162
To: hein, #plasma, broulik
Cc: mart, apol, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R133 KScreenLocker
BRANCH
emergency-show-wayland
REVISION DETAIL
https://phabricator.kde.org/D5157
To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterb
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5160
To: hein, #plasma, mart, davidedmundson
Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, al
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/815/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 09:47:56 +
Build duration: 10 min
CHANGE SET
Revision d9f4e11261ef0fcc31bf144d880009b629a
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/814/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Mar 2017 09:36:03 +
Build duration: 11 min
CHANGE SET
Revision 436abf6c2147bc4c77081597b8942a0a312
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3dc5886e62d1: improve position of Clock (authored by
mart, committed by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5126?vs=12676&id=12
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:436abf6c2147: Remove ifdef round qCDebugs (authored by
davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4965?vs=12249&id=12760#toc
REPOSITORY
R120 Plasma Workspace
CHANGES SI
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R120:9df815e843a4: Inject mouse clicks from SNI to xembedded
icons with XTest (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in sniproxy.cpp:81
> You mean Direct here, no?
I do, good catch.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5156
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xinputintegration.cpp:132
> Sorry that's not quite what i meant
>
> m_lastTouchPositions now needs to use e->detail
>
> And the gestureRecognizer stuff should still be inside the if.
you've reordered this now.
con
39 matches
Mail list logo
