Re: Plasma 5.9.4

On Thu, Mar 23, 2017 at 10:39 PM, Tobias C. Berner wrote: > Well, I started to update this only *after* I read the announcement mail > (according to my memory 16:30-ish CET). > 1490110785 is 03/21/2017 15:39 (UTC)... so well after that : > > So probably the mirror used to fetch the files was not y

D5156: Inject mouse clicks from SNI to xembedded icons with XTest

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. meh REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5156 To: davidedmundson, #plasma, graesslin Cc: graesslin, anthonyfieroni, plas

D5162: Port custom image mode to IconItem.

apol added inline comments. INLINE COMMENTS > CompactRepresentation.qml:30 > +readonly property bool useCustomButtonImage: > (plasmoid.configuration.useCustomButtonImage > +&& plasmoid.configuration.customButtonImage != "") > property QtObject dashWindow: null I've read several

D5160: Set implicit size from source size for image/SVG URL sources.

drosca added a comment. You don't reset the implicitSize anywhere, so if you do setSource(QImage) and then setSource(QIcon) it will still have the implicitSize of the previously set QImage. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5160 To:

D5160: Set implicit size from source size for image/SVG URL sources.

hein updated this revision to Diff 12755. hein added a comment. Always update implicit size. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5160?vs=12752&id=12755 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5160 AFFE

D5160: Set implicit size from source size for image/SVG URL sources.

hein added a comment. That was me being sleepy and trying to be smart and cunning and avoid busywork :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5160 To: hein, #plasma, mart, davidedmundson Cc: drosca, plasma-devel, #frameworks, progwolff,

D5162: Port custom image mode to IconItem.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Simplifies compact representation to always using IconItem, now that IconItem supports displaying non-square image sources. Fixes missing hover highlight effect for custom image launcher buttons

D5160: Set implicit size from source size for image/SVG URL sources.

hein added a dependent revision: D5162: Port custom image mode to IconItem.. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5160 To: hein, #plasma, mart, davidedmundson Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D5160: Set implicit size from source size for image/SVG URL sources.

hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This allows users of IconItem to know the aspect ratio of the source document, which can be used to size the item or set applet size

D5158: Support the emergency show property on ksld's lock screen window

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The emergency show window should be considered as a lock screen window and be shown while the screen is locked. This is the KWin part to

D5157: Add support for emergency message show on Wayland

graesslin added a comment. F3164981: emergency-wayland.png emergency show on a nested Wayland compositor. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5157 To: graesslin, #kwin, #plasma Cc: plasma-devel, progwolff, les

D5157: Add support for emergency message show on Wayland

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When playing with the lockscreen I noticed that the emergency show does not work on Wayland and one only gets a black screen if the system

D5156: Inject mouse clicks from SNI to xembedded icons with XTest

anthonyfieroni added inline comments. INLINE COMMENTS > sniproxy.cpp:81 > +m_windowId(wid), > +m_injectMode(XTest) > { You mean Direct here, no? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5156 To: davidedmundson, #plasma Cc: anthonyfieroni, plas

D5137: Add support for screenedge touchscreen events through XInput 2.2

graesslin updated this revision to Diff 12748. graesslin added a comment. Try two :-) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5137?vs=12714&id=12748 BRANCH screenedge-touch-xinput REVISION DETAIL https://phabricator.kde.org/D5137 AFFECTED FILES gestures.h plugins/pl

D5156: Inject mouse clicks from SNI to xembedded icons with XTest

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A certain toolkit doesn't register for mouse press release events because it now uses XI2 only. Injecting those directly to the w

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Before tackling the implicitWidth/height stuff, I noticed that my microphone's Heading label was getting moved on the first click. Adding `height: contextMenuButton.height` fixes it but that doesn't feel right. https://streamable.com/07hc0 REPOSITORY R115 Plasma

D5144: Change the volume icon/mute button into a ToolButton

drosca added inline comments. INLINE COMMENTS > SmallToolButton.qml:11 > +property int padding: units.smallSpacing > +Layout.preferredWidth: iconSize + padding * 2 > +Layout.preferredHeight: iconSize + padding * 2 This won't work when not in Layout, I think you can use implicitWidth/

D5144: Change the volume icon/mute button into a ToolButton

Zren updated this revision to Diff 12746. Zren added a comment. Create a reusuble SmallToolButton class. Add smallSpacing around the mute button. Remove spacing between the two rows to counter the increase in height. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Another thing we could do to keep things small vertically is set `spacing: 0` in the `ColumnLayout { id: column }`. F3154383: 2017-03-23___11-50-47.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://pha

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Ah, ignore the `visible: false` in that, was testing which variables ToolButton uses (iconSource. iconName). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5144 To: Zren, #plasma, subdiff, drosca Cc: subdiff, drosca, plasma-

D5144: Change the volume icon/mute button into a ToolButton

Zren added a comment. Yeah, it's probably dpi scaling. And I didn't want to mess with the height of the ListItemBase. On further testing, it seems adding smallSpacing margins isn't as bad as I thought. Back and Forth Gif: https://streamable.com/0ld55 F3154040: 2017-03-23___11-12

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

rikmills added a comment. I note that in recent Breeze, the native scrollbar are a fair amount thinner, so maybe a reduction in width here by 2 px may look/match better? e.g. F3154031: a87f589636.png REPOSITORY R98 Breeze for Gtk REVISION DE

D5149: Cache screenshots to avoid downloading them over and over

jgrulich abandoned this revision. jgrulich added a comment. Using more simple and different approach. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5149 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 857 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/857/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 14:41:55 + Build duration: 8 min 20 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 857 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/857/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 14:41:55 + Build duration: 8 min 20 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 673 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/673/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 14:23:59 + Build duration: 16 min CHANGE SET Revision c8181c9fe8ebaf45a5fdbadc3ad6d76059d9

D5153: add a new property in containment, for an edit mode

This revision was automatically updated to reflect the committed changes. Closed by commit R242:244baaf92864: add a new property in containment, for an edit mode (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5153?vs=1273

D5154: use new property plasmoid.editMode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c8181c9fe8eb: use new property plasmoid.editMode (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5154?vs=12734&id=12736 REVISION DETAIL

D5154: use new property plasmoid.editMode

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/editmode REVISION DETAIL https://phabricator.kde.org/D5154 To: mart, #plasma, davidedmundson Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterb

D5153: add a new property in containment, for an edit mode

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editMode REVISION DETAIL https://phabricator.kde.org/D5153 To: mart, #plasma, davidedmundson Cc: plasma-devel, #frameworks, progwolff, lesliezhai,

D5154: use new property plasmoid.editMode

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY toolboxes set editmode by themselves possible for toerh things to trigger edit mode now TEST PLAN handles open correctly REPOSITORY R119 P

D5153: add a new property in containment, for an edit mode

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY used for opening the handles when the toolbox is open or potentially other places TEST PLAN handles open REPOSITORY

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 856 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/856/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 13:17:21 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 672 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/672/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Mar 2017 13:08:41 + Build duration: 6 min 13 sec CHANGE SET Revision e635931e433cb31d1fe23e40c8af62

D4969: open applet handles when the toolbox is open

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e635931e433c: open applet handles when the toolbox is open (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4969?vs=12269&id=12731 REVISIO

cleaning up phabricator

Hi all, I'm seeing a lot of old reviews for plasma in phabricator, a lot of them seems abandoned since several months, i would like to keep it reasonably clean, especially to not risk to lose potentially useful work. Can i ask a thing to everybody that has reviews in phab, look at all their requ

D4969: open applet handles when the toolbox is open

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/toolboxeditmode REVISION DETAIL https://phabricator.kde.org/D4969 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, a

D5148: Use the back function, rather than pop, when pressing Escape

leinir closed this revision. leinir added a comment. Closed by commit efe7d505eb294b11cc6d513ed8448cd5b8eab668 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5148 To: leinir, apol, #discover_software_store Cc: plasma-devel, progwolff, lesliezhai, ali

D5146: Implement UI feedback for long-running searches, and no-results

leinir edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5146 To: leinir, apol, #vdg Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5146: Implement UI feedback for long-running searches, and no-results

leinir added a comment. In https://phabricator.kde.org/D5146#97069, @mart wrote: > just an heads up: ui reviews with VDG as reviewers should have a screenshot attached Ah, thank you yes - there /is/ a video which some of the VDG has already seen on the Discover telegram group, bu

D5147: Mark "all categories missing" kns sources as invalid

leinir closed this revision. leinir added a comment. Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7 INLINE COMMENTS > apol wrote in KNSBackend.cpp:111 > Could be moved into a proper slot? It /is/ starting to be more than trivial code in there, that'd make sense, yeah. i'm sure th

D5146: Implement UI feedback for long-running searches, and no-results

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5146 To: leinir, apol, #vdg Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreute

D5148: Use the back function, rather than pop, when pressing Escape

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5148 To: leinir, apol, #discover_software_store Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D5147: Mark "all categories missing" kns sources as invalid

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5147 To: leinir, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5147: Mark "all categories missing" kns sources as invalid

apol added inline comments. INLINE COMMENTS > KNSBackend.cpp:111 > // Setting setFetching to false when we get an error ensures we don't > end up in an eternally-fetching state > -connect(m_engine, &KNSCore::Engine::signalError, this, [this](const > QString &error) { this->setFetching(

D5146: Implement UI feedback for long-running searches, and no-results

mart added a comment. just an heads up: ui reviews with VDG as reviewers should have a screenshot attached REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5146 To: leinir, apol, #vdg Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreu

D5149: Cache screenshots to avoid downloading them over and over

apol requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5149 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5149: Cache screenshots to avoid downloading them over and over

apol added a comment. Please try using QNetworkDiskCache. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5149 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5144: Change the volume icon/mute button into a ToolButton

drosca added a comment. > The "hack" is consistent with the one of context menu button. It's not, context menu button have spacing > I think the improved discoverability outweighs your objections. We can use this here until someone diggs deeper and improves ToolButton in this regard.

D5144: Change the volume icon/mute button into a ToolButton

subdiff added a comment. > I don't like it, the context menu button is enough hacks for one applet. The "hack" is consistent with the one of context menu button. I think the improved discoverability outweighs your objections. We can use this here until someone diggs deeper and improv

T5412: Improve Plasma PA usability

drosca added a comment. > Breeze's 16px small microphone-sensitivity-[low/medium/high] icons do not follow the color scheme. https://bugs.kde.org/show_bug.cgi?id=377012 TASK DETAIL https://phabricator.kde.org/T5412 To: drosca Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plas

D5127: Switch to newer KDevelop API

This revision was automatically updated to reflect the committed changes. Closed by commit R118:4a24c7d3ca10: Switch to newer KDevelop API (authored by jriddell). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5127?vs=12680&id=12724 REVISION DETAIL https

D5086: Applet: Add Raise maximum volume action to context menu

drosca added a comment. > There's one issue I want to point out that I dealt with, is that other instances of the widget won't be in the "raised" state (eg: other screens). Multiple instances have also separate settings, so I don't see this as an issue. However, it is possible that

D5144: Change the volume icon/mute button into a ToolButton

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. I don't like it, the context menu button is enough hacks for one applet. Also it doesn't have spacing so it looks wrong compared to other ToolButtons (contex menu have spacing, bu

D5149: Cache screenshots to avoid downloading them over and over

jgrulich added a reviewer: apol. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5149 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5149: Cache screenshots to avoid downloading them over and over

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes screenshots to be stored in cache and used next time from cache. Right now the backend downloads them over and over, which somet

D5148: Use the back function, rather than pop, when pressing Escape

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This stops things suddenly just disappearing and leaving us with a grey central area. It also

D5147: Mark "all categories missing" kns sources as invalid

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KNS being, at times, a little twitchy means that we have to handle such things a bit more grac

D5146: Implement UI feedback for long-running searches, and no-results

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If a search takes longer than a couple of seconds, a spinner will face-and-slide in from the b

D5137: Add support for screenedge touchscreen events through XInput 2.2

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in xinputintegration.cpp:132 > I think we want to always update m_lastTouchPositions outside of > if (e->detail == m_trackingTouchId) > > otherwise if we get: > > TouchBegin > TouchUpdate > TouchOwnership > > we star

D5145: Mark "all categories missing" kns sources as invalid

leinir abandoned this revision. leinir added a comment. That, apparently, is not how arc works. Very sorry. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5145 To: leinir Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5145: Mark "all categories missing" kns sources as invalid

leinir created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KNS being, at times, a little twitchy means that we have to handle such things a bit more gracefully. As such, without this code, the KNS ba

Re: Plasma 5.9.4

Well, I started to update this only *after* I read the announcement mail (according to my memory 16:30-ish CET). 1490110785 is 03/21/2017 15:39 (UTC)... so well after that : So probably the mirror used to fetch the files was not yet synced? On 23 March 2017 at 10:28, Rik Mills wrote: > Re-spun

Re: Plasma 5.9.4

Re-spun *before* the announcement email @ 14:53 UTC if I recall from IRC. If you grabbed the tarballs beforehand, then yes you may the have ones prior to the respin? On 23/03/17 07:16, Tobias C. Berner wrote: > Hi > > it seems the tarballs were respun after the announcement. Could you in > the f

Re: Plasma 5.9.4

Hi Well, I definitely had changes here. The file size and checksums of discover kactivitymanagerd kde-cli-tools kdeplasma-addons ksysguard kwayland-integration plasma-desktop plasma-workspace-wallpapers powerdevil user-manager changed: https://src.mouf.net/area51/revision/?rev=13790 and plasma-de

Re: Plasma 5.9.4

There was no respin after the announcement, what makes you think there was? Jonathan On Thu, Mar 23, 2017 at 08:16:42AM +0100, Tobias C. Berner wrote: > Hi > > it seems the tarballs were respun after the announcement. Could you in the > future, please give a little notice of that? > > > mfg

D5144: Change the volume icon/mute button into a ToolButton

subdiff added subscribers: drosca, subdiff. subdiff accepted this revision. subdiff added a comment. This revision is now accepted and ready to land. Looks very nice. I also don't think that the hover line looks weird. It's just a little bit stupid, that for these small buttons we always have

D5144: Change the volume icon/mute button into a ToolButton

subdiff added a reviewer: Plasma. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5144 To: Zren, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Plasma 5.9.4

Hi it seems the tarballs were respun after the announcement. Could you in the future, please give a little notice of that? mfg Tobias On 21 March 2017 at 15:53, Jonathan Riddell wrote: > Out now > https://www.kde.org/announcements/plasma-5.9.4.php >