Kirigami 1.1 / QML problem (Subsurface-mobile)

2017-03-19 Thread Dirk Hohndel
Hi there, After taking a pause for a while, I tried to address a couple of the bug reports for Subsurface-mobile on Android and iOS. Right now we are building with Kirigami 1.1 and Qt 5.7.1. If we have to upgrade to Kirigami 2.0 and/or Qt 5.8 in order to make it easier for people to help us,

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

2017-03-19 Thread Kai Uwe Broulik
broulik added a comment. What's super weird about this one is that `QIcon::fromTheme` internally actually does if (QDir::isAbsolutePath(name)) { return QIcon(name); } yet only with this patch I get an icon for `.svg` icons with an absolute path I configured. Maybe `ico

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

2017-03-19 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Applications can specify an absolute file path for an icon which won't work with QIcon::fromTheme. If a theme icon isn't find, first try to

Re: Re: DrKonqi dependencies

2017-03-19 Thread Andreas Sturmlechner
On Sunday, 19 March 2017 at 14:19, Kai Uwe Broulik wrote: > I'd be fine with splitting drkonqi into its own repository, René recently > brought this up as well. Since I was pondering the idea anyway, might as well attach my patch to build drkonqi standalone from its subdir. commit 1ee858f194fd2c8

Re: KWin contextmenus usability and window/app specific palettes

2017-03-19 Thread René J . V . Bertin
Martin Gräßlin wrote: Hi, > KWin is only involved starting in point 4. 1-3 are in the application. I think I'm beginning to grasp what's going on, thanks. QtCurve has a feature that allows to specify a modification of the menu background shade, which I have to set to 100% lighter. That would ex

D5106: Add support for activating screenedges through touch swipe gestures

2017-03-19 Thread Martin Gräßlin
graesslin updated this revision to Diff 12618. graesslin added a comment. Adressed David's comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5106?vs=12614&id=12618 BRANCH screenedge-touch REVISION DETAIL https://phabricator.kde.org/D5106 AFFECTED FILES autotests/CMakeL

D5106: Add support for activating screenedges through touch swipe gestures

2017-03-19 Thread Martin Gräßlin
graesslin marked 4 inline comments as done. graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in screenedge.cpp:473 > Note that the only subclass of Edge doesn't call the super class for any of > the virtual methods: doGeom/activate/deactivate. > > To fit the current patte

D5106: Add support for activating screenedges through touch swipe gestures

2017-03-19 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in screenedge.cpp:76 > who owns SwipeGesture? good catch, that should be new SwipeGesture(this) REVISION DETAIL https://phabricator.kde.org/D5106 To: graesslin, #kwin, #plasma_on_wayland Cc: davidedmundson, plasma-devel,

Re: KWin contextmenus usability and window/app specific palettes

2017-03-19 Thread Martin Gräßlin
Am 2017-03-19 17:02, schrieb René J. V. Bertin: Martin Gräßlin wrote: Thanks for the info. I need to explain the whole interaction: 1. Applications can use KColorSchemeManager to set a color scheme. 2. This gets installed as a dynamic property in the QGuiApplication This happens in KColorSc

D5106: Add support for activating screenedges through touch swipe gestures

2017-03-19 Thread David Edmundson
davidedmundson added a comment. mostly looks fine. Only one major comment about the return after handling client edges. INLINE COMMENTS > gestures.cpp:61 > +case Direction::Right: > +return std::min(std::abs(delta.width()) / > std::abs(m_minimumDelta.width()), 1.0); > +defau

Re: KWin contextmenus usability and window/app specific palettes

2017-03-19 Thread René J . V . Bertin
Martin Gräßlin wrote: Thanks for the info. > I need to explain the whole interaction: > 1. Applications can use KColorSchemeManager to set a color scheme. > 2. This gets installed as a dynamic property in the QGuiApplication This happens in KColorSchemeManager or at a lower level? > 3. plasma-i

Re: KWin contextmenus usability and window/app specific palettes

2017-03-19 Thread Martin Gräßlin
Am 2017-03-19 13:27, schrieb René J. V. Bertin: subsidiary question: QtCurve connects to certain signals that I think come from KWin: bus.connect("org.kde.kwin", "/KWin", "org.kde.KWin", "compositingToggled", this, SLOT(compositingToggled())); This connect is broken. KW

Re: KWin contextmenus usability and window/app specific palettes

2017-03-19 Thread Martin Gräßlin
Am 2017-03-19 11:08, schrieb René J.V. Bertin: Hi, I've mentioned an issue where the window context menus drawn by QtCurve do not adopt a new colour palette correctly when I change a window's or application's palette from the session default. This happens both when I use a window or app KWin ru

Re: DrKonqi dependencies

2017-03-19 Thread Martin Gräßlin
Am 2017-03-19 14:19, schrieb Kai Uwe Broulik: I'd be fine with splitting drkonqi into its own repository, René recently brought this up as well. Ideally it would be part of KF5, e.g. a kcrash-runtime tier-3 repo. It might need some adjustments to the environment it runs in, though. In Plasma

Re: DrKonqi dependencies

2017-03-19 Thread Kai Uwe Broulik
I'd be fine with splitting drkonqi into its own repository, René recently brought this up as well. It might need some adjustments to the environment it runs in, though. In Plasma we show an SNI and an interactive notification. Other platforms might not support interactive notifications.

Re: DrKonqi dependencies

2017-03-19 Thread Andreas Sturmlechner
On 19.03.2017 11:56, Christoph Feck wrote: > Using openSUSE packages here, installing drkonqi does not drag in the > Plasma workspace, only some KF5 frameworks. So the splitting can also be > done by the distribution. Them fixing it in packaging does not make it right though. Everone building d

D5106: Add support for activating screenedges through touch swipe gestures

2017-03-19 Thread Martin Gräßlin
graesslin added a dependency: D5097: Add support for global touchpad swipe gestures. REVISION DETAIL https://phabricator.kde.org/D5106 To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol

D5106: Add support for activating screenedges through touch swipe gestures

2017-03-19 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Each Edge creates a SwipeGesture for touch activation. The swipe needs to be a single finger starting from the edge into the scr

D5097: Add support for global touchpad swipe gestures

2017-03-19 Thread Martin Gräßlin
graesslin added a dependent revision: D5106: Add support for activating screenedges through touch swipe gestures. REVISION DETAIL https://phabricator.kde.org/D5097 To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, se

Re: KWin contextmenus usability and window/app specific palettes

2017-03-19 Thread René J . V . Bertin
subsidiary question: QtCurve connects to certain signals that I think come from KWin: bus.connect("org.kde.kwin", "/KWin", "org.kde.KWin", "compositingToggled", this, SLOT(compositingToggled())); QString arg0 = qApp? qApp->arguments()[0] : QString(); if (!qApp || (arg

Re: DrKonqi dependencies

2017-03-19 Thread Christoph Feck
On 19.03.2017 11:52, Jasem Mutlaq wrote: Problem is DrKonqi is now part of plasma-workspace. This makes it a *HUGE* dependency just for crash reporting. I obviously cannot ask non-KDE users to install plasma-workspace _just_ to have crash reporting capabilities. Using openSUSE packages here, in

Review Request 130030: taskmanager : Implement window group dragging

2017-03-19 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130030/ --- Review request for Plasma. Repository: plasma-workspace Description ---

D5105: Check for Mycroft Service Status in Background

2017-03-19 Thread Aditya Mehra
This revision was automatically updated to reflect the committed changes. Closed by commit R846:1ceed0475e66: Check for Mycroft Service Status in Background (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5105?vs=12611&id=

D5105: Check for Mycroft Service Status in Background

2017-03-19 Thread Aditya Mehra
Aiix created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.kde.org/T5704 Added new statussocket listner which on connect will notify message socket to activate or on statussocket

DrKonqi dependencies

2017-03-19 Thread Jasem Mutlaq
Hello, I have the following issue. We have KStars, part of KDE Applications, which is used across many desktop environments. I recently wanted to see if DrKonqi could be used to catch crashes and report them back to bugs.kde.org Problem is DrKonqi is now part of plasma-workspace. This makes it a

KWin contextmenus usability and window/app specific palettes

2017-03-19 Thread René J . V . Bertin
Hi, I've mentioned an issue where the window context menus drawn by QtCurve do not adopt a new colour palette correctly when I change a window's or application's palette from the session default. This happens both when I use a window or app KWin rule and when I change the application palette i

D4799: Delay notifications until desktop session has loaded

2017-03-19 Thread Valerio Pilo
vpilo added a comment. I pushed https://phabricator.kde.org/D5012; this rev is now testable. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davi

D5012: Delay notifications until desktop session has loaded

2017-03-19 Thread Valerio Pilo
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bf889f7b94b: Add program to wait for D-Bus Notifications services to register. (authored by vpilo). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5012?vs=12378&id=12609#toc REPOSITORY R120

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-03-19 Thread Martin Koller
> On Jan. 16, 2017, 8:40 a.m., Kåre Särs wrote: > > The current/old version uses "connectSource(source)" to add the CPUs when > > they are added in onSourceAdded, but that is not good if the sources are > > added before SystemLoadViewer.qml (a problem when adding a second > > SytemLoadViewer)