[Powerdevil] [Bug 377566] powerdevil crashes on boot

2017-03-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=377566 Christoph Feck changed: What|Removed |Added Component|general |general Product|kde

[plasma-workspace/sebas/faces-clock] applets/faces-clock/package/contents: [faces clock] bare-bones switching mechanism

2017-03-13 Thread Sebastian Kügler
Git commit 204cf3256b13d67d34b0db122239caf2b7b22108 by Sebastian Kügler. Committed on 13/03/2017 at 23:27. Pushed by sebas into branch 'sebas/faces-clock'. [faces clock] bare-bones switching mechanism During the Plasma sprint, we talked about that we're still not quite happy about code duplicatio

D5034: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > dhaumann wrote in fstabdevice.cpp:40-41 > Did you intentionally switch vendor and product? I wondered that too, that's in the original patch, though, didn't really look into where this will end up, though :D REPOSITORY R245 Solid REVISION DET

D5034: Add support for x-gvfs style options in fstab

2017-03-13 Thread Dominik Haumann
dhaumann added a comment. Just some minor comments, besides that, looks sane. INLINE COMMENTS > fstabdevice.cpp:40-41 > +if (m_device.startsWith(QLatin1String("//"))) { > +m_vendor = m_device.mid(2, m_device.indexOf(QLatin1String("/"), 2) - > 2); > +m_product = m_device.m

D5036: UI fixes for logout dialog

2017-03-13 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > broulik wrote in Logout.qml:54 > Don't let Martin see that you animate a window opacity manually ;-) But yes for a good, flicker free experience it needs to be animated by KWin. We can re add the logout effect to do the fading. REPOSITORY R

D5036: UI fixes for logout dialog

2017-03-13 Thread Kai Uwe Broulik
broulik added a comment. Background is quite dark for me now :/ Also, can we perhaps have pressing the arrow keys cancel the timer? It's quite unintuitive that when I press left the label still says "Logging out in n seconds" although Shutdown is highlighted. INLINE COMMENTS > shutdown

D5036: UI fixes for logout dialog

2017-03-13 Thread Marco Martin
mart added a comment. F2801217: Spectacle.Sm5414.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5036 To: mart, #plasma, sebas Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D5036: UI fixes for logout dialog

2017-03-13 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - use backgroundcontrast effect, improves readability a lot - non-current actions a bit more translucent - background is actually black if the

T5412: Improve Plasma PA usability

2017-03-13 Thread Roman Gilg
subdiff edited the task description. TASK DETAIL https://phabricator.kde.org/T5412 To: subdiff Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mbohlender

Re: Listening to a notification button's "onClick" in the notifications DataEngine

2017-03-13 Thread Martin Klapetek
Hey, On Thu, Mar 9, 2017 at 10:56 PM, Chris Holland wrote: > It seems the ActionInvoked and NotificationClosed signal isn't exposed > anywhere. > > The signals are defined here: > https://github.com/KDE/plasma-workspace/blob/master/ > dataengines/notifications/notificationsengine.h#L84 > > And

D3552: Remove quoting from kscreen-console json-output (Bug 354534)

2017-03-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. I'm sorry that this got lost. The patch is fine, can you please push it? Please add "BUG:354534" to the commit message, on a separate line, this will close the corresponding bugreport. R

D5034: Add support for x-gvfs style options in fstab

2017-03-13 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY These fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI. For d

D5033: [Kickoff / App Dash] Support "locations" runner

2017-03-13 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This enables opening website urls (e.g. http://www.kde.org) through Kickoff and Application Dashboard. Also allows it to find folders (e.g. "P

Minutes Monday Plasma Meeting

2017-03-13 Thread Sebastian Kügler
Voila! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 13-3-2017 Present: notmart, kbroulik, Riddell, sebas notmart: * triaging * mini edit mode for the desktop: open applet handles when toolbox is open, similar to panel https://phabricator.kde.org/D4969 Diff 4969 "open applet

D5007: Fix weird scrolling artifact when the viewport is bigger than the content

2017-03-13 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c8d6027962f5: Fix weird scrolling artifact when the viewport is bigger than the content (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5007?vs=

D5007: Fix weird scrolling artifact when the viewport is bigger than the content

2017-03-13 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D5007 To: apol, #kirigami, mart Cc: plasma-devel, apol

Listening to a notification button's "onClick" in the notifications DataEngine

2017-03-13 Thread Chris Holland
It seems the ActionInvoked and NotificationClosed signal isn't exposed anywhere. The signals are defined here: https://github.com/KDE/plasma-workspace/blob/master/dataengines/notifications/notificationsengine.h#L84 And the signals are called here: https://github.com/KDE/plasma-workspace/blob/mast

D4970: Get rid of QWeakPointer

2017-03-13 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R122:29c3c91c56d0: Get rid of QWeakPointer (authored by denisshienkov, committed by mart). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4970?vs=12331&id=12425 REVI

D4970: Get rid of QWeakPointer

2017-03-13 Thread Marco Martin
mart added a comment. pushed the patch. you are encouraged anyways to apply for a developer account! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson Cc: mart, davidedmundson, plasma-devel, volkov

D4970: Get rid of QWeakPointer

2017-03-13 Thread Marco Martin
mart added a comment. pushed the patch, you are encouraged anyways to get a developer account! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson Cc: mart, davidedmundson, plasma-devel, volkov, progwo

D4970: Get rid of QWeakPointer

2017-03-13 Thread Alexander Volkov
volkov added a comment. https://community.kde.org/Infrastructure/Get_a_Developer_Account "After you obtained your KDE Identity, visit the Developer Application page to apply for a KDE Developer Account." "Normally, any developer who has done some work on projects hosted by KDE can appl

D4915: [Folder View] Fix action button hover and pressed state

2017-03-13 Thread Kai Uwe Broulik
broulik added a comment. This change has nothing to do with that and we already fixed it for the next Frameworks and Plasma release. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4915 To: broulik, #plasma, hein Cc: anthonyfieroni, plasma-devel, progwolff, l