graesslin added inline comments.
INLINE COMMENTS
> toplevel.cpp:325
> const QRect oldVisibleRect = visibleRect();
> +addLayerRepaint(oldVisibleRect);
> if (hasShadow()) {
We do have the repaints already. Check the dirtyRect and the following
addLayerRepaint.
Instead of adding a n
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
I think part of your analysis is wrong. At least I cannot remember that I did
the deferring for that reason. I think the call is deferred to get the correct
areas repainted
graesslin added a dependency: D4806: [greeter] Send the auth result through the
server instead return value.
REVISION DETAIL
https://phabricator.kde.org/D4997
To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
graesslin added a dependent revision: D4997: Support for long running
kcheckpass supporting multiple authentications.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D4806
To: graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
So far kcheckpass allowed to try to verify one password. This required
kscreenlocker_greet to exec for every new entered password. Due to t
xuetianweng updated this revision to Diff 12347.
xuetianweng added a comment.
fix may be applied to 5.9 branch
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4996?vs=12346&id=12347
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D
xuetianweng created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
When activateTask is called from root Item, it will fail to resolve the
reference of toolTipArea. This change make toolTipArea a property of Task
and make activateTask() access it via this pro
hein added a comment.
Hmm it would be really nice if we could get the title to read "Places"
somehow, yeah.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4979
To: broulik, #plasma, dfaure, hein
Cc: elvisangelaccio, plasma-devel, progwolff, lesliezhai, ali
2017-03-09 18:41 GMT+01:00 Jonathan Riddell :
> On Thu, Mar 09, 2017 at 06:30:36PM +0100, Elvis Stansvik wrote:
>> I just wish the FSF FAQ was more clear on this (direct dynamic linking vs
>> dlopen()ing).
>
> They can't be more clear as the definition of derived work is set by
> legislatures and c
On Thu, Mar 09, 2017 at 06:30:36PM +0100, Elvis Stansvik wrote:
> I just wish the FSF FAQ was more clear on this (direct dynamic linking vs
> dlopen()ing).
They can't be more clear as the definition of derived work is set by
legislatures and courts in different justictions and will differ.
Also t
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
connect to Plasma::Corona::availableScreenRectChanged
instead of using kscreen, this way we should be more sure
that signal is emitted when it
Den 9 mars 2017 11:24 fm skrev "Jonathan Riddell" :
>
> On Wed, Mar 08, 2017 at 10:04:56PM +0100, Elvis Stansvik wrote:
> > 1) I want to make an AppImage of a GPL-incompatible Qt application,
> > that bundles a newer Qt than the one provided by the target system.
>
> Go ahead
>
> The main unresolve
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In the current code we update the shadows during the decoration paint.
Because this is called in the middle of the Scene::paintWind
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson
Cc: davidedmundson, plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
denisshienkov updated this revision to Diff 12331.
denisshienkov edited the summary of this revision.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4970?vs=12270&id=12331
REVISION DETAIL
https://phabricator.kde.org/D4970
AFFECTED FILES
kcmodule/activities/activitypage.cpp
kcmodu
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f98a90df2541: [Notifications] Add context menu for
thumbnail (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4838?vs=11939&id=12330#toc
REPOSITORY
R120 Plasma Workspace
mart added a comment.
the discussion seems to me a bit unrelated with the review in itself.
for me the patch is ok, +1
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D4972
To: davidedmundson, #plasma
Cc: mart, hein, broulik, plasma-devel, #frameworks, progwolf
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/91/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Mar 2017 15:18:53 +
Build duration: 15 min
CHANGE SET
Revision a2685f717e89ae562587118c
broulik closed this revision.
broulik added a comment.
https://cgit.kde.org/plasma-workspace.git/commit/?id=a2685f717e89ae562587118ccf89a92801eac6a0
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4763
To: broulik, #plasma, davidedmundson
Cc: plasma-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a2685f717e89: [Notifications] Keep popup opened during
drag (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4976?vs=12287&id=12329
R
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4976
To: broulik, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
when some effects like maximize or translucency are
disabled, less repaints happen and especially when
using aurorae it's possible to
davidedmundson added a comment.
>> From the the documentation of QObject::~QObject: "Warning: Deleting a
QObject while pending events are waiting to be delivered can cause a crash."
>
> It can happens only if an object lives in a different thread. But the
ErrorOverlay - is a widget, whic
denisshienkov added a comment.
It can happens only if an object lives in a different thread. But the
ErrorOverlay - is a widget, which should live in a main thread.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4970
To: denisshienkov, afiestas, ltoscano, volkov
On Wed, Mar 08, 2017 at 10:04:56PM +0100, Elvis Stansvik wrote:
> 1) I want to make an AppImage of a GPL-incompatible Qt application,
> that bundles a newer Qt than the one provided by the target system.
Go ahead
The main unresolved issue with AppImage as I see it is not being able
to provide sou
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/661/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Mar 2017 09:25:50 +
Build duration: 5 min 42 sec
CHANGE SET
Revision 3dd666365245bcca8787df77cf383c
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3dd666365245: [Folder View] Visualize hidden files
(authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4980?vs=12303&id=12319
REVISION DET
Hi everyone,
Just repeating my last email on this subject as it seems some folks
have missed the previous memo.
All issues with Phabricator should be logged at
https://phabricator.kde.org/tag/phabricator/ - not with upstream.
This is being done to avoid duplicate tasks, and to allow us to
commun
2017-03-09 9:02 GMT+01:00 Elvis Stansvik :
> 2017-03-09 9:00 GMT+01:00 Elvis Stansvik :
>> 2017-03-09 7:15 GMT+01:00 Martin Gräßlin :
>>> Am 2017-03-08 22:04, schrieb Elvis Stansvik:
2017-03-08 20:55 GMT+01:00 David Edmundson :
>
> There was a thread:
> https://mail.kde.org/pi
2017-03-09 9:02 GMT+01:00 Elvis Stansvik :
> 2017-03-09 9:00 GMT+01:00 Elvis Stansvik :
>> 2017-03-09 7:15 GMT+01:00 Martin Gräßlin :
>>> Am 2017-03-08 22:04, schrieb Elvis Stansvik:
2017-03-08 20:55 GMT+01:00 David Edmundson :
>
> There was a thread:
> https://mail.kde.org/pi
2017-03-09 9:00 GMT+01:00 Elvis Stansvik :
> 2017-03-09 7:15 GMT+01:00 Martin Gräßlin :
>> Am 2017-03-08 22:04, schrieb Elvis Stansvik:
>>>
>>> 2017-03-08 20:55 GMT+01:00 David Edmundson :
There was a thread:
https://mail.kde.org/pipermail/kde-frameworks-devel/2016-May/034272.html
>>
2017-03-09 7:15 GMT+01:00 Martin Gräßlin :
> Am 2017-03-08 22:04, schrieb Elvis Stansvik:
>>
>> 2017-03-08 20:55 GMT+01:00 David Edmundson :
>>>
>>> There was a thread:
>>> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-May/034272.html
>>>
>>> I'm not sure it helps much.
>>
>>
>> Oh wow.
32 matches
Mail list logo
