Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 90 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Mar 2017 06:55:40 + Build duration: 6 min 0 sec CHANGE SET Revision 11825f6c25cc298f063

Re: LGPL a possibility for Breeze Qt widget style?

Am 2017-03-08 22:04, schrieb Elvis Stansvik: 2017-03-08 20:55 GMT+01:00 David Edmundson : There was a thread: https://mail.kde.org/pipermail/kde-frameworks-devel/2016-May/034272.html I'm not sure it helps much. Oh wow. What a hornets nest that thread was! Almost too technical for me to unders

D4845: Fix context menu button's icon size when on default DPI

This revision was automatically updated to reflect the committed changes. Closed by commit R115:4d4867b89996: Fix context menu button's icon size when on default DPI (authored by Zren). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4845?vs=

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- (Updated March 8, 2017, 6:43 p.m.) Status -- This change has been ma

D4718: support for auto-hidden windows to resize

This revision was automatically updated to reflect the committed changes. Closed by commit R108:c0b207a2b524: support for auto-hidden windows to resize (authored by mart). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4718?vs=12282&id=12307 REVISION DETAIL ht

D4979: Add places:/ KIO slave

broulik added a comment. Another question I had was how could I add a new place when I drag a folder in it? I tried implementing copy() and symlink() but that is only called when stuff happens within my protocol and for mkdir() I only know what folder to create not why it will be created.

Re: LGPL a possibility for Breeze Qt widget style?

2017-03-08 22:04 GMT+01:00 Elvis Stansvik : > 2017-03-08 20:55 GMT+01:00 David Edmundson : >> There was a thread: >> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-May/034272.html >> >> I'm not sure it helps much. > > Oh wow. What a hornets nest that thread was! Almost too technical for >

D4979: Add places:/ KIO slave

hein added a comment. See DesktopNotifier in the desktop:/ slave codebase for an example of a kded module for this purpose. I worked on that stuff (the internal dbus stuff) once to make desktop:/ in KDirModel not remove+insert but just dataChange when a file is renamed, so FV wouldn't l

Re: LGPL a possibility for Breeze Qt widget style?

2017-03-08 20:55 GMT+01:00 David Edmundson : > There was a thread: > https://mail.kde.org/pipermail/kde-frameworks-devel/2016-May/034272.html > > I'm not sure it helps much. Oh wow. What a hornets nest that thread was! Almost too technical for me to understand. But it's clear to me after reading i

D4979: Add places:/ KIO slave

dfaure added a comment. "I didn't find signals to notify changes" --> you mean how to tell apps that something changed in a given protocol? That's what KDirNotify is for, but you can't do the monitoring from a short-lived slave, you need something that stays alive for the whole session, and

D3805: Per-activity favorites (Final?)

hein added a comment. More review talk: ‎[05:34] ‎<‎ivan|home‎>‎ Sho_: I'm unable to reproduce the issue. Can you open the kastats test application while you are testing to see where the issue is? ‎[05:35] ‎<‎Sho_‎>‎ I'll have to do that tomorrow, it's pretty late now ‎[05:35] ‎<‎iva

Re: LGPL a possibility for Breeze Qt widget style?

There was a thread: https://mail.kde.org/pipermail/kde-frameworks-devel/2016-May/034272.html I'm not sure it helps much. David

LGPL a possibility for Breeze Qt widget style?

Hi Plasma folks! This is probably a long shot, but here it goes. At work we're currently building a desktop application for viewing the results coming out of the analysis machine we're developing. The application is to be deployed to select customer workstations, which will all be running Kubuntu

D3805: Per-activity favorites (Final?)

hein added a comment. Note the above steps are kinda best effort, can be hard to keep track of all the details :( REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D3805: Per-activity favorites (Final?)

hein added a comment. Second review pass (now based on updated ivan/new-favourites-per-activity branch rather than this code): ‎[03:04] ‎<‎Sho_‎>‎ ivan|home: compiler warnings on gcc btw @ fav branch ‎[03:19] ‎<‎Sho_‎>‎ ivan|home: I'm still seeing lots of bugs on the branch, e.g. somet

D4972: Start drag with press and hold on touch events

broulik added a comment. Even Qt's own `Drag` attached property crashes when the item it's attached to is deleted as I had to experience, cf https://phabricator.kde.org/D4976 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: h

D4972: Start drag with press and hold on touch events

hein added a comment. So do Task Manager and Folder View. Because DragArea is kind of broken and will crash Plasma if it's deleted during the drag (which happens quite often when you remove something by DND). REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972

D4972: Start drag with press and hold on touch events

davidedmundson added a comment. Kicker uses a normal mouse area for drag starting, then a different plasmoid specific C++ helper for mimedata REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: broulik, plasma-devel, #frameworks

D4980: [Folder View] Visualize hidden files

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4980 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4980: [Folder View] Visualize hidden files

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This renders hidden files with reduced opacity similar to what Dolphin does. Dolphin uses KPixmapEffects but we're hardware-accelerated so ju

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 660 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/660/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Mar 2017 16:57:15 + Build duration: 15 min CHANGE SET Revision 43c91868dc03f03f32d159ac36597acfd8fc

D4897: [Folder View] Cancel renaming if focus is lost or popup closes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:43c91868dc03: [Folder View] Cancel renaming if focus is lost or popup closes (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4897?vs=12

D4972: Start drag with press and hold on touch events

broulik added a comment. Kickoff also uses DragArea iirc, I tend to use Qt's own Drag thing, though, but if we have better/proper touchscreen support in there then, might be worth re-considering. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davided

D4780: [kcheckpass] Drop the conv_legacy support

This revision was automatically updated to reflect the committed changes. Closed by commit R133:a9c44a10b6a6: [kcheckpass] Drop the conv_legacy support (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4780?vs=11801&id=12301 REVISI

D4773: [kcheckpass] Drop the caller command line option

This revision was automatically updated to reflect the committed changes. Closed by commit R133:cbc60df2ed07: [kcheckpass] Drop the caller command line option (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4773?vs=11789&id=12300

D4759: [kcheckpass] Drop command line option for username

This revision was automatically updated to reflect the committed changes. Closed by commit R133:f1125820d9bb: [kcheckpass] Drop command line option for username (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4759?vs=11761&id=1229

D4897: [Folder View] Cancel renaming if focus is lost or popup closes

hein added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4897 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4897: [Folder View] Cancel renaming if focus is lost or popup closes

broulik updated this revision to Diff 12298. broulik added a comment. - Fix accidental removal of clearSelection call REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4897?vs=12069&id=12298 REVISION DETAIL https://phabricator.kde.org/D4897 AFFECTED

D4530: WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D4718 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4530 To: broulik, #plasma, #kwin Cc: graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D4718: support for auto-hidden windows to resize

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH arcpatch-D4718 REVISION DETAIL https://phabricator.kde.org/D4718 To: mart, graesslin, #plasma Cc: luebking, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, harden

D4974: add packagestructure for KWin/Decoration

graesslin added a comment. erm I think something went wrong here. The patch doesn't match at all what was on reviewboard REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4974 To: mart, #plasma Cc: graesslin, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed,

D4979: Add places:/ KIO slave

broulik added a comment. > It would be better to put it in kio or kio-extras, imho. Fine with me. I just used the kios in plasma-workspace as a base, so I put them here to have something to work with first :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde

Re: disabling unlock widgets and some locking questions

Yes, but not from the javascript This should have most the information you want: https://userbase.kde.org/KDE_System_Administration/Kiosk/Introduction Write back if you can't find something after reading it. David

disabling unlock widgets and some locking questions

Hi, I am on the way locking down a desktop configuration, that is from javascript creating a defaultPanel . From js, when creating default panel , is there a way to inhibit the unlock widget menus for applets ? I have not found the way to inhibit mouse actions from js too . Is there a way t

D4979: Add places:/ KIO slave

elvisangelaccio added a comment. Nice! But I don't see anything plasma-specific in this slave. It would be better to put it in kio or kio-extras, imho. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4979 To: broulik, #plasma, hein, dfaure Cc: elvisangel

D4977: Download remote icons during initialization of FlatpakResource items

This revision was automatically updated to reflect the committed changes. Closed by commit R134:285cda6a8c14: Download remote icons during initialization of FlatpakResource items (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4977?vs=12288&id=12294#toc REPOSITORY

D4977: Download remote icons during initialization of FlatpakResource items

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH download-remote-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D4977 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-moham

D4979: Add places:/ KIO slave

broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4979 To: broulik, #plasma, hein, dfaure Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4979: Add places:/ KIO slave

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will expose KFilePlacesModel as KIO slave. With it you can place e.g. a places FolderView in your panel for quick access to your stuff.

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/#review102764 --- Ship it! Ship It! - David Edmundson On March 8, 2017,

D4960: Pause media players on suspend

andreaska added a comment. cause Pause media player when suspending is that long when you separate it to left row right row Media Player pause when suspending so it's not that long and maybe easier to understand. REPOSITORY R122 Powerdevil REVI

D4967: Make difference between download and installed size

jgrulich abandoned this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D4967 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4970: Get rid of QWeakPointer

volkov added a comment. From the the documentation of QObject::~QObject: "Warning: Deleting a QObject while pending events are waiting to be delivered can cause a crash." REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano,

D4977: Download remote icons during initialization of FlatpakResource items

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remote icons are used by .flatpakrepo or .flatpak files so we need to download them to be able to use them later. The icons are downloaded

D4977: Download remote icons during initialization of FlatpakResource items

jgrulich added a reviewer: apol. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D4977 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[neon] [Bug 377374] package grub-theme-breeze absent in repository

https://bugs.kde.org/show_bug.cgi?id=377374 Harald Sitter changed: What|Removed |Added Component|GRUB|Packages User Edition Assignee|plasma

D4976: [Notifications] Keep popup opened during drag

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When dragging a file from a notification and it times out, it closes and crashes. This keeps the dialog open during drag. TEST PLAN Notific

[Breeze] [Bug 377374] New: package grub-theme-breeze absent in repository

https://bugs.kde.org/show_bug.cgi?id=377374 Bug ID: 377374 Summary: package grub-theme-breeze absent in repository Product: Breeze Version: 5.9.3 Platform: Other OS: Linux Status: UNCONFIRMED Severity: nor

D4869: [Notifications Dataengine] Create KConfig object on the stack

This revision was automatically updated to reflect the committed changes. Closed by commit R120:891d8a3bcb23: [Notifications Dataengine] Create KConfig object on the stack (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4869?vs=1

D4974: add packagestructure for KWin/Decoration

mart created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY use a KPackage/PackageStructure for aurorae themes as well Patch by Demitrius Belai REPOSITORY R108 KWin BRANCH phab/auroraepa

D4780: [kcheckpass] Drop the conv_legacy support

apol accepted this revision. This revision is now accepted and ready to land. BRANCH drop-conv-legacy REVISION DETAIL https://phabricator.kde.org/D4780 To: graesslin, #plasma, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4773: [kcheckpass] Drop the caller command line option

apol accepted this revision. This revision is now accepted and ready to land. BRANCH drop-caller REVISION DETAIL https://phabricator.kde.org/D4773 To: graesslin, #plasma, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4759: [kcheckpass] Drop command line option for username

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH no-username-option REVISION DETAIL https://phabricator.kde.org/D4759 To: graesslin, #plasma, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D4967: Make difference between download and installed size

apol added inline comments. INLINE COMMENTS > AbstractResource.cpp:60 > +{ > +return size(); > +} Won't this make the hiding of the Label fail? Will it be false when it's not implemented? Or we'll have the same value trice? REPOSITORY R134 Discover Software Store REVISION DETAIL https

D4718: support for auto-hidden windows to resize

mart updated this revision to Diff 12282. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. add autotest REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4718?vs=11633&id=12282 BRANCH arcpatch-D4718 REVISION DETAIL h

D4967: Make difference between download and installed size

jgrulich added a comment. In https://phabricator.kde.org/D4967#93547, @jgrulich wrote: > - Make downloadSize() and installedSize() to return size() if they are not implemented This fixes compilation for backends which don't have these properties implemented. I had previously enab

D4967: Make difference between download and installed size

jgrulich updated this revision to Diff 12281. jgrulich added a comment. - Make downloadSize() and installedSize() to return size() if they are not implemented REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4967?vs=12266&id=12281 BRANCH m

D4967: Make difference between download and installed size

jgrulich marked an inline comment as done. jgrulich added a comment. Alex, do I have to add support for this to PackageKit backend before this review gets approved? Or anything else? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D4967 To: jgrulich,