D4845: Fix context menu button's icon size when on default DPI

2017-03-05 Thread Chris Holland
Zren updated this revision to Diff 12221. Zren added a comment. Fix merge conflict based on removal of x/y parameters in contextmenu.show() Change height from slider.height to units.iconSizes.small REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.

D4845: Fix context menu button's icon size when on default DPI

2017-03-05 Thread Chris Holland
Zren added a comment. Ah, the `contextMenu.show(x, y)` changed to `contextMenu.show()`. I've got to comment out `roundToIconSize: false` in the mute "button" to test now since that probably requires a new version of frameworks. I changed the `slider.height` to `Layout.preferredHeight:

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 809 - Unstable!

2017-03-05 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/809/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Mar 2017 01:19:10 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name: (root

D4952: Restore the backend set viewport when popping the final render target

2017-03-05 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY The backend is responsible for setting the viewport, the GLRenderTarget should save and restore the viewport actually set by

D4951: Take into account scaling in blitFromFrameBuffer

2017-03-05 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY This method already translates to s_virtualScreenGeometry as the source co-ordinates are in compostior space we should take s

D4950: Scaling support in ColorPicker effect

2017-03-05 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY glReadPixels needs the correct location relative to the framebuffer so we need to factor in the scale as well as translation

D4949: Support scaling in BackgroundContrast effect

2017-03-05 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Background contrast reads pixels from the framebuffer we need to convert from compositor to framebuffer co-ordinates when a

D4948: Store GLRenderTarget::scale

2017-03-05 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY GLRenderTarget already stores the translation from global compositor space to the render target co-ordinates, we also need a

D4370: Set a longer wallpaper transition time

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f255af63d2c9: Set a longer wallpaper transition time (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4370?vs=10769&id=12212 R

D4920: With Qt >= 5.8 use the new API to set scene graph backend

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R296:0373754e61f0: With Qt >= 5.8 use the new API to set scene graph backend (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4920?vs=12

D4919: Don't set acceptHoverEvents in DragArea as we don't use them

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R296:859caaa50cdc: Don't set acceptHoverEvents in DragArea as we don't use them (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4919?vs

D4857: Use initialiser list

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f8bedf84b73c: Use initialiser list (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4857?vs=12001&id=12209 REVISION

D4556: Ref/deref DataEngines even if the metadata is invalid

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:586ed85561ac: Ref/deref DataEngines even if the metadata is invalid (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:23b70f4d4524: Implement FadingMaterial frag/vert shaders on core profile (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4851?vs=11986&id=12207#toc REPOSITORY R2

D4848: Split frag and vert code of FadingNode into separate files

2017-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3b05f569ac29: Split frag and vert code of FadingNode into separate files (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.

D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

2017-03-05 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D4945#92766, @broulik wrote: > The notification is emitted by the notification applet itself and contains the destination URL of a job that finished. Maybe the applet should truncate the text? Or maybe KIO should do that? It's a http P

D4944: QuickShare: Fix text/buttons cutting off in ShowUrlDialog in HiDPI settings

2017-03-05 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4944 To: yuenlim, #plasma, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4931: Small cleanups

2017-03-05 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3a9fc22724c3: Small cleanups (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4931?vs=12152&id=12204 REVISION DETAIL https://

D4839: kio_mtp: add write permissions to root storage folder

2017-03-05 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R320:6a828b172937: kio_mtp: add write permissions to root storage folder (authored by elvisangelaccio). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4839?vs=11940&i

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2017-03-05 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #27 from Elvis Angelaccio --- (In reply to vlaomao from comment #25) > (In reply to Elvis Angelaccio from comment #24) > > @vlaomao: you need kio 5.26 or later > > I have installed kde-frameworks/kio-5.27.0 Should be fixed in the upcoming

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2017-03-05 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #26 from Elvis Angelaccio --- Git commit 6a828b172937a17f56d90a23daf2c7ed77d8ebc7 by Elvis Angelaccio. Committed on 05/03/2017 at 21:26. Pushed by elvisangelaccio into branch 'Applications/16.12'. kio_mtp: add write permissions to root stor

D4839: kio_mtp: add write permissions to root storage folder

2017-03-05 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If you say it works... ;) REPOSITORY R320 KIO Extras BRANCH Applications/16.12 REVISION DETAIL https://phabricator.kde.org/D4839 To: elvisangelaccio, #plasma, dfaure Cc: plasma-deve

D4839: kio_mtp: add write permissions to root storage folder

2017-03-05 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? 16.12.3 tag is due tomorrow, would be nice to get this in. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D4839 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

2017-03-05 Thread Yuen Hoe Lim
yuenlim edited the test plan for this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D4945 To: yuenlim, #plasma, apol Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

2017-03-05 Thread Kai Uwe Broulik
broulik added a comment. The notification is emitted by the notification applet itself and contains the destination URL of a job that finished. Maybe the applet should truncate the text? Or maybe KIO should do that? It's a http POST after all which I don't see why it should have a data url a

D4945: QuickShare: Fix attempt for Plasma freezing when trying to paste large images to imgur

2017-03-05 Thread Yuen Hoe Lim
yuenlim created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Oddly, when pasting raw image data into QuickShare -> imgur, if the image data is sufficiently large KIO::storedHttpPost() seems to trigger a

D4944: QuickShare: Fix text/buttons cutting off in ShowUrlDialog in HiDPI settings

2017-03-05 Thread Yuen Hoe Lim
yuenlim added a comment. before: F2695211: before.png after: F2695238: after.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4944 To: yuenlim, #plasma, apol Cc: plasma-de

D4944: QuickShare: Fix text/buttons cutting off in ShowUrlDialog in HiDPI settings

2017-03-05 Thread Yuen Hoe Lim
yuenlim created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The size of the ShowUrlDialog (the dialog that presents the paste url after a successful pastebin/imgur upload) is currently fixed on 300x300,

Re: [KDE4] what component does the screenlocking?

2017-03-05 Thread Martin Gräßlin
Am 2017-03-05 09:32, schrieb René J. V. Bertin: Kai Uwe Broulik wrote: Turn the screen off. Problem solved. Sure, that's why I use computers, to have to remember myself to do everything by hand... I'd suggest to remove all current hooks into power management too if that's the prevalent mind

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2017-03-05 Thread Rog131
https://bugs.kde.org/show_bug.cgi?id=369676 Rog131 changed: What|Removed |Added CC||samrog...@hotmail.com --- Comment #4 from Rog131 ---

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-05 Thread Kai Uwe Broulik
broulik added reviewers: andreask, alex-l. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg, andreask, alex-l Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4178: The welcome message is better written now

2017-03-05 Thread Ivan Čukić
ivan abandoned this revision. ivan added a comment. Closing this since nobody cares that we are showing a grammatically incorrect sentence. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4178 To: ivan, mart Cc: broulik, plasma-devel, progwolff, lesliezhai,

Re: Plasma Vault is in kdereview

2017-03-05 Thread Ivan Čukić
Hi all, All i18n issues should be fixed now, and other ones as well, so I'll be requesting plasma-vault to be moved to the workspace module. I'll also add it to the kdesrcbuild after it is moved. Cheers, Ivan

D4939: Get rid of KDELibs4Support

2017-03-05 Thread Kai Uwe Broulik
broulik added a comment. While the QPointer changes look sensible, you cannot just remove the Solid Power stuff as you would essentially remove the ability to suspend and hibernate. I know it's in KDELibs4Support and we don't have a replacement but just removing it is not an option. REPOSIT

Re: [KDE4] what component does the screenlocking?

2017-03-05 Thread Kai Uwe Broulik
> to have to remember myself to do everything by hand...  It does that automatically by default...

D4939: Get rid of KDELibs4Support

2017-03-05 Thread Denis Shienkov
denisshienkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Replace QWeakPointer with QPointer. - Remove Solid::PowerManagement code, as it is not ported yet to Solid. REPOSITORY R122 Powerd

Re: [KDE4] what component does the screenlocking?

2017-03-05 Thread René J . V . Bertin
Kai Uwe Broulik wrote: > Turn the screen off. Problem solved. Sure, that's why I use computers, to have to remember myself to do everything by hand... I'd suggest to remove all current hooks into power management too if that's the prevalent mindset - just turn the computer off. Problem solved.