subdiff created this revision.
subdiff added projects: Plasma, VDG.
REVISION SUMMARY
This patch changes no functional stuff, only the arrangement and headings of
the controls.
In the end the KCM:
- wastes less space
- resembles more the applet
- is less cumbersome to use because w
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Unlike the visible property, the opacity does not inherit parent values
and refers to the relative opacity of th
mvourlakos added a comment.
I just noticed...
you dont have to go too far...
any qt application using 5.8 has this problem...
even qtcreator...
showing a menu and then deactivating it from outside areas then the window
needs a click from the user
in order for this window to react
mvourlakos added a comment.
You can observe the faulty behavior even with Qt's "Menu's Example".
1. Open any menu you want either with right click or from the menu
2. Close it by clicking in any outside area you want, that is (not inside the
menu example window and not in the menu)
3.
subdiff added a comment.
In https://phabricator.kde.org/D4724#88718, @drosca wrote:
> > Regarding the size: When you look at the separator lines in the following
screenshot, you can see that the spacing between the top and the first one is
smaller than the one between the first and the s
> On fév. 22, 2017, 12:31 matin, David Edmundson wrote:
> > Ship It!
I cannot commit myself (no account), so if everyone is ok, can someone do it
for me ? I would be grateful
- Pascal
---
This is an automatically generated e-mail. To r
anthonyfieroni added a comment.
I'm not pretty sure, but
https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#374
on click at other window we have enter && mouseGrabber
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D471
drosca added a comment.
> Regarding the size: When you look at the separator lines in the following
screenshot, you can see that the spacing between the top and the first one is
smaller than the one between the first and the second one (ca. 105px vs 120px)
I can see what you mean now, th
subdiff added a comment.
Thanks. Didn't know about the design similarity to pavucontrol. But in this
case it doesn't make much sense to me how pavucontrol is handling this.
Something which is always there and is only for system internals, doesn't need
to be presented at top position. What I
drosca added a reviewer: VDG.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4724
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, drosca, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed
drosca added a comment.
There is a reason it is on top. This KCM is UI-wise just copy of pavucontrol,
and that's the way it is done in pavucontrol. Also this stream is special,
because it is always present. I would myself prefer to leave it on top, but I
will follow the decision made by VDG.
subdiff edited the summary of this revision.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4724
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, drosca
Cc: plasma-devel, progwolff, lesliezhai, al
subdiff created this revision.
subdiff added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The notification stream is not as important to the user than other app
streams. Show it therefore at the end of the list.
Rearranging the separator also
mvourlakos added a comment.
In https://phabricator.kde.org/D4711#88621, @mart wrote:
> do you know exactly what/where changed?
sorry if this is irrelevant...
I dont know if the above code works but in my code tree in latte dock I can
not do anything to ungrabMouse in Qt 5.8 in c
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4394
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, mart
mart added a comment.
do you know exactly what/where changed?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4711
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: anthonyfieroni, #plasma, broulik, mart
Cc: plas
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R99 KDE Gtk Configuration Tool
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4563
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, br
mart marked an inline comment as done.
mart added inline comments.
INLINE COMMENTS
> luebking wrote in client.cpp:2086
> and if the geometry changes while it's (intentionally) not hidden?
i added a disconnect when it's back to electricnone, that should fix it?
> luebking wrote in screenedge.cpp
mart added a comment.
eww, just seen https://phabricator.kde.org/D4530 that does the same thing in
a different way..
so, whatever one you guys prefer, sorry for the noise
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4718
EMAIL PREFERENCES
https://phabricator.kde
mvourlakos added a comment.
In https://phabricator.kde.org/D4518#85123, @anthonyfieroni wrote:
> Qt 5.8 has annoying bug, dismiss context menu by left clicking excatly over
other window (not desktop or taskmanager) grabbing stays in taskmanager. I will
investigate for workaround, if some
mart updated this revision to Diff 11633.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
remove m_edgeGeometryTrackingConnection when we are back to electricnone
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4718?vs=
Hi,
On 22-02-17 16:05, Jani Nikula wrote:
On Mon, 20 Feb 2017, Daniel Thompson wrote:
=== 1) Backlight device interoperability ===
Since we need to keep backward compatibility of the backlight, we have
to keep the current backlight drivers.
Here are possible options:
- Exclusive access: Un
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4556
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #p
drosca added a comment.
> they may end up looking a bit blurry
They are SVGs in Breeze, so they won't look blurry, with other icon themes it
may be an issue. But then again, the same issue is already there when you
request big icon (for which roundToIconSize() returns the passed size ~ >
mart added a comment.
for VDG: any user-interaction opinion on this?
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4676
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca, #plasma, #vdg
Cc: mart, bshah, p
mart added a reviewer: VDG.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D4676
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca, #plasma, #vdg
Cc: bshah, plasma-devel, progwolff, lesliezhai, ali-mohamed, je
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4681
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
Cc: plasma-devel, prog
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4679
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
Cc: plasma-d
mart added a comment.
In https://phabricator.kde.org/D4689#88209, @drosca wrote:
> Yes, I want to use it in plasma-pa applet for volume indicator icons (the
small icon next to slider). Currently, they are too small but next round icon
size is already too big. This change will make it pos
mart updated this revision to Diff 11632.
mart added a comment.
- more guards on null frame
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4707?vs=11627&id=11632
BRANCH
arcpatch-D4707
REVISION DETAIL
https://phabricator.kde.org/D470
On Mon, 20 Feb 2017, Thierry Reding wrote:
>> - The luminance curve of the backlight drivers is not specified, which
>> can lead to a bad user experience: Little changes in the highest levels
>> but drastic changes in the low levels.
>
> I think this is something that the backlight framework shou
Hi All,
On 17-02-17 13:58, Martin Peres wrote:
Hey everyone,
We have been working towards exposing the backlight as a KMS property instead
of relying on the backlight drivers. We have CC:ed the people we have found to
be the more likely to be interested in the discussion but please add everyo
Hi,
I followed instructions at https://plasma-mobile.org/nexus-5 on Nexus 5,
but nothing really works. I can't make calls, wifi is not working
because kdewallet setup fails because I can't verify passowrd, adb shows
the device is offline. Is there another image that is tested to be
working? Or am
On Mon, 20 Feb 2017, Hans de Goede wrote:
> On 17-02-17 13:58, Martin Peres wrote:
> So 1 and 2 are closely related the problem is that if we expose a
> fixed number of steps we need to convert in both directions, and if
> userspace tries to increment by doing read, add 1, write and we expose
> 1-
On Mon, 20 Feb 2017, Daniel Thompson wrote:
>>> === 1) Backlight device interoperability ===
>>>
>>> Since we need to keep backward compatibility of the backlight, we have
>>> to keep the current backlight drivers.
>>>
>>> Here are possible options:
>>>
>>> - Exclusive access: Unregister a backli
mart updated this revision to Diff 11630.
mart marked 2 inline comments as done.
mart added a comment.
updated with https://phabricator.kde.org/D4522
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4508?vs=11082&id=11630
BRANCH
mart/qqc
mart retitled this revision from "[WIP] Plasma controls based on
QtQuickControls2" to "Plasma controls based on QtQuickControls2".
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4508
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emai
mart edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai,
mart updated this revision to Diff 11627.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
remove useless variable
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
luebking added inline comments.
INLINE COMMENTS
> client.cpp:2086
> +m_edgeGeometryTrackingConnection = connect(this,
> &Client::geometryChanged, this, [this, border](){
> +hideClient(true);
> +ScreenEdges::self()->reserve(this, border);
and if the ge
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
auto hidden windows were shown again when their geometry
changed, this was done for being as easy as possible as
the unhide zone chan
On 22/02/17 17:05, Jani Nikula wrote:
On Mon, 20 Feb 2017, Daniel Thompson wrote:
=== 1) Backlight device interoperability ===
Since we need to keep backward compatibility of the backlight, we have
to keep the current backlight drivers.
Here are possible options:
- Exclusive access: Unregi
On 20/02/17 21:57, Hans de Goede wrote:
Hi,
On 20-02-17 20:27, Dave Airlie wrote:
On 17 February 2017 at 22:58, Martin Peres
wrote:
Hey everyone,
We have been working towards exposing the backlight as a KMS property
instead of relying on the backlight drivers. We have CC:ed the
people we
h
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e301b636858b: Fix binding loop regression in FrameSVGItem
(authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4713?vs=11
broulik accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4713
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, #frameworks, mart, broulik
Cc: mart, br
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4713
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #p
davidedmundson updated this revision to Diff 11621.
davidedmundson added a comment.
Updated
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4713?vs=11609&id=11621
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4713
AFFEC
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.
i can reproduce kai's problems, luckily the fix seems easy
INLINE COMMENTS
> framesvg.cpp:757
> fd->theme = q->theme()->d;
> -updateAndSignalSizes();
> +if (updateType ==
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2c70ac2a6edd: Don't assume initialized if there are
pending dbus replies (authored by elvisangelaccio).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricat
elvisangelaccio added inline comments.
INLINE COMMENTS
> arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370
> I want the version of Qt not KCoreAddons so that won't work.
> Do we really need a runtime Qt version check? We link to Qt5PlatformSupport,
> is that API stable or do we need t
https://bugs.kde.org/show_bug.cgi?id=376755
--- Comment #12 from Kathie Dart ---
Thanks for confirming et al
--
You are receiving this mail because:
You are the assignee for the bug.
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
applet-no-streams-msg (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D4677
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/
https://bugs.kde.org/show_bug.cgi?id=366402
Kai Uwe Broulik changed:
What|Removed |Added
CC||k...@kathiedart.uk
--- Comment #8 from Kai Uw
https://bugs.kde.org/show_bug.cgi?id=376755
Kai Uwe Broulik changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=376755
--- Comment #10 from Kathie Dart ---
Sounds like something reasonable.
I've got version 231 of systemd (not sure how to check for logind - same
package I presume?
--
You are receiving this mail because:
You are the assignee for the bug.
broulik added a comment.
While this fixes the binding loop warnings, it doesn't fix the broken margins
in places like NM list delegates. +1 nonetheless.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4713
EMAIL PREFERENCES
https://phabricator.k
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:b69465e5b115: [Greeter] Also clear selection clipboard
(authored by broulik).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4701?vs=11578&id=11616
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:faf76152ef02: [KSplashQML] Drop "Loading stage" debug
output (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4709?vs=11594&id=11615
arichardson added a comment.
Ping?
I work a lot with remote projects over sftp:// so this would be very
important for me.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D4193
EMAIL PREFERENCES
https://phabricator.kde.org/sett
broulik added a comment.
> Would it be possible to display the information together with the
information of the current first tab?
No.
Also, currently I cannot tell the thing to exclude certain information (like
file type and other info already shown on the first page).
REPOSITORY
ltoscano added a comment.
In https://phabricator.kde.org/D4614#88485, @fabianr wrote:
>
> A case could be made that this information is actually the most interesting
one, and could have a more prominent place, then on the last tab. Would it be
possible to display the inform
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4709
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
Cc: plasma-devel, prog
hein added a comment.
The comparisons (thanks for going to the length to make them) look OK, at
least for "let's go with this and check for feedback". Let's go ahead!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4550
EMAIL PREFERENCES
https://phabricator
fabianr added a comment.
The layout looks good and is according to the HIG.
You probably shouldn't display duplicate information, but if I understood the
comments correct this is already addressed.
A case could be made that this information is actually the most interesting
one, and cou
Security issues in KDM, seriously? Maybe if it's configured to serve incoming
remote connections, but for local security I don't think it can be a big
concern
given how easily one can get at a virtual console anyway.
Unless KDM is also responsible for locking a session once you're logged in?
T
65 matches
Mail list logo
