https://bugs.kde.org/show_bug.cgi?id=376755
Kai Uwe Broulik changed:
What|Removed |Added
CC||k...@privat.broulik.de
--- Comment #9 from Ka
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
Ok, I see that this can probably happen when switching connections before
secrets are actually received. Thanks for the patch!!.
REPOSITORY
R116 Plasma Network Management Applet
BRAN
https://bugs.kde.org/show_bug.cgi?id=376755
Martin Gräßlin changed:
What|Removed |Added
Product|kscreenlocker |Powerdevil
Assignee|plasma-b...@kde.
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
https://phabricator.kde.org/R242:d8a1a9eb084b19e552c789244267f7346e1b27a8
introduces an unintended code
change, resizeFram
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102571
---
Ship it!
Ship It!
- David Edmundson
On Feb. 7, 2017, 9
markg added a comment.
In https://phabricator.kde.org/D4491#88362, @anthonyfieroni wrote:
> I must investigate why elide does not work, margins are a bit different
from others like systray, kicker, etc.
> I figure out it, maximumLineCount or height sould be setted, i unsetted
height..
Am 2017-02-21 12:48, schrieb Harald Sitter:
# startplasmacompositor
- Resolves qdbus via qtpaths which is not relocatable, that's not
really our fault and probably not too easy to solve or even worth it.
Finding qdbus reliably has been a long standing problem unfortunately.
- Hard-compiles the
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D4701
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, graesslin
Cc: plasma-deve
anthonyfieroni created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Same as plasma-framework, on audio volume is weird as hell. Right click ->
settings -> click in config window :)
REPOSITORY
R120 Pla
anthonyfieroni created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Qt 5.8 has a bit changed and ungrabbing at show does not work.
REPOSITORY
R242 Plasma Framework (Library)
REVI
anthonyfieroni added a comment.
I must invetigate why elide does not work, margins are a bit different from
others like systray, kicker, etc.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4491
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/e
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102567
---
Sebas can this be commited now or you have more concerns?
-
subdiff added a comment.
> This needs to go in, I forgot about it: https://phabricator.kde.org/D2314
Looks good! As Thomas said in the review though, I'm also in favor of
offering at least the "Default" setting directly in the applet or add a button
next to every stream to show this cont
ppalaga updated this revision to Diff 11596.
ppalaga added a comment.
In https://phabricator.kde.org/D4550#88247, @hein wrote:
> I'm starting to like it, but it's a little bit scary. The thing is that we
don't want to alter behavior in existing user setups, which is mostly narrow
vertica
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:408b31166227: [FrameSvgItemMargins] Don't update on
repaintNeeded (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4688?vs=1
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It is using QDateTime and secsTo which needs to take into potential timezone
changes and what not.
I don't think it's worth porting it to QE
broulik abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4362
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, progwolff,
broulik added a comment.
Ping
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4290
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma_workspaces, mart
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-moha
broulik closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1771
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, graesslin, #plasma
Cc: andreaska, colomar, graesslin, plasma-devel, p
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kcm.cpp:320
> We're doing the exact same logic here. Duplicating it without deleting this
> is definitely wrong.
>
> It looks like this should work as we've loaded the model and the model is
> populated at startup.
> However
mart updated this revision to Diff 11590.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
remove duplicate code
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4703?vs=11584&id=11590
BRANCH
phab/selectIndex
REVISION
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/632/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 21 Feb 2017 14:57:18 +
Build duration: 5 min 42 sec
CHANGE SET
Revision f10a6f4eba65e091a08aa47e6b87bb
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f17a395a40e9: Overhaul app associativity heuristic to
give precendence to StartupWMClass. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4706
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, dav
On Tuesday 21 February 2017, René J.V. Bertin wrote:
> Hello,
>
> I get the impression I'm not the only one who hates the looks of SDDM (to
> put it bluntly). How difficult/impossible would it be to port KDM,
> presuming that hasn't been done already? Evidently I wouldn't expect
> Wayland support.
elvisangelaccio added a comment.
In https://phabricator.kde.org/D4705#88274, @jgrulich wrote:
> If secrets are requested then it should immediately return from
initialize() and given that the kcm is not marked as initialized until we get
reply. To me it appears that what you did shouldn'
broulik added a comment.
Big +1, works beautifully:
- Chrome windows behave like normal
- Chrome app in Default user is treated like separate app
- Chrome app in secondary Profile ("Profile_1" suffix) is treated like a
separate app, too
- LibreOffice Launcher is mapped fine
- Libr
jgrulich added a comment.
If secrets are requested then it should immediately return from initialize()
and given that the kcm is not marked as initialized until we get reply. To me
it appears that what you did shouldn't be necessary.
REPOSITORY
R116 Plasma Network Management Applet
REVISI
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
WM_CLASS instance and general classes are checked against StartupWMClass
prior to most rewrite and mapping rules, and prior to the DesktopEntryName
and Name checks.
This matches the fd.o spec mo
elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
ConnectionEditorBase::initialize() does not count the number of pending dbus
replies, so it is currently assuming that if control rea
https://github.com/Match-Yang/sddm-deepin
https://github.com/absturztaube/sddm-archlinux-theme
https://github.com/sniper1720/elegant-sddm-manjarolinux-theme
https://github.com/AlfredoRamos/sddm-urbanlifestyle-theme
2017-02-21 15:04 GMT+03:00 René J.V. Bertin :
> Hello,
>
> I get the impression I'
hein added a comment.
I'm starting to like it, but it's a little bit scary. The thing is that we
don't want to alter behavior in existing user setups, which is mostly narrow
vertical panels that don't get text. I fear that with default settings, due to
lowering the threshold to 5 from 3, the
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/631/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 21 Feb 2017 12:27:32 +
Build duration: 7 min 27 sec
CHANGE SET
Revision 30388c7361889372cfdc9db77aeacc
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
The QML hack is fine, but it seems like you've written the C++ part without
reading any of the existing code.
INLINE COMMENTS
> kcm.cpp:320
> if (auto listVi
On Tue, Feb 21, 2017 at 12:48 PM, Harald Sitter wrote:
> # ksmserver
>
> Starting here things seem to largely not be hardcoded anymore. Rejoice!
Spoke too soon, kactivitymanagerd forks itself to detach... using its
own installation path as hard compiled path as if it didn't know
where it liv
If you hate the look, change the look locally. It supports themes.
Changing the backend because of the look would be ridiculous.
David
Hello,
I get the impression I'm not the only one who hates the looks of SDDM (to put
it bluntly).
How difficult/impossible would it be to port KDM, presuming that hasn't been
done already?
Evidently I wouldn't expect Wayland support.
R.
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
using the same trick as elsewhere, set the currentIndex
and move the view to currentIndex right at startup
the only way to be sure is
Hola!
For a while now I've been chipping away at making Plasma relocatable
with the purpose of putting Plasma in a snap package (same applies to
appimage FWIW, flatpak uses a static path), which happens to mount the
bundle content under `/snap/$name/$REV/` meaning there is a severe
need to be to h
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:148ff6311bfe: IconItemTest: Fix loadPixmap and loadImage
tests (authored by drosca).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4702?vs=11582
drosca created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It only works on CI because data/test_image.png size
is the same as implicitSize of IconItem (KIconLoader::Dialog).
TES
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4702
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca,
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:ba844b3e0e36: StreamRestore: Cache values in writeChanges
until receiving change from pa (authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabrica
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:aeac3023a719: Applet: Add configure button next to tabbar
(authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4675?vs=11519&id=1
drosca added a comment.
Yes, I want to use it in plasma-pa applet for volume indicator icons (the
small icon next to slider). Currently, they are too small but next round icon
size is already too big. This change will make it possible to make them just
few pixels bigger.
REPOSITORY
R242 P
drosca added a comment.
That would work too, but then we won't know which properties were actually
changed in `StreamRestore::update` and would need to emit changed signals for
all properties.
It would make the code more clean, but we would lost this optimization (even
though is probabl
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Ok, I understand the problem. Solution works.
Reading this I have an alternative proposal that might make the code simpler:
Instead of building pa_ext_stream_restore
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We only cleared the Ctrl+V clipboard but not middle click paste.
TEST PLAN
I can no longer middle click paste stuff I selected earlier.
REP
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/630/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 21 Feb 2017 09:45:28 +
Build duration: 15 min
CHANGE SET
Revision 8736650c88ee864fd83a3dc544834dc7d0a4
49 matches
Mail list logo
