[Differential] [Request, 53 lines] D4360: Revamp (Activity) Pager wheel handling

2017-01-30 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Fixes the mouse wheel not working to switch activities by refactoring the code so currentPage() always behaves the same and accou

[Differential] [Request, 334 lines] D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

2017-01-30 Thread Roman Gilg
subdiff created this revision. subdiff added a reviewer: Plasma. subdiff set the repository for this revision to R31 Breeze. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I use 1.5 scaling factor on my PC and the cursor sizes 24 (facto

[Differential] [Commented On] D4351: [QuickViewSharedEngine] Use setSize instead of setWidth/setHeight

2017-01-30 Thread Eike Hein
hein added a comment. You have no idea how much I love you right now! This has annoyed me so long. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4351 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart C

[Differential] [Commented On] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread Eike Hein
hein added a comment. For posterity: While the code looked OK to me, as talked about on IRC, the patch doesn't work for me. It actually makes things worse for now. Without the patch I get the "one bad frame during dialog resize" glitch while roving through the root level menu intermittently,

[Powerdevil] [Bug 362831] Do not increase brightness when entering low battery mode

2017-01-30 Thread Piotr Kloc
https://bugs.kde.org/show_bug.cgi?id=362831 Piotr Kloc changed: What|Removed |Added CC||pepk...@gmail.com --- Comment #1 from Piotr Kloc

Re: Review Request 128429: Fix strings in tooltips

2017-01-30 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128429/#review102326 --- Ship it! Ship It! - Albert Astals Cid On Jan. 29, 2017

[Differential] [Commented On] D4322: Adjust KeyboardLayout to non-kded DBus service

2017-01-30 Thread Martin Gräßlin
graesslin added a comment. According to lxr.kde.org this was the only usage of /modules/keyboard and searching for org.kde.KeyboardLayouts shows no usage combined with org.kde.kded5. So I am quite certain that this here was the only "incorrect" usage. REPOSITORY R120 Plasma Workspace REV

[Differential] [Request, 6 lines] D4353: [Applet Configuration] Add mnemonics for dialog buttons

2017-01-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Unfortunately due to the way Breeze styl

[Differential] [Closed] D4323: Implement the DBus org.kde.KeyboardLayouts interface of keyboard kded

2017-01-30 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:551d4a8a5d79: Implement the DBus org.kde.KeyboardLayouts interface of keyboard kded (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4323?vs=106

[Differential] [Closed] D4315: Provide kxbk config through kwinApp

2017-01-30 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:8d9c4acf4dee: Provide kxbk config through kwinApp (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4315?vs=10631&id=10729 REVISION DETAIL htt

[Differential] [Closed] D4333: Call performMoveResize when we got a new geoemtry during resize

2017-01-30 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:5083adb1b85a: Call performMoveResize when we got a new geoemtry during resize (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4333?vs=10673&id=

[Differential] [Changed Subscribers] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > submenu.cpp:33 > { > - KWindowSystem::setType(winId(), NET::Menu); > +setType(Dialog::Dock); > } why is it changed to Dock? A Dock is not a menu and this could have side-effects in how KWin manages the window. REPOSITORY R119 Plasma

[Differential] [Closed] D4291: [KRunner] In doubt use primary screen for view position

2017-01-30 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. Committed as https://cgit.kde.org/plasma-workspace.git/commit/?id=b0b31dee60defe4d7e9de8abc1dbbadfbced2783 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4291 EMAIL PREFERENCES https://phabricator.kd

[Differential] [Closed] D4351: [QuickViewSharedEngine] Use setSize instead of setWidth/setHeight

2017-01-30 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. Committed as https://cgit.kde.org/kdeclarative.git/commit/?id=2220a46702e670b5758892902797241d9b300bcf REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4351 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Closed] D4352: [ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet

2017-01-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:031bd773b7c2: [ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://p

[Differential] [Accepted] D4352: [ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4352 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brouli

[Differential] [Accepted] D4351: [QuickViewSharedEngine] Use setSize instead of setWidth/setHeight

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4351 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, ma

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 711 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/711/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 14:29:43 + Build duration: 24 min CHANGE SET Revision 7600d5f72e99c31515546186243b508113

[Differential] [Request, 9 lines] D4351: [QuickViewSharedEngine] Use setSize instead of setWidth/setHeight

2017-01-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R296 KDeclarative. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This avoids needless

[Differential] [Request, 3 lines] D4352: [ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet

2017-01-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This a

[Differential] [Updated] D4351: [QuickViewSharedEngine] Use setSize instead of setWidth/setHeight

2017-01-30 Thread Kai Uwe Broulik
broulik updated the summary for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4351 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreu

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 710 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/710/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 14:12:34 + Build duration: 5 min 36 sec CHANGE SET Revision 3792ef9e51dc0ba21740e69964f2

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 36 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 14:11:34 + Build duration: 5 min 36 sec CHANGE SET Revision b0b31dee60defe4d7e

[Differential] [Changed Subscribers] D4348: [Containment Interface] No need for values() as contains() looks up keys

2017-01-30 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > containmentinterface.cpp:565 > QPoint posi; // will be overwritten with the event's position > -if (m_dropPoints.keys().contains(tjob)) { > -posi = m_dropPoints[tjob]; > +if (m_dropPoints.contains(tjob)) { > +

[Differential] [Closed] D4349: [Shell Corona] Avoid iterating keys() and then doing a value() lookup

2017-01-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7600d5f72e99: [Shell Corona] Avoid iterating keys() and then doing a value() lookup (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4

[Differential] [Closed] D4350: [FrameData] Avoid iterating keys()

2017-01-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:d38be811e82b: [FrameData] Avoid iterating keys() (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4350?vs=10719&id=10721 RE

[Differential] [Closed] D4348: [Containment Interface] No need for values() as contains() looks up keys

2017-01-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:fe3990556046: [Containment Interface] No need for values() as contains() looks up keys (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Accepted] D4350: [FrameData] Avoid iterating keys()

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. it would also be interesting to see why the destructor is being called so many times at startup (some model somewhere emitting resets that shouldn't?).. as at start

[Differential] [Request, 4 lines] D4350: [FrameData] Avoid iterating keys()

2017-01-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Instea

[Differential] [Accepted] D4349: [Shell Corona] Avoid iterating keys() and then doing a value() lookup

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4349 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Updated] D4349: [Shell Corona] Avoid iterating keys() and then doing a value() lookup

2017-01-30 Thread Kai Uwe Broulik
broulik updated the summary for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4349 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 6 lines] D4349: [Shell Corona] Avoid iterating keys() and then doing a value() lookup

2017-01-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use iterators and their key() and valu

[Differential] [Accepted] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread Eike Hein
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4347 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Accepted] D4348: [Containment Interface] No need for values() as contains() looks up keys

2017-01-30 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4348 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Request, 4 lines] D4348: [Containment Interface] No need for values() as contains() looks up keys

2017-01-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Avoids

[Differential] [Commented On] D4333: Call performMoveResize when we got a new geoemtry during resize

2017-01-30 Thread Eike Hein
hein added a comment. Sorry, my browser was completing to Kernel bugzilla :( REPOSITORY R108 KWin BRANCH 5.9-call-performMoveResize REVISION DETAIL https://phabricator.kde.org/D4333 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Request, 37 lines] D4347: Avoid jumpy UI in Kicker Dialogs

2017-01-30 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Under X11 we would see move events as two distinct jumpy frames. The Dialog would move, and t

[Differential] [Accepted] D4333: Call performMoveResize when we got a new geoemtry during resize

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH 5.9-call-performMoveResize REVISION DETAIL https://phabricator.kde.org/D4333 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Updated, 36 lines] D4301: [System Tray] SNI fallback to context menu on failing Activate

2017-01-30 Thread Roman Gilg
subdiff updated this revision to Diff 10713. subdiff added a comment. Use QDBusPendingCallWatcher. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4301?vs=10649&id=10713 REVISION DETAIL https://phabricator.kde.org/D4301 AFFECTED FILES applets/

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 35 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 12:15:05 + Build duration: 5 min 49 sec CHANGE SET Revision 3792ef9e51dc0ba217

[Differential] [Closed] D4346: Drop legacy fixup rule for VirtualBox.

2017-01-30 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f99f0dd99ef: Drop legacy fixup rule for VirtualBox. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4346?vs=10709&id=10711 REVISION DE

Minutes Monday Plasma Meeting

2017-01-30 Thread Eike Hein
Enjoy! Cheers, Eike Plasma Meeting minutes 30-01-2017 Present: kbroulik, romangg, Riddell, notmart, d_ed, bshah, Sho_ kbroulik: * A few fixes to task manager (e.g. more predictible keyboard nav in group dialog) uts on monday monday by the boomtown rats * Icon applet uses KIO::statJob internally

[Differential] [Accepted] D4346: Drop legacy fixup rule for VirtualBox.

2017-01-30 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4346 EMAIL PREFERENCES https://phabricator.kde.org/set

[Differential] [Updated, 1 line] D4346: Drop legacy fixup rule for VirtualBox.

2017-01-30 Thread Eike Hein
hein updated this revision to Diff 10709. hein added a comment. Fix messed-up patch. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4346?vs=10707&id=10709 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4346 AFFECTED FILES l

[Differential] [Request, 21 lines] D4346: Drop legacy fixup rule for VirtualBox.

2017-01-30 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, broulik. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Versions of VirtualBox packaged on Neon and Fedora now have a proper WM_CLASS: Fedora: WM_CLASS(STRING) = "VirtualBox", "

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 709 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/709/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 11:22:17 + Build duration: 5 min 40 sec CHANGE SET Revision b5d729567a0673698bbc45f0b1a3

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

2017-01-30 Thread Eike Hein
hein added a comment. Sorry - I started looking at this but then got busy. I'll try to do it this week, but I'm on vacation Feb 2nd & 3rd. If I can't do it this week I'll do it next week :). REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 581 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/581/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 10:07:58 + Build duration: 27 min CHANGE SET Revision e018318f670a7526c0f28d4eaaf2a7fa10a4

[Differential] [Updated, 409 lines] D4343: Greatly improve Folder View performance and mem usage.

2017-01-30 Thread Eike Hein
hein updated this revision to Diff 10705. hein marked 6 inline comments as done. hein added a comment. Address Kai's comments. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4343?vs=10699&id=10705 BRANCH hein/fastFoldersNew REVISION DETAIL http

[Differential] [Updated] D4343: Greatly improve Folder View performance and mem usage.

2017-01-30 Thread Eike Hein
hein marked 7 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in FolderItemDelegate.qml:55 > `===` Will do. > broulik wrote in FolderItemDelegate.qml:61 > I ran into quite some trouble (layouts, crashes, glitches) with async loaders > in an item view, you s

[Differential] [Commented On] D4322: Adjust KeyboardLayout to non-kded DBus service

2017-01-30 Thread Martin Gräßlin
graesslin added a comment. I don't know, though they still work with the old name. Just not on Wayland. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4322 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #pla

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 39 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 10:05:26 + Build duration: 26 min CHANGE SET Revision 84fadc3603f754a326c589fbc8

[Differential] [Updated, 22 lines] D4344: Delay setting the model on the view until listing is finished.

2017-01-30 Thread Eike Hein
hein updated this revision to Diff 10704. hein marked 2 inline comments as done. hein added a comment. Remove stray signal definition. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4344?vs=10700&id=10704 BRANCH hein/fastFoldersNew REVISION DETAI

[Differential] [Closed] D4342: Use texture atlas for static icon item

2017-01-30 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:8d60a8f1f5b9: Use texture atlas for static icon item (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4342?vs=10695&i

[Differential] [Changed Subscribers] D4344: Delay setting the model on the view until listing is finished.

2017-01-30 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > AppletAppearance.qml:189 > if (applet.busy) { > +console.log("busy"); > busyLoader.source = "BusyOverlay.qml" Remove > foldermodel.cpp:121 > +connect(dirLister, &KCoreDirLi

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

2017-01-30 Thread Ivan Čukić
ivan added a comment. Any responses to this? I'd like to continue with the patch - but I need the general 'ok' not to waste more time if this was not the acceptable approach. REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Commented On] D4343: Greatly improve Folder View performance and mem usage.

2017-01-30 Thread Kai Uwe Broulik
broulik added a comment. Neat! I do get a bunch of warnings on startup, though: file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:244:17: QML Text: Binding loop detected for property "width" Spring-loading when dragging a fi

[Differential] [Updated, 89 lines] D4345: Remove the TextFix workaround for QML text mouse handling bug.

2017-01-30 Thread Eike Hein
hein updated this revision to Diff 10701. hein added a comment. Rebase onto master. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4345?vs=10698&id=10701 BRANCH hein/fastFoldersNew REVISION DETAIL https://phabricator.kde.org/D4345 AFFECTED FIL

[Differential] [Updated, 23 lines] D4344: Delay setting the model on the view until listing is finished.

2017-01-30 Thread Eike Hein
hein updated this revision to Diff 10700. hein added a comment. Rebase onto master, remove stray debug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4344?vs=10697&id=10700 BRANCH hein/fastFoldersNew REVISION DETAIL https://phabricator.kde.org

[Differential] [Updated, 409 lines] D4343: Greatly improve Folder View performance and mem usage.

2017-01-30 Thread Eike Hein
hein updated this revision to Diff 10699. hein added a comment. Rebase onto master. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4343?vs=10696&id=10699 BRANCH hein/fastFoldersNew REVISION DETAIL https://phabricator.kde.org/D4343 AFFECTED FIL

[Differential] [Accepted] D4323: Implement the DBus org.kde.KeyboardLayouts interface of keyboard kded

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH keyboard-layout-dbus-interface REVISION DETAIL https://phabricator.kde.org/D4323 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 38 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 09:38:33 + Build duration: 25 min CHANGE SET Revision 3568d8e4a8a2cc4fac7fccb861

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 708 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/708/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 09:37:58 + Build duration: 26 min CHANGE SET Revision 0ef5ce08003c1a29fd8b01155daaf84acf

[Differential] [Accepted] D4345: Remove the TextFix workaround for QML text mouse handling bug.

2017-01-30 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH hein/fastFolders REVISION DETAIL https://phabricator.kde.org/D4345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Commented On] D4322: Adjust KeyboardLayout to non-kded DBus service

2017-01-30 Thread Marco Martin
mart added a comment. is there anything out there still depending from the old name? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4322 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc:

[Differential] [Accepted] D4342: Use texture atlas for static icon item

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. thatnks, makes sense (and let's see if makes a difference with the phone, may be telling) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION D

[Differential] [Request, 89 lines] D4345: Remove the TextFix workaround for QML text mouse handling bug.

2017-01-30 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Cf.: https://codereview.qt-project.org/#/c/113758/ This was merged into Qt v5.6.2 and this branch thus doesn't support Qt v5.6

[Differential] [Request, 24 lines] D4344: Delay setting the model on the view until listing is finished.

2017-01-30 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. hein added a dependency: D4343: Greatly improve Folder View performance and mem usage.. Restricted Application added a project: Plasma. REVISION SUMMARY This massively cuts down on churn when insta

[Differential] [Updated] D4343: Greatly improve Folder View performance and mem usage.

2017-01-30 Thread Eike Hein
hein added a dependent revision: D4344: Delay setting the model on the view until listing is finished.. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4343 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: pl

[Differential] [Accepted] D4315: Provide kxbk config through kwinApp

2017-01-30 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. love it REPOSITORY R108 KWin BRANCH kxkb-config REVISION DETAIL https://phabricator.kde.org/D4315 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

[Differential] [Request, 409 lines] D4343: Greatly improve Folder View performance and mem usage.

2017-01-30 Thread Eike Hein
hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Profiling suggests that Folder View spends most of its time in delegate creation, which occurs en masse during various operations

[Differential] [Request, 2 lines] D4342: Use texture atlas for static icon item

2017-01-30 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Icon's are generally small, they may as well go in the existing shared

[Differential] [Closed] D4337: QStandardPaths::enableTestMode -> setTestModeEnabled

2017-01-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0ef5ce08003c: QStandardPaths::enableTestMode -> setTestModeEnabled (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4337?vs=10685&id=1

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 37 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 09:23:28 + Build duration: 14 min CHANGE SET Revision 37a5d9fb5d0b87b50756555348

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 36 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 09:07:41 + Build duration: 14 min CHANGE SET Revision f37514e2b551525464cddf08f8

[Differential] [Accepted] D4341: Fix Plasmoid.busy visualization in desktop containment.

2017-01-30 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. much cleaner too ++ REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4341 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Closed] D4341: Fix Plasmoid.busy visualization in desktop containment.

2017-01-30 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:37a5d9fb5d0b: Fix Plasmoid.busy visualization in desktop containment. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4341?vs=10691&id=106

[Differential] [Request, 17 lines] D4341: Fix Plasmoid.busy visualization in desktop containment.

2017-01-30 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. TEST PLAN Set plasmoid.busy=true/false to toggle a busy spinner overlay. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISI

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 35 - Still Unstable!

2017-01-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 07:56:10 + Build duration: 16 min CHANGE SET Revision 9cfcef4fbe45ab96f3710779fd