albertvaka added a comment.
In https://phabricator.kde.org/D4215#79400, @mck182 wrote:
> Fair enough.
>
> Let's make a step back then. Since you've mentioned "Plasma is the only
notification system that does close-on-activate instead of executing some
action", can you actually list w
> On Jan. 23, 2017, 8:10 p.m., Albert Astals Cid wrote:
> > Any reason this has not been committed?
Yes, IIRC the KService usage in KRunner was reintroduced. We need to retest the
patch now.
- Aleix
---
This is an automatically generat
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4257
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/566/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 21:56:46 +
Build duration: 5 min 48 sec
CHANGE SET
Revision 8925c105206049b8c198039c15d646
broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129036/
---
(Updated Jan. 23, 2017, 10:56 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129035/
---
(Updated Jan. 23, 2017, 9:52 nachm.)
Status
--
This change has been
hein added a comment.
Thanks! Sorry for straight committing, I was getting a bit grumpy ;)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4090
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, jensreuterberg,
broulik added a comment.
I think I can live with that.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4090
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, jensreuterberg, apol
Cc: subdiff, mart, hein, broul
hein updated this revision to Diff 10468.
hein added a comment.
Various cleanups suggested by Kai.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4229?vs=10411&id=10468
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4229
AFFECTED F
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 21:09:22 +
Build duration: 5 min 53 sec
CHANGE SET
Revision cd361efff2fb4eaf456a
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/565/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 20:00:12 +
Build duration: 23 min
CHANGE SET
Revision be4cff0ed1dea4515751210b7db9fe3f29dd
hein marked 7 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> broulik wrote in GroupDialog.qml:253
> I don't get how assigning a number as a child works. This line makes no sense
> to me.
Actually, to me it doesn't, either ;). I was asleep at the wheel/rushed
earlier, wi
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 20:00:12 +
Build duration: 27 min
CHANGE SET
Revision be4cff0ed1dea4515751210b7d
hein commandeered this revision.
hein added a reviewer: apol.
hein added a comment.
I've asked twice to look into using the tray's sizing logic; since it was
being ignored I've just done it:
https://commits.kde.org/plasma-desktop/cd361efff2fb4eaf456a9f1186d795a869f45d51
Anchoring to
hein abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4090
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, jensreuterberg, apol
Cc: subdiff, mart, hein, broulik, plasma-devel, lesliezhai,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129875/
---
(Updated Jan. 23, 2017, 7:32 p.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129875/#review102225
---
Ship it!
Ship It!
- Marco Martin
On Jan. 23, 2017, 7:1
broulik added a comment.
With this patch the icon is actually *bigger* now than it was before.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4090
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, jensreuterb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129035/#review102221
---
Any reason this is not commited yet?
- Albert Astals Cid
graesslin added a dependency: D4220: Add a basic SNI for keyboard layout.
REVISION DETAIL
https://phabricator.kde.org/D4256
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed,
graesslin added a dependent revision: D4256: Support global shortcut to switch
to specific layout.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4220
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_waylan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129315/#review102223
---
Any reason this has not been committed?
- Albert Astals Cid
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129875/
---
Review request for Plasma and Marco Martin.
Repository: plasma-desktop
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
Our keyboard layout kcm allows to set a global shortcut to switch to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129036/#review10
---
Any reason this is not commited yet?
- Albert Astals Cid
apol updated this revision to Diff 10465.
apol added a comment.
Use marco's formula
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4090?vs=10068&id=10465
BRANCH
arcpatch-D4090
REVISION DETAIL
https://phabricator.kde.org/D4090
AFFECTED FILES
apol marked an inline comment as done.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4090
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, jensreuterberg
Cc: subdiff, mart, hein, broulik, plasma-devel, lesliezh
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:3b0ee7dcf3fd: Fix appstream name/summary ends with '.'
warning (authored by apol).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4203?vs=10358&id=10464
REVISION
elvisangelaccio added inline comments.
INLINE COMMENTS
> arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370
> Yes it should be but what is the easy way to do that? Do I have to parse the
> result of qVersion()? CMakeLists.txt says the minimum version is 5.5 so I
> can't use QVersionNu
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/701/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 17:20:39 +
Build duration: 16 min
CHANGE SET
Revision c11aac0f58628825ee0e7023de0d88c2f3
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/700/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 17:00:03 +
Build duration: 18 min
CHANGE SET
Revision c782c97b81916d6bf9f0eabf859e375918
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:63cfbd991e01: Remove pointless QObject inheritance in
model item (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4218?vs=10378
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 17:00:03 +
Build duration: 6 min 13 sec
CHANGE SET
Revision e6794603e6c55aae67
https://bugs.kde.org/show_bug.cgi?id=375457
rockonthemoo...@gmail.com changed:
What|Removed |Added
CC||rockonthemoo...@gmail.com
--- Commen
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c11aac0f5862: Remove unused feature "favorite" from
PlasmaAppletItemModel (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4217?vs=10376&id=10461#toc
REPOSITORY
R
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
simplification++
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4218
EMAIL PREFERENCES
https://phabricator.kd
Am 2017-01-23 12:18, schrieb Sebastian Kügler:
Enjoy!
Just some notes from me:
mostly working on keyboard layout improvements on Wayland, trying to get
feature parity.
I have quite some open reviews, some also for 5.9 branch which are in
limbo state for more than a week now. Reviews appreci
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
fun fact: this was used only in the first qwidget-based widget explorer, used
only until KDE 4.2
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAI
broulik added inline comments.
INLINE COMMENTS
> hein wrote in GroupDialog.qml:253
> Doing it declaratively creates a binding loop in this case.
I don't get how assigning a number as a child works. This line makes no sense
to me.
> hein wrote in GroupDialog.qml:264
> I think this wasn't possib
Am 23. Januar 2017 17:11:50 MEZ schrieb Jonathan Riddell :
>At today's meeting we wanted a meeting to kickoff Plasma 5.10 during
>the Affenfels sprint week, but hold it online so others can join in.
>How does Monday 6th February at 14:00UTC, 15:00CET suit folks?
In general the earliest I can joi
On Mon, Jan 23, 2017 at 10:09:04PM +0530, Bhushan Shah wrote:
>
>
> On Jan 23, 2017 9:42 PM, "Jonathan Riddell" wrote:
>
> At today's meeting we wanted a meeting to kickoff Plasma 5.10 during
> the Affenfels sprint week, but hold it online so others can join in.
> How does Monday 6t
On Jan 23, 2017 9:42 PM, "Jonathan Riddell" wrote:
At today's meeting we wanted a meeting to kickoff Plasma 5.10 during
the Affenfels sprint week, but hold it online so others can join in.
How does Monday 6th February at 14:00UTC, 15:00CET suit folks?
I propose moving it to 7th February, given
At today's meeting we wanted a meeting to kickoff Plasma 5.10 during
the Affenfels sprint week, but hold it online so others can join in.
How does Monday 6th February at 14:00UTC, 15:00CET suit folks?
Held on IRC I guess unless someone wants to hook up a UDS style
conference speaker and video came
https://bugs.kde.org/show_bug.cgi?id=375457
Bug ID: 375457
Summary: Low battery applet animation uses a lot of CPU
Product: Powerdevil
Version: 5.8.3
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity:
mart added inline comments.
INLINE COMMENTS
> apol wrote in ListItem.qml:97
> Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...
>
> It's barely a behavioral change, in fact it's what it was supposed to happen
> in the first place: give feedback on hover when the item
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4203
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #
hein marked 7 inline comments as done.
hein added a comment.
Will update once I have a Qt again.
INLINE COMMENTS
> broulik wrote in ContextMenu.qml:537
> Unrelated
Will do.
> broulik wrote in GroupDialog.qml:63
> Remove
Will do.
> broulik wrote in GroupDialog.qml:113-114
> Why this change
konstantinshtepa updated this revision to Diff 10453.
konstantinshtepa added a comment.
Rewrited some code to better understanding
Fixed background-handle animation in plasmoidBackground. It was a little bug,
but I don't see any sense to report it now when patch are ready. Fixed it by
chang
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 Jan 2017 11:42:27 +
Build duration: 18 min
CHANGE SET
Revision 276d805b039292c18f4e523186
konstantinshtepa added a comment.
A detailed explanation of bugs, fixes and mechanics changes
===
Before anything else I'd like to explain why I need this patch. At winter
holidays I had a free time and decided to rewrite plasma-si
broulik added a comment.
FTR the Qt bug that caused this is fixed in 5.8:
https://bugreports.qt.io/browse/QTBUG-55856
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3823
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:276d805b0392: Add missing descriptions on the trashcan
and appmenubar plasmoids (authored by apol).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4205?vs=10
broulik accepted this revision.
broulik added a reviewer: broulik.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4205
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, davidedmundson, #plasma, brouli
broulik added inline comments.
INLINE COMMENTS
> ContextMenu.qml:537
> +onClicked: {
> +console.log("unpin request", modelIndex,
> get(atm.LauncherUrlWithoutIcon));
> +
Unrelated
> GroupDialog.qml:63
> +
> +console.log(itemTop, itemBottom);
> +
Remove
> GroupD
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4249
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: d
https://bugs.kde.org/show_bug.cgi?id=358957
Riku Voipio changed:
What|Removed |Added
CC||nc...@kos.to
--- Comment #14 from Riku Voipio --
Enjoy!
--
sebas
http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 16-01-2017
Present: Sho_, notmart, bshah, Riddell
Sho:
* [FV/General] Changed plasma-frameworks default tooltip delegate not to
truncate tooltip maintext, fixes truncated file names in FV tooltips
* [FV] Still need
apol updated this revision to Diff 10450.
apol added a comment.
Adopt Kai remarks
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4205?vs=10362&id=10450
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4205
AFFECTED FILES
applet
arichardson added inline comments.
INLINE COMMENTS
> graesslin wrote in kdeplatformfiledialoghelper.cpp:365-370
> Shouldn't that be a runtime check?
Yes it should be but what is the easy way to do that? Do I have to parse the
result of qVersion()? CMakeLists.txt says the minimum version is 5.5
On Mon, Jan 23, 2017 at 3:24 PM, Marco Martin wrote:
> On Saturday 14 January 2017, R.Harish Navnit wrote:
>> The kdelook.org urls seem to require authentication now, which wasn't
>> the case earlier IIRC, which means they'd be unusable(or not ideal) in
>> an applet, I believe. Is there a place wh
broulik added inline comments.
INLINE COMMENTS
> metadata.desktop:81
> Name[zh_TW]=資源回收筒
> +Comment=Integrates the system trashcan
> Type=Service
That is very technical. "Provides access to trashed files"?
> metadata.desktop:20
> Name[x-test]=xxApplication Menu Barxx
> +Comment=Integrates th
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
CC the i18n people in the commit
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4205
EMAIL PREFERENCES
https://phabr
apol added a comment.
Ping
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4205
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abett
davidedmundson added inline comments.
INLINE COMMENTS
> AppletAppearance.qml:59
> +appletContainer.anchors.leftMargin +
> +appletContainer.anchors.rightMargin - handleWidth);
> +}
why are you including handleWidth here?
>From what I can see in
konstantinshtepa updated the summary for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: konstantinshtepa, #plasma
Cc: davidedmundson, plasma-devel, lesliezha
konstantinshtepa updated this revision to Diff 10447.
konstantinshtepa added a comment.
Fix commit message
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4204?vs=10446&id=10447
BRANCH
plasmoid_size_restraints
REVISION DETAIL
https://phabricator
konstantinshtepa updated this revision to Diff 10446.
konstantinshtepa added a comment.
Turn on background width animation again.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4204?vs=10408&id=10446
BRANCH
plasmoid_size_restraints
REVISION DETAI
On Saturday 14 January 2017, R.Harish Navnit wrote:
> The kdelook.org urls seem to require authentication now, which wasn't
> the case earlier IIRC, which means they'd be unusable(or not ideal) in
> an applet, I believe. Is there a place where all of this can/is hosted
> publicly ?
>
> I tried to
69 matches
Mail list logo
