Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 18 - Still Unstable!

2017-01-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 22 Jan 2017 06:27:19 + Build duration: 6 min 13 sec CHANGE SET Revision 061a4600444515f8420a

Review Request 129869: Complete breeze-dark look and feel

2017-01-21 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129869/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

Review Request 129868: [lookandfeel] Complete breeze look and feel

2017-01-21 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129868/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: plasma-w

Review Request 129867: Complete oxygen look and feel

2017-01-21 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129867/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 563 - Still Unstable!

2017-01-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/563/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 22 Jan 2017 04:46:38 + Build duration: 5 min 51 sec CHANGE SET Revision d8f32ceb68d89ab5f5fbcf5ce23900

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-21 Thread Albert Vaca Cintora
albertvaka added a comment. In https://phabricator.kde.org/D4215#79153, @mck182 wrote: > Well there you go then. Just implement the default action to be always the top-most button in our actions list and make clicking the popup always execute the first action in the list. That way, if th

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-21 Thread Martin Klapetek
mck182 added a comment. Well there you go then. Just implement the default action to be always the top-most button in our actions list and make clicking the popup always execute the first action in the list. That way, if there are buttons, the user will know that clicking the popup will trig

[Differential] [Commented On] D4109: update componentchooser kcm docbook

2017-01-21 Thread Burkhard Lück
lueck added a comment. Please review, thanks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4109 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #plasma, #documentation Cc: plasma-devel, lesliezhai, ali-mohamed, je

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-21 Thread Albert Vaca Cintora
albertvaka added a comment. In https://phabricator.kde.org/D4215#79036, @mck182 wrote: > Plasma might also be the only system that uses buttons for actions Nope: http://imgur.com/a/Tfen4 We are not inventing the wheel here. Current, modern notifications are something that has

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-21 Thread Albert Vaca Cintora
albertvaka added a comment. In https://phabricator.kde.org/D4215#79036, @mck182 wrote: > Thinking about it a bit more, not doing anything when you click the notification without default action is again a guess game - "will clicking this popup do anything? how do I know?". KDE app

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-21 Thread Albert Vaca Cintora
albertvaka added a comment. In https://phabricator.kde.org/D4215#79072, @colomar wrote: > Since there does not seem a clear "best solution", isn't this something that should be decided on a cross-desktop level? > After all, it's not just about what users expect, but also what app deve

[Differential] [Updated, 174 lines] D4229: Overhaul group popup dialog

2017-01-21 Thread Eike Hein
hein updated this revision to Diff 10411. hein added a comment. Make active task pre-collection reliable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4229?vs=10398&id=10411 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4229 AFF

[Differential] [Request, 3 lines] D4233: Fix "Unpin" for tasks pinned to specific activities.

2017-01-21 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, ivan. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY requestRemoveLauncherFromActivities() had no code path handling NULL_UUID. BUG:375373 REPOSITORY R120 Plasma Workspace

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-21 Thread Thomas Pfeiffer
colomar added a comment. Since there does not seem a clear "best solution", isn't this something that should be decided on a cross-desktop level? After all, it's not just about what users expect, but also what app developers can expect to happen with their notifications. REPOSITORY R120

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

2017-01-21 Thread Eike Hein
hein added a comment. After living it for a while I now agree that the indicators are too large, so I'd prefer this to go into 5.9. I'm worried about the 0.7 magic number though. What does the systray do? The tray icons are much smaller than the audio indicators on my panel, and feel li

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-01-21 Thread Martin Koller
> On Jan. 16, 2017, 8:40 a.m., Kåre Särs wrote: > > The current/old version uses "connectSource(source)" to add the CPUs when > > they are added in onSourceAdded, but that is not good if the sources are > > added before SystemLoadViewer.qml (a problem when adding a second > > SytemLoadViewer)

[Differential] [Updated, 318 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-21 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10408. konstantinshtepa added a comment. Rewrited commit message in according to kde commit polititcs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4204?vs=10407&id=10408 BRANCH plasmoid_size_restrai

[Differential] [Updated] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-21 Thread Konstantin Shtepa
konstantinshtepa updated the summary for this revision. konstantinshtepa updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: konstantins

[Differential] [Updated, 318 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-21 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10407. konstantinshtepa added a comment. Summary: reworked set of patches to plasma-desktop/containments/desktop to fix bugs in plasmoid. Fix for - plasmoid applet missing maximum size handler - plasmoid can't be set to declared minimumW