[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

hein added a comment. I'm personally very happy to see the byline. While I agree the rebranding and establishing a Plasma logo/brand are smart and important, the backing identity of the KDE community is emotionally important to me, and seeing it represented at login both feels good as well a

[Differential] [Commented On] D4059: Replace recursive layout loading with dynamic loading

davidedmundson added a comment. and to answer the ineviatible question, this one (combined with the other libdbusmenuqt patch) does fix everything. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4059 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Request, 43 lines] D4059: Replace recursive layout loading with dynamic loading

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The previous code worked as follows: - when we show a menu we would emit aboutToShow on th

[Differential] [Accepted] D4058: Add small app for testing appmenu

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4058 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 69 lines] D4058: Add small app for testing appmenu

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY App which exports a menu, designed to simulate so that the dbus menu can be easily extended f

[Differential] [Accepted] D4054: update engineexplorer + plasmoidviewer manpages and include in build

aacid accepted this revision. aacid added a reviewer: aacid. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D4054 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #plasma, #do

[Differential] [Commented On] D4057: Reuse QAction and QMenu items on updates

davidedmundson added a comment. > Also, i seem to be missing where you set DBUSMENU_PROPERTY_ID on an action (or it's done in d->createAction?). Yes, it's an existing thing set there. The map is also existing, and it's used for a few other entry points, especially DBusMenuImporter::

[Differential] [Commented On] D4057: Reuse QAction and QMenu items on updates

markg added a comment. Hi David, You have an interesting approach here! I've been struggling with something similar recently as well and also - initially - had my own lookup table for int -> QAction. It worked, but the added bookkeeping seemed silly so i searched for a more "elegant" s

[Differential] [Accepted] D4040: [Icon Item] Round size we want to load a pixmap in

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. though typically we do rounding in the QML side as it can cause these problems with some other items too. REPOSITORY R242

[Differential] [Commented On] D4057: Reuse QAction and QMenu items on updates

davidedmundson added a comment. (And to reply to the ineviatible Kai question, no this doesn't fix all the update problems - but it does put us one step closer) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4057 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Request, 46 lines] D4057: Reuse QAction and QMenu items on updates

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When updating a menu we would always delete all the actions and recreate them. This caus

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

graesslin added a comment. In https://phabricator.kde.org/D4050#75738, @broulik wrote: > I fear it might become some rubbish as "durch KDE" or "gemacht von KDE" or "Hersgestellt von KDE". I somewhat agree with you though, partially. in that case we need a clear context. Including

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

broulik added a comment. I fear it might become some rubbish as "durch KDE" or "gemacht von KDE" or "Hersgestellt von KDE". I somewhat agree with you though, partially. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4050 EMAIL PREFERENCES https://phabric

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

graesslin added a comment. As I wasn't around on IRC: why not translatable? In general I dislike English branding on products. If I'm using a German localization I also want to have the product tagline in German. If it's English, people don't understand it. The most common example for that i

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

graesslin added a comment. Please include the i18n team to ack that this should not be translated. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4050 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: gr

[Differential] [Accepted] D1771: [Workspace Options] Add option to disable OSD

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, graesslin, #plas

[Differential] [Updated] D4054: update engineexplorer + plasmoidviewer manpages and include in build

lueck added a reviewer: Documentation. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D4054 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #plasma, #documentation Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 133 lines] D4054: update engineexplorer + plasmoidviewer manpages and include in build

lueck created this revision. lueck added a reviewer: Plasma. lueck set the repository for this revision to R118 Plasma SDK. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN build + install REPOSITORY R118 Plasma SDK REVISION D

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

mck182 added a comment. If I may add a slightly unrelated comment - the circly parts of the new logo seem to throw the spinner a bit off visually, I think it could use some larger spacing in between those two. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

subdiff added a comment. Logo integrated into text? F1976427: splash.png F1976429: bykde.svgz REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4050 EMAIL PREFERENCES htt

[Differential] [Closed] D4042: Fix listing when the requested path is absolute

This revision was automatically updated to reflect the committed changes. Closed by commit R290:f311434c5d9f: Fix listing when the requested path is absolute (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4042?vs=9917&id=9941 REVISION DET

[Differential] [Closed] D4043: fix handling of archives with a folder in them

This revision was automatically updated to reflect the committed changes. Closed by commit R290:5506b535f7ba: fix handling of archives with a folder in them (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4043?vs=9937&id=9940 REVISION DETA

[Differential] [Accepted] D4042: Fix listing when the requested path is absolute

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D4042 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, #frameworks, mart Cc:

[Differential] [Closed] D4045: Make sure we use kpackagetool5 instead of plasmapkg2

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d579beb13486: Make sure we use kpackagetool5 instead of plasmapkg2 (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4045?vs=9920&id=9939 R

[Differential] [Closed] D4046: Use kpackagetool5 instead of plasmapkg

This revision was automatically updated to reflect the committed changes. Closed by commit R120:82eacb574c92: Use kpackagetool5 instead of plasmapkg (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4046?vs=9921&id=9938 REVISION DETA

[Differential] [Accepted] D4043: fix handling of archives with a folder in them

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH phab/subdir REVISION DETAIL https://phabricator.kde.org/D4043 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ma

[Differential] [Updated, 15 lines] D4043: fix handling of archives with a folder in them

mart updated this revision to Diff 9937. mart added a comment. - add a test REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4043?vs=9916&id=9937 BRANCH phab/subdir REVISION DETAIL https://phabricator.kde.org/D4043 AFFECTED FILES autotests/data/cust

[Differential] [Accepted] D4045: Make sure we use kpackagetool5 instead of plasmapkg2

mart accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4045 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, davidedmundson, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Accepted] D4045: Make sure we use kpackagetool5 instead of plasmapkg2

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4045 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Accepted] D4046: Use kpackagetool5 instead of plasmapkg

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4046 EMAIL PREFERENCES https://phabricator.kde.org/setting

[Differential] [Commented On] D4043: fix handling of archives with a folder in them

mart added a comment. In https://phabricator.kde.org/D4043#75627, @apol wrote: > Can you add a test for the case? not sure if i like adding a tarball in the repository.. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D4043 EMAIL PREFERENCES https://ph

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

mart added a comment. F1976332: Spectacle.E28564.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4050 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-de

[Differential] [Request, 10 lines] D4050: add a "by KDE" sign in the splash

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this was discussed today on irc that after the logos around have been rebranded to still have a by KDE sign.

[Differential] [Updated, 42 lines] D1771: [Workspace Options] Add option to disable OSD

broulik updated this revision to Diff 9933. broulik added a comment. - cast function ptr instead of lambda REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1771?vs=9925&id=9933 REVISION DETAIL https://phabricator.kde.org/D1771 AFFECTED FILES kcms

[Differential] [Commented On] D1770: [OSD] Allow disabling OSD through config file

graesslin added inline comments. INLINE COMMENTS > shellcorona.cpp:224-227 > +const QString configFile = > QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + > QLatin1Char('/') + m_config->name(); > +KDirWatch::self()->addFile(configFile); > +connect(KDirWatch

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

graesslin added inline comments. INLINE COMMENTS > workspaceoptions.cpp:56-58 > +connect(m_ui->showOsd, &QCheckBox::toggled, this, [this] { > +changed(); > +}); why a lambda? It looks like you just could bind it to a signal REPOSITORY R119 Plasma Desktop REVISION DETAIL htt

[Differential] [Commented On] D4043: fix handling of archives with a folder in them

apol added a comment. Can you add a test for the case? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D4043 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: apol, plasma-devel, #frameworks, lesliezhai, ali-moham

[Differential] [Closed] D4017: Break from loop once we've found a Layout

This revision was automatically updated to reflect the committed changes. Closed by commit R242:57d58e371da0: Break from loop once we've found a Layout (authored by broulik). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4017?vs=9853&id=9927 REVISI

[Differential] [Updated, 31 lines] D1770: [OSD] Allow disabling OSD through config file

broulik updated this revision to Diff 9926. broulik added a comment. - Watch plasmarc to monitor changes to the OSD setting at runtime REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1770?vs=9923&id=9926 REVISION DETAIL https://phabricator.kde.or

[Differential] [Updated, 44 lines] D1771: [Workspace Options] Add option to disable OSD

broulik updated this revision to Diff 9925. broulik added a comment. - Address issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1771?vs=4219&id=9925 REVISION DETAIL https://phabricator.kde.org/D1771 AFFECTED FILES kcms/workspaceoptions/mai

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #10 from gust...@angulosolido.pt --- The problem happens after suspend + resume. Situation goes back to normal with: killplasmashell kstart plasmashell The lock screen has a battery monitory that shows no problems. Any news on getting this

[Differential] [Updated, 20 lines] D1770: [OSD] Allow disabling OSD through config file

broulik updated this revision to Diff 9923. broulik added a comment. - Introduce a shared config for plasmarc, used by both OSD and LNF thingie REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1770?vs=9898&id=9923 REVISION DETAIL https://phabricat

[Differential] [Closed] D4041: [task manager] No subtext audio indicator in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e9bdca996091: [Task Manager] No audio indicator message in tooltip subtext (authored by subdiff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4041?vs=9906

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

broulik added a comment. I now used "Visual feedback for status changes" with a tooltip "Show a popup for status changes such as brightness or volume." REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settin

[Differential] [Accepted] D4017: Break from loop once we've found a Layout

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4017 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasm

[Differential] [Request, 7 lines] D4046: Use kpackagetool5 instead of plasmapkg

apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's been deprecated for a bit Also register it in drkonqi REPOSITORY R120 Plasma Workspace BRANCH mas

[Differential] [Request, 11 lines] D4045: Make sure we use kpackagetool5 instead of plasmapkg2

apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's been deprecated since longtime REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL http

[Differential] [Accepted] D4044: Remove bell kcm docbook

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4044 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #plasma,

[Differential] [Request, 67 lines] D4044: Remove bell kcm docbook

lueck created this revision. lueck added a reviewer: Plasma. lueck added a subscriber: Plasma. lueck set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Code was rem

[Differential] [Closed] D3939: fix description for option -t in man page

lueck closed this revision. lueck added a comment. commited with https://commits.kde.org/kpackage/da80b5461de4b341899a7a282c3fae59f868edd4 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Updated, 16 lines] D4042: Fix listing when the requested path is absolute

apol updated this revision to Diff 9917. apol added a comment. Make sure we list the plugins in the correct directory if we don't have a reason not to REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4042?vs=9907&id=9917 BRANCH master REVISION DETAIL

[Differential] [Request, 4 lines] D4043: fix handling of archives with a folder in them

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY package archives are found in the wild in 2 forms: with the files (including metadata at th

[Differential] [Closed] D4033: Return valid string value for DescriptionRole in all models

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4b46112a59cb: Return valid string value for DescriptionRole in all models (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4033?v

[Differential] [Closed] D4030: Remove shell's copy of PlasmaQuick headers

This revision was automatically updated to reflect the committed changes. Closed by commit R120:04c54f4e5828: Remove shell's copy of PlasmaQuick headers (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4030?vs=9883&id=9912

[Differential] [Closed] D4029: Remove private include of PlasmaQuick

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8f74e49c82c6: Remove private include of PlasmaQuick (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4029?vs=9879&id=9911 REVI

[Differential] [Closed] D4031: warning on unused var

This revision was automatically updated to reflect the committed changes. Closed by commit R120:56bf8ce4f703: warning on unused var (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4031?vs=9881&id=9913 REVISION DETAIL ht

[Differential] [Closed] D4028: Sort out compile warnings on unused vars

This revision was automatically updated to reflect the committed changes. Closed by commit R120:905f72b2336b: Sort out compile warnings on unused vars (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4028?vs=9878&id=9910 R

[Differential] [Closed] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:235d91109276: [Folder View] Replace Up button with Back button in listview mode (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3931?vs=9900&id=9909#toc REPOSITORY R11

[Differential] [Closed] D3927: Fix CD'ing into desktop files in plasma folder view placed inside panel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:23cff2bf3521: [Folder View] Fix CD in "Link" type desktop files (authored by chinmoyr). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3927?vs=9625&id=9908

[Differential] [Request, 14 lines] D4042: Fix listing when the requested path is absolute

apol created this revision. apol added reviewers: Plasma, Frameworks, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This happens when calling from kpackagetool5 --list REPOSITORY R290 KPackage BRANCH

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 09 Jan 2017 12:50:27 + Build duration: 26 min CHANGE SET Revision 05920ab34283dd91d6575e6f479

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 09 Jan 2017 12:50:27 + Build duration: 26 min CHANGE SET Revision 05920ab34283dd91d6575e6f479

[Differential] [Request, 8 lines] D4041: [task manager] No subtext audio indicator in tooltip

subdiff created this revision. subdiff added reviewers: Plasma, broulik. subdiff set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise breaks the design goal

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

broulik added a comment. So what text should we go for then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin Cc: andreaska,

[Differential] [Commented On] D4040: [Icon Item] Round size we want to load a pixmap in

subdiff added a comment. It seems there have been problems with this before the new aspect-ratio aware IconItem aswell. See https://bugs.kde.org/show_bug.cgi?id=365326 Could your patch also solve this issue? Then we need to backport it to 5.8. REPOSITORY R242 Plasma Frameworks REVISIO

[Differential] [Closed] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:036b545baaa6: [Icon Applet] Add "Open With" and "Open Containing Folder" actions (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3905

[Differential] [Commented On] D4040: [Icon Item] Round size we want to load a pixmap in

subdiff added a comment. Just tested and this solves pixelated launcher icons, i.e. https://bugs.kde.org/show_bug.cgi?id=374707 REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D4040 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, hein, #plasma Cc: plasma-devel, lesli

[Differential] [Request, 2 lines] D4040: [Icon Item] Round size we want to load a pixmap in

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QML sizes can b

[Differential] [Updated, 303 lines] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

chinmoyr updated this revision to Diff 9900. chinmoyr added a comment. Minor changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3931?vs=9811&id=9900 REVISION DETAIL https://phabricator.kde.org/D3931 AFFECTED FILES containments/desktop/packa

[Differential] [Updated, 15 lines] D1770: [OSD] Allow disabling OSD through config file

broulik updated this revision to Diff 9898. broulik added a comment. - Inject KSharedConfig::Ptr from outside REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1770?vs=4218&id=9898 REVISION DETAIL https://phabricator.kde.org/D1770 AFFECTED FILES

[Differential] [Accepted] D4038: [Task Manager] Only match application name if we never managed to match PID

subdiff accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4038 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, subdiff, #plasma Cc: plasma-d

[Differential] [Request, 32 lines] D4038: [Task Manager] Only match application name if we never managed to match PID

broulik created this revision. broulik added reviewers: Plasma, hein, subdiff. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When there are two instanc

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 531 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/531/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 09 Jan 2017 08:31:12 + Build duration: 8 min 29 sec CHANGE SET Revision 6c3c04fb43cda9c150c56960cf72855

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 531 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/531/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 09 Jan 2017 08:31:12 + Build duration: 8 min 29 sec CHANGE SET Revision 6c3c04fb43cda9c150c56960cf72855

[Differential] [Commented On] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

hein added a comment. Looks like it will be the code comment route: ‎[17:38] ‎<‎Sho_‎>‎ btw ‎[17:39] ‎<‎Sho_‎>‎ i have a dev on phab who claims push/pop on a [] held in a var-type prop doesn't notify ‎[17:39] ‎<‎Sho_‎>‎ anyone run into this? ‎[17:39] ‎<‎kbroulik‎>‎ yup ‎[17:39] ‎<

[Differential] [Commented On] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

hein added a comment. Thanks for the explanation. Thoughts: - Can you try { new Array() } or something instead of []? There's some confusion in QML between "QML list" and "JavaScript array", perhaps the prop notification works with an explicity array. - If this doesn't work either,

[Differential] [Closed] D4037: [Task Manager] Also match application name to find audio stream

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6c3c04fb43cd: [Task Manager] Also match application name to find audio stream (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4037?vs=9

[Differential] [Accepted] D4037: [Task Manager] Also match application name to find audio stream

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Fixed Firefox Nightly for me, nice. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4037 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Request, 31 lines] D4037: [Task Manager] Also match application name to find audio stream

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The process playing audio isn't nec

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 530 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/530/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 09 Jan 2017 08:00:49 + Build duration: 2 min 31 sec CHANGE SET Revision 0efca24f66555eccf20b9db574805ed