[Differential] [Request, 739 lines] D3805: Per-activity favorites (WIP)

2016-12-23 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: hein, mart. ivan set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY After a long course of implementations and rei

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-23 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Oh! I think I now see why we have this bug. We get a disconnect then connect, which from Qt5.5 goes: Old Real Screen Fake Screen New Real Screen You never get any signals when you're going to or from the fake screen (by design), but implicitly

[Differential] [Accepted] D3803: Add support for on-screen-message to kwineffects

2016-12-23 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH on-screen-message-effects REVISION DETAIL https://phabricator.kde.org/D3803 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Request, 58 lines] D3803: Add support for on-screen-message to kwineffects

2016-12-23 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, KWin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This adds support for the new on-screen-message support to the kwineffects API and makes use of

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-23 Thread mart (Marco Martin)
mart added a comment. note, 5.8.5 is out the 27th, and this needs to be there, as it fixes a major issue. if no further comments before then, tomorrow 24th I'll push REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3777 EMAIL PREFERENCES https://phabrica

Re: Review Request 129700: Install a kpackage-generic.desktop file

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129700/ --- (Updated Dec. 23, 2016, 4:32 p.m.) Status -- This change has been ma

Re: Review Request 129698: Avoid double look-up

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129698/ --- (Updated Dec. 23, 2016, 4:32 p.m.) Status -- This change has been ma

Re: Review Request 129699: Exclude qmlc files from installation

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129699/ --- (Updated Dec. 23, 2016, 5:32 p.m.) Status -- This change has been ma

Re: Review Request 129700: Install a kpackage-generic.desktop file

2016-12-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129700/#review101562 --- Ship it! Ship It! - Marco Martin On Dec. 23, 2016, 4:2

Review Request 129700: Install a kpackage-generic.desktop file

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129700/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 129699: Exclude qmlc files from installation

2016-12-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129699/#review101561 --- Ship it! Ship It! - Marco Martin On Dec. 23, 2016, 4:1

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-23 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. Okay, thanks for fixing for Qt 5.8. Cherry-picked your commit also for the Plasma/5.8 branch now for upcoming Plasma 5.8.4 release, given Plasma 5.9.0 will only appear after Qt 5.8.0 (by schedules at least), so chances are people will want to run 5.8 with 5.8 :) RE

Review Request 129699: Exclude qmlc files from installation

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129699/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 129698: Avoid double look-up

2016-12-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129698/#review101560 --- Ship it! Ship It! - Marco Martin On Dec. 23, 2016, 4:0

Re: Review Request 129698: Avoid double look-up

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129698/ --- (Updated Dec. 23, 2016, 5:09 p.m.) Review request for KDE Frameworks and

Review Request 129698: Avoid double look-up

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129698/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Review Request 129697: Figure out software center integration on the menus

2016-12-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129697/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Using javascript-api extension LaunchApp and plasmoid.runCommand in Plasma 5 plasmoid

2016-12-23 Thread Marco Martin
On Saturday 24 December 2016 02:07:21 Aditya Mehra wrote: > Hi, > > Not sure where to find support for this, but i am trying to use the > LaunchApp javascript-api extension in a plasmoid, to launch a shell script > via a button in my main.qml file. I came across this api extension on > https://tec

Using javascript-api extension LaunchApp and plasmoid.runCommand in Plasma 5 plasmoid

2016-12-23 Thread Aditya Mehra
Hi, Not sure where to find support for this, but i am trying to use the LaunchApp javascript-api extension in a plasmoid, to launch a shell script via a button in my main.qml file. I came across this api extension on https://techbase.kde.org/Development/Tutorials/Plasma4/JavaScript/API-LaunchApp w

[Differential] [Closed] D3801: [Lock Screen] Wrap OSD in its own ColorScope

2016-12-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c575baacc34e: [Lock Screen] Wrap OSD in its own ColorScope (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3801?vs=9334&id=9339 REVI

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-23 Thread dfaure (David Faure)
dfaure added a comment. git log says this is qtbase commit 1a42124, from before v5.8.0-alpha1. So I'll check for 5.8 and use clone, thanks for the information. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3796 EMAIL PREFERENCES

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-23 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kdeplatformfiledialoghelper.cpp:368 > This does NOT build for me. > > qplatformdialoghelper.h:295:5: error: > ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’ is private > kdeplatformfiledialoghelper.cpp:368:77

[Differential] [Accepted] D3801: [Lock Screen] Wrap OSD in its own ColorScope

2016-12-23 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3801 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Request, 14 lines] D3801: [Lock Screen] Wrap OSD in its own ColorScope

2016-12-23 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This avoids the complementary colorsco

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-23 Thread dfaure (David Faure)
dfaure added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:368 > +// like file://, so we have to do it ourselves > +QSharedPointer opt(new > QFileDialogOptions(*options())); > +opt->setInitialDirectory(m_dialog->directory()); This does NOT build for me. qplatfo

[Differential] [Closed] D3794: Recheck which representation we should using in setPreferredRepresentation

2016-12-23 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit R242:2affb1ab5672: Recheck which representation we should using in setPreferredRepresentation (authored by davidedmundson). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricat

[Differential] [Closed] D3707: add simple test rig for service runner

2016-12-23 Thread sitter (Harald Sitter)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e21d625a937b: add simple test rig for service runner (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3707?vs=9164&id=9332#toc REPOSITORY R120 Plasma Workspace CHANGES S

[Differential] [Closed] D3793: add keybpard navigation for listviews

2016-12-23 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c1175dc6e488: add keybpard navigation for listviews (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3793?vs=9317&id=9330 REVISION DETAIL http

[Differential] [Accepted] D3793: add keybpard navigation for listviews

2016-12-23 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH phab/keybnavig REVISION DETAIL https://phabricator.kde.org/D3793 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #kirigami, apol Cc: ap

[Differential] [Updated, 35 lines] D3777: notice when the only screen changes

2016-12-23 Thread mart (Marco Martin)
mart updated this revision to Diff 9327. mart added a comment. - remove useless debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9326&id=9327 BRANCH phab/screenheuristic REVISION DETAIL https://phabricator.kde.org/D3777 AFFECTED

[Differential] [Updated, 40 lines] D3777: notice when the only screen changes

2016-12-23 Thread mart (Marco Martin)
mart updated this revision to Diff 9326. mart added a comment. - set m_screenName in setScreenToFollow() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9259&id=9326 BRANCH phab/screenheuristic REVISION DETAIL https://phabricator.kde.o

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Elias Probst
https://bugs.kde.org/show_bug.cgi?id=374074 --- Comment #8 from Elias Probst --- (In reply to Elias Probst from comment #7) > (In reply to Kai Uwe Broulik from comment #6) > > Note that the grace period is only when the lock screen kicks in > > automatically, if you press Ctrl+Alt+L and lock it m

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Elias Probst
https://bugs.kde.org/show_bug.cgi?id=374074 --- Comment #7 from Elias Probst --- (In reply to Kai Uwe Broulik from comment #6) > Note that the grace period is only when the lock screen kicks in > automatically, if you press Ctrl+Alt+L and lock it manually, it's never in > grace period and always

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=374074 --- Comment #6 from Kai Uwe Broulik --- Note that the grace period is only when the lock screen kicks in automatically, if you press Ctrl+Alt+L and lock it manually, it's never in grace period and always requires a password to be unlocked. -- You are

[Differential] [Closed] D3789: [declarativeimports] Use QtRendering on phone devices

2016-12-23 Thread bshah (Bhushan Shah)
This revision was automatically updated to reflect the committed changes. Closed by commit R242:324232a745a8: [declarativeimports] Use QtRendering on phone devices (authored by bshah). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3789?vs=9287&id=93

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-23 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. I meant if you add this m_screenName *also* in set screen you'll reduce the number of false emits. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3777 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Elias Probst
https://bugs.kde.org/show_bug.cgi?id=374074 --- Comment #5 from Elias Probst --- (In reply to Kai Uwe Broulik from comment #4) > From what I can tell the password field is disabled when it's still in grace > period: > > enabled: !authenticator.graceLocked It's not disabled here… the cursor blin

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-23 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in desktopview.cpp:213 > if you add this in setScreen you'll reduce a lot of false positive signals on > initial connection/ startup when the outputs get switched, setScreen won't happen, the expose event is the only place that

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=374074 Kai Uwe Broulik changed: What|Removed |Added Flags||Usability? -- You are receiving this mail be

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=374074 --- Comment #4 from Kai Uwe Broulik --- >From what I can tell the password field is disabled when it's still in grace period: enabled: !authenticator.graceLocked -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-23 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3777#70790, @davidedmundson wrote: > At a minimum this needs an upstream bug report with a description of exactly what is happening in both QPAs and in QPlatformWindow. > > It's one thing to have a temporary workaround, it's anothe

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=374074 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Elias Probst
https://bugs.kde.org/show_bug.cgi?id=374074 --- Comment #3 from Elias Probst --- …and also related: The password field shouldn't even be shown while the lockscreen is still in its "grace period" where it allows unlocking without a password as it implies a false sense of security during this peri

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=374074 Kai Uwe Broulik changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED

[Breeze] [Bug 374074] Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=374074 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Breeze] [Bug 374074] New: Lock Screen: "Show Password" - lockscreen vulnerable to social engineering

2016-12-23 Thread Elias Probst
https://bugs.kde.org/show_bug.cgi?id=374074 Bug ID: 374074 Summary: Lock Screen: "Show Password" - lockscreen vulnerable to social engineering Product: Breeze Version: unspecified Platform: Gentoo Packages O

Review Request 129696: Fixes, popups from docks that use masking are misplaced

2016-12-23 Thread Michail Vourlakos
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129696/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Closed] D3745: [Folder View] Prevent stealing drop events on Compact Representation

2016-12-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e0b09c2929e0: [Folder View] Prevent stealing drop events on Compact Representation (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3745

[Differential] [Closed] D3756: [Folder View] Add "Restore" from trash option

2016-12-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:07402e9f7057: [Folder View] Add "Restore" from trash option (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3756?vs=9208&id=9323 REVIS

[Differential] [Closed] D3755: [Folder View] Offer "Empty Trash" whenever we're in "trash" scheme

2016-12-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6643cac64cc1: [Folder View] Offer "Empty Trash" whenever we're in "trash" scheme (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3755?v

[Differential] [Closed] D3744: [Folder View] Workaround QML Text layouting glitch

2016-12-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:980f3aafbaed: [Folder View] Workaround QML Text layouting glitch (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3744?vs=9184&id=9320

[Differential] [Commented On] D3216: WIP: Restore Menubar style config in application style

2016-12-23 Thread broulik (Kai Uwe Broulik)
broulik added a comment. There was a "you need to restart in order for appmenu changes to take effect" notification in notifyrc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3216 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Updated, 129 lines] D3793: add keybpard navigation for listviews

2016-12-23 Thread mart (Marco Martin)
mart updated this revision to Diff 9317. mart added a comment. - keyboardNavigationEnabled property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3793?vs=9299&id=9317 BRANCH phab/keybnavig REVISION DETAIL https://phabricator.kde.org/D3793 AFFECTED

[Differential] [Closed] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

2016-12-23 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R118:83d18d60ec8d: [Plasmoidviewer] Allow passing "externalData" to the applet (authored by broulik). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3787?vs=9285&id=9