Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

2016-12-15 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/ --- (Updated Dec. 16, 2016, 4:38 a.m.) Status -- This change has been ma

[Differential] [Closed] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

2016-12-15 Thread bshah (Bhushan Shah)
This revision was automatically updated to reflect the committed changes. Closed by commit R108:f906e21f3dac: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version (authored by bshah). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3686?vs=9036&id=905

[Differential] [Accepted] D3576: Reduce code-duplication of socketpair in WaylandServer

2016-12-15 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH wayland-server-socketpair REVISION DETAIL https://phabricator.kde.org/D3576 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Closed] D3575: [autotests/integration] Use socketpair for Wayland connection

2016-12-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:eae9bdd50ade: [autotests/integration] Use socketpair for Wayland connection (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3575?vs=8717&id=9050#toc REPOSITORY R108 K

[Differential] [Accepted] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

2016-12-15 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH support-hwc-1.5 REVISION DETAIL https://phabricator.kde.org/D3686 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, graesslin, #plasma

[Differential] [Accepted] D3575: [autotests/integration] Use socketpair for Wayland connection

2016-12-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH autotests-socketpair REVISION DETAIL https://phabricator.kde.org/D3575 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

2016-12-15 Thread bshah (Bhushan Shah)
bshah added inline comments. INLINE COMMENTS > bshah wrote in hwcomposer_backend.cpp:321 > I didn't get you on how it is not forward compatible? Oh actually nevermind. I got wrong line in email so was confused.. so idea here is you'll need to check 1.4 and 1.5 as there is also 2.0 and it is not

[Differential] [Commented On] D3575: [autotests/integration] Use socketpair for Wayland connection

2016-12-15 Thread Martin Gräßlin
graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3575 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, je

[Differential] [Commented On] D3576: Reduce code-duplication of socketpair in WaylandServer

2016-12-15 Thread Martin Gräßlin
graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D3576 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, je

[Differential] [Commented On] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

2016-12-15 Thread bshah (Bhushan Shah)
bshah added inline comments. INLINE COMMENTS > graesslin wrote in hwcomposer_backend.cpp:321 > hmm that doesn' t look really forward compatible. Can we have something like > > #if VERSION > 1_4 > > ? I didn't get you on how it is not forward compatible? REPOSITORY R108 KWin REVISION DETA

[Differential] [Commented On] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

2016-12-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > hwcomposer_backend.cpp:321 > + > +#if defined(HWC_DEVICE_API_VERSION_1_4) || > defined(HWC_DEVICE_API_VERSION_1_5) > +if (m_hwcVersion > HWC_DEVICE_API_VERSION_1_3) hmm that doesn' t look really forward compatible. Can we have something lik

[Differential] [Updated, 56 lines] D3688: [Runners] Register actions right away

2016-12-15 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 9043. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3688?vs=9042&id=9043 REVISION DETAIL https://phabricator.kde.org/D3688 AFFECTED FILES runners/baloo/baloosearchrunner.cpp runners/calculator/calculatorru

[Differential] [Request, 54 lines] D3688: [Runners] Register actions right away

2016-12-15 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, hein. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Previously, they

[Differential] [Commented On] D3687: take matching logic out of match method and put it into a class

2016-12-15 Thread sitter (Harald Sitter)
sitter added inline comments. INLINE COMMENTS > broulik wrote in servicerunner.cpp:124 > isnt NotShowIn a list property? Doesn't KService have a getter for that or > even take that into account in noDisplay()? something to consider in a follow up, for now I'd like to get the refactor landed.

[Differential] [Accepted] D3687: take matching logic out of match method and put it into a class

2016-12-15 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks INLINE COMMENTS > servicerunner.cpp:124 > +qCDebug(RUNNER_SERVICES) << service->name() << "is an exact > match!" << service->storageId() << service->exec(); > +

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-15 Thread Eike Hein
https://bugs.kde.org/show_bug.cgi?id=373668 Eike Hein changed: What|Removed |Added CC||h...@kde.org Resolution|WONTFIX

[Differential] [Updated, 1,924 lines] D3085: RFC: Use DBusMenu if available

2016-12-15 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 9040. davidedmundson added a comment. Rebased on master with merge conflict fixed Fixed cmake to work with Qt 5.7 and Qt5.8 REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3085?

[Differential] [Commandeered] D3085: RFC: Use DBusMenu if available

2016-12-15 Thread davidedmundson (David Edmundson)
davidedmundson commandeered this revision. davidedmundson added a reviewer: broulik. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundso

[Differential] [Request, 412 lines] D3687: take matching logic out of match method and put it into a class

2016-12-15 Thread sitter (Harald Sitter)
sitter created this revision. sitter added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY refactor and qcdebug ::match was a super long spagetthi with multiple sub-matches. This was supposedly

[Differential] [Closed] D3268: Applet: Show device icons and active port name

2016-12-15 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit R115:117ff0b08dea: Applet: Show device icons and active port name (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3268?vs=8025&id

[Differential] [Closed] D3553: Fix 2 RTL bugs

2016-12-15 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4fada5bdb032: Fix 2 RTL bugs (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3553?vs=8647&id=9037 REVISION DETAIL https://phabricator.kd

[Differential] [Request, 20 lines] D3686: [platforms/hwcomposer] Support for hwcomposer 1.4 and 1.5 version

2016-12-15 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY HWcomposer version 1.4 introduced setPowerMode, which replaces the blank(). This adds support for

[Differential] [Closed] D3638: Implement drag from free space also for QtQuickControls

2016-12-15 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit R113:c5f1504d7ce2: Implement drag from free space also for QtQuickControls (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3638?vs=8914&id=9035#toc REPOSITORY R113 Oxygen The

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-15 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #4 from Anton --- I insist on some kind of explanation. I made an afford to file a bug report, I pointed out that I know it is not a duplicate. This is going to be second dumbest thing in KDE after the current device notifier with it's tiny

[Differential] [Closed] D3519: Move updating of primary screen in screenpool after fetching its id

2016-12-15 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bdfa0f3fb726: Move updating of primary screen in screenpool after fetching its id (authored by jakubgocol, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D3681: Fix KAuthActionReply usage

2016-12-15 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. davidedmundson added a comment. I found this whilst grepping for KAuth usage for another patch I didn't think to git pull first, this file no longer exists. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D36

[Differential] [Accepted] D3638: Implement drag from free space also for QtQuickControls

2016-12-15 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it ! (sorry for the delay) REPOSITORY R113 Oxygen Theme BRANCH master REVISION DETAIL https://phabricator.kde.org/D3638 EMAIL PREFERENCES https://phabrica

[Differential] [Commented On] D3638: Implement drag from free space also for QtQuickControls

2016-12-15 Thread mart (Marco Martin)
mart added a comment. +1 any news on that? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, hpereiradacosta Cc: mart, plasma-devel, lesliezhai, ali-moham

[Differential] [Accepted] D3685: Add SDDM theme install/uninstall with GHNS to the SDDM KCM

2016-12-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH ghns REVISION DETAIL https://phabricator.kde.org/D3685 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D2687: [Icon Widget] Bring back properties dialog

2016-12-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure, mart Cc: mart, plasma-devel, lesliezhai

[Differential] [Accepted] D3684: WIP: Media Controls on lock screen

2016-12-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3684 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Request, 463 lines] D3685: Add SDDM theme install/uninstall with GHNS to the SDDM KCM

2016-12-15 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add SDDM theme install/uninstall with Get Hot New Stuff to the SDDM KCM. Button arrangement

[Differential] [Closed] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

2016-12-15 Thread subdiff (Roman Gilg)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d78b63b9ea77: [MPRIS Dataengine] Export process id of player instance as separate data entry (authored by subdiff). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Accepted] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

2016-12-15 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Request, 159 lines] D3684: WIP: Media Controls on lock screen

2016-12-15 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This provides media con

[Differential] [Accepted] D3681: Fix KAuthActionReply usage

2016-12-15 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D3681 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Updated, 589 lines] D2687: [Icon Widget] Bring back properties dialog

2016-12-15 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 9029. broulik marked 2 inline comments as done. broulik added a comment. - update actions also in Component.onCompleted so the "configure" button in applet handle works correctly the first time - Set icon for properties dialog ("document-properties", sam

[Differential] [Updated] D2687: [Icon Widget] Bring back properties dialog

2016-12-15 Thread broulik (Kai Uwe Broulik)
broulik marked 4 inline comments as done. broulik added inline comments. INLINE COMMENTS > dfaure wrote in iconapplet.cpp:242 > Just wondering, why is the parent widget nullptr here, while it's > QApplication::desktop() in other code further down? Not that it changes > anything at runtime, I su

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-15 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=373668 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Breeze] [Bug 373668] Tiny keyboard layout indicator is the Lock Screen

2016-12-15 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 Anton changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|DUPLICATE