[Differential] [Updated] D3494: Set m_client size in global compositor co-ordinates

2016-12-01 Thread davidedmundson (David Edmundson)
davidedmundson marked 2 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in scene_qpainter.cpp:311-313 > do you have a test case in another patch for this? If not I suggest to extend > the scene qpainter test to verify the rendering is correct with

[Differential] [Updated, 15 lines] D3494: Set m_client size in global compositor co-ordinates

2016-12-01 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 8684. davidedmundson retitled this revision from "Set m_client size in global compositor co-ordinates KWin wants to deal with the post-scaled down client size, not the texture size." to "Set m_client size in global compositor co-ordinates". davidedmun

[Differential] [Updated, 56 lines] D3495: Scale QPainter x11 windowed backend

2016-12-01 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 8683. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Add unit test REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3495?vs=8503&id=8683 REVISION DETAIL https://

[Differential] [Request, 13 lines] D3562: [Task Manager] Create toolTipDelegate on demand

2016-12-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ToolTipTelegate is quite complex an

[Differential] [Updated, 506 lines] D3561: make the logic of PageRow a ListView

2016-12-01 Thread mart (Marco Martin)
mart updated this revision to Diff 8680. mart added a comment. - remove some redundant properties REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3561?vs=8679&id=8680 BRANCH phab/listviewrow REVISION DETAIL https://phabricator.kde.org/D3561 AFFECTED

[Differential] [Updated, 502 lines] D3561: make the logic of PageRow a ListView

2016-12-01 Thread mart (Marco Martin)
mart updated this revision to Diff 8679. mart added a comment. - refactor delegate of ApplicationHeader REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3561?vs=8678&id=8679 BRANCH phab/listviewrow REVISION DETAIL https://phabricator.kde.org/D3561 AFF

[Differential] [Request, 294 lines] D3561: make the logic of PageRow a ListView

2016-12-01 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it implements internally things like snapping and layouting makes the qml code significantly simpler it nee

[Differential] [Request, 25 lines] D3560: [Notifications] Tighten layout

2016-12-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Our notification popups

[Differential] [Request, 7 lines] D3559: [Notification Popup] Clear notification data after popup closed

2016-12-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There's no point in keeping around the

[Differential] [Closed] D3549: [Lock Screen] Add keyboard icon for keyboard layout switcher

2016-12-01 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b34601f0ef1a: [Lock Screen] Add keyboard icon for keyboard layout switcher (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3549?vs=86

[Differential] [Updated, 4 lines] D3552: Remove quoting from kscreen-console json-output (Bug 354534)

2016-12-01 Thread jbraun (Jan-Matthias Braun)
jbraun removed R104 KScreen as the repository for this revision. jbraun updated this revision to Diff 8674. jbraun added a comment. Of course, that's easily done. :-) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3552?vs=8646&id=8674 REVISION DETAIL https://phabricator.kde.org/D3

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

2016-12-01 Thread Raman Gupta
https://bugs.kde.org/show_bug.cgi?id=357288 Raman Gupta changed: What|Removed |Added Version|5.7.3 |5.8.4 --- Comment #9 from Raman Gupta --- Still

[Differential] [Closed] D3557: [Notifications] Default initialize notificationProperties as empty object

2016-12-01 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f78c98068a34: [Notifications] Default initialize notificationProperties as empty object (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.or

[Differential] [Closed] D3558: Make properties readonly when possible

2016-12-01 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:463660b4aadc: Make properties readonly when possible (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3558?vs=8671&id=8672 REVISION DETAIL htt

[Differential] [Accepted] D3557: [Notifications] Default initialize notificationProperties as empty object

2016-12-01 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3557 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3558: Make properties readonly when possible

2016-12-01 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3558 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: pl

[Differential] [Request, 4 lines] D3558: Make properties readonly when possible

2016-12-01 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY R169 Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3558 AFFECTED FILES sr

[Differential] [Closed] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:aabcb7b0d6e1: Drop resize animation when adding pages (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3538?vs=8668&id=8670 REVISION DETAIL ht

[Differential] [Requested Changes To] D3552: Remove quoting from kscreen-console json-output (Bug 354534)

2016-12-01 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added a comment. This revision now requires changes to proceed. Idea in general looks good, I'd rather use QTextStream than std though. Can you change that? INLINE COMMENTS > console.cpp:185 > QJsonDocument doc(KScreen::ConfigSerializer::s

[Differential] [Updated] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez)
apol marked an inline comment as done. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Accepted] D3538: Drop resize animation when adding pages

2016-12-01 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: je

[Differential] [Updated, 29 lines] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 8668. apol added a comment. Fix patch REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3538?vs=8667&id=8668 BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3538 AFFECTED FILES src/controls/templa

[Differential] [Updated, 3,549 lines] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 8667. apol added a comment. Fix patch REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3538?vs=8666&id=8667 REVISION DETAIL https://phabricator.kde.org/D3538 AFFECTED FILES CMakeLists.txt KF5Kirigami2Config.cmake.in

[Differential] [Updated, 3,388 lines] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 8666. apol added a comment. Remove Timer REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3538?vs=8604&id=8666 BRANCH arcpatch-D3538 REVISION DETAIL https://phabricator.kde.org/D3538 AFFECTED FILES CMakeLists.txt

[Differential] [Request, 15 lines] D3557: [Notifications] Default initialize notificationProperties as empty object

2016-12-01 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Avoids accessing the object twice for

Re: Review Request 129586: [KNotification] Allow annotating notifications with URLs

2016-12-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129586/ --- (Updated Dec. 1, 2016, 12:41 p.m.) Status -- This change has been ma

[Differential] [Closed] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:3c1679ba6468: [Notifications] Show interactive thumbnails on notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3539?vs=8663&id=8664#toc REPOSITORY R120 Plas

[Differential] [Accepted] D3553: Fix 2 RTL bugs

2016-12-01 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3553 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ttv20, #plasma_wor

[Differential] [Accepted] D3549: [Lock Screen] Add keyboard icon for keyboard layout switcher

2016-12-01 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3549 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Updated, 446 lines] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 8663. broulik added a comment. - "Expire" notification when clicking a URL This will cause the popup to close properly (previous patch would just hide the window but not "free" the dialog) but it will be kept in the history if it is a persistent noti

[Differential] [Accepted] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

Re: Review Request 129586: [KNotification] Allow annotating notifications with URLs

2016-12-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129586/#review101193 --- Ship it! Ship It! - Marco Martin On Nov. 29, 2016, 4:4

[Differential] [Updated, 444 lines] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. broulik updated this revision to Diff 8662. broulik added a comment. - Put thumbnail strip behind a Loader - Make clicking the thumbnails actually work (horrible hack because of the MouseEventListener we have in the popup) - Make thumbnails

[Differential] [Updated] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik)
broulik marked an inline comment as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: mart, colomar, plasma-devel, lesliezhai, al

Request to port plasma for zenfone 2 laser.

2016-12-01 Thread sunil polavarapu
First of all congratulations to all of your team, You have made a another platform called plasma mobile which is based on linux..feeling it's going to become very popular in future like Android OS . So i'm requesting your team to port this plasma mobile to Zenfone 2 laser variants and hope you pe

How to run plasma mobile

2016-12-01 Thread Andy B
Hey team, I wanted to know what I need to do in order to run plasma mobile using virtualbox. I run it but I get a black screen using the latest x86 image. Thank you,