ttv20 created this revision.
ttv20 added a reviewer: Plasma: Workspaces.
ttv20 set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Bug 364778: (DashboardRepresentati
broulik added a comment.
Thanks for your patch! Instead of converting to an std::string you could try
qDebug().noquote() << doc.toJson();
[1] https://doc.qt.io/qt-5/qdebug.html#noquote
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D3552
EMAIL PREFERENCES
jbraun created this revision.
jbraun added a reviewer: sebas.
jbraun set the repository for this revision to R104 KScreen.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As the creator of Bug 354534 noted, the output of
davidedmundson added a comment.
To expand on the DBus problem:
The connection object resides in a thread; but emits stuff from the main
thread.
DBus is generally thread safe, but QDBusAbstractAdaptor uses sender() in
relaying so isn't.
add in a bouncer, things work nicely:
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> connection.cpp:159
>QStringLiteral("notifyChange"),
> this,
graesslin added a comment.
I like it - and as I have read the bug reports I am for 5.8 branch.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3549
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasm
mart added a comment.
I like the idea, but i am a bit concerned about the added complexity, that
may be worked around?
INLINE COMMENTS
> NotificationItem.qml:318
> +
> +ListView {
> +id: previewList
the main concern i have, is the general weight of QML.
this is going to
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
I've quite often seen p
davidedmundson added a comment.
sure, don't commit the broken version, commit this and we can add the change
signals afterwards
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3479
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: su
subdiff added a comment.
In https://phabricator.kde.org/D3479#66129, @graesslin wrote:
> @davidedmundson do you have any further comments on the DBus usage? if not,
I would give it an "Accepted".
At the moment @davidedmundson helps me with the dbus signals. I tried to
implement
graesslin added a comment.
@davidedmundson do you have any further comments on the DBus usage? if not, I
would give it an "Accepted".
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3479
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:7ce5f12c84f9: Introduce a first test for PageRow
(authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3541?vs=8613&id=8634
REVISION DETAIL
https:/
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
mart/Kirigami2
REVISION DETAIL
https://phabricator.kde.org/D3541
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc: pl
mart added inline comments.
INLINE COMMENTS
> PageRow.qml:429
> id: stateTimer
> -interval: 150
> +interval: 0
> onTriggered: container.state = container.pendingState
if the interval went to 0, then couldn't be possible to remove
aacid added a comment.
In https://phabricator.kde.org/D3530#66090, @mart wrote:
> In https://phabricator.kde.org/D3530#65734, @aacid wrote:
>
> > > Dolphin in other environments currently gives a big error until you
install plasma-workspace, which defeats the point of the split.
> >
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:c156d251ec06: [ConnectionItem] Allow copying network
details to clipboard (authored by broulik).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
mart added a comment.
In https://phabricator.kde.org/D3530#65734, @aacid wrote:
> > Dolphin in other environments currently gives a big error until you
install plasma-workspace, which defeats the point of the split.
>
> Maybe Dolphin needs to be patched not to assume remote:/ will alw
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D3545
EMAIL PREFERENCES
https://phabricator.kde.org/settings
broulik created this revision.
broulik added reviewers: Plasma, jgrulich, Plasma: Design.
broulik set the repository for this revision to R116 Plasma Network Management
Applet.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMAR
broulik updated the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3539
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, a
broulik updated this revision to Diff 8625.
broulik added a comment.
- Reduce preview area in height (now 1/3 of the dialog width instead of 1/2
as before – I tried 1/4 but given the aspect ratio it would make the preview
hard to see imho)
- When there is one item but a preview could not be
21 matches
Mail list logo
