Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/ --- (Updated Nov. 11, 2016, 11:25 p.m.) Status -- This change has been m

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review100794 --- Ship it! I think it's safe enough to import it. There is

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review100793 --- Ship it! Then let's go for it. We have 3 weeks until the

[Differential] [Commented On] D3344: Remove deprecated --shut-up start flag

tigerfoot added a comment. Thanks all, this confirm my indefectible faith in opensource, and how great is kde :-) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3344 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Accepted] D3344: Remove deprecated --shut-up start flag

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3344 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

Review Request 129380: remove kcm docbooks which have their code in other repos from plasma-desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129380/ --- Review request for Documentation, KDE Frameworks and Plasma. Bugs: 350619

[Differential] [Commented On] D3344: Remove deprecated --shut-up start flag

cfeck added a comment. Looking at main.cpp of plasmashell this option is indeed no longer used. (Some other options are also no longer used, so they should also be marked as deprecated, but I guess that's material for a new patch). REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION

[Differential] [Updated] D3344: Remove deprecated --shut-up start flag

tigerfoot added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3344 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: tigerfoot, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterber

[Differential] [Request, 2 lines] D3344: Remove deprecated --shut-up start flag

tigerfoot created this revision. tigerfoot set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Actually the plasma-workspace.desktop launcher has stil

[Differential] [Updated] D3282: add backgroundHints for the panel View (disable/enable Effects and shadows for a Panel)

mvourlakos added a comment. Thank u!!! Unfortunately I dont have commit access yet.. I am going to request a developer acount afterwards... Is it possible for someone to commit this patch and https://phabricator.kde.org/D3283? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION

[Differential] [Accepted] D3283: Hide Background for Panel when backgroundHints are used

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3283 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson,

[Differential] [Accepted] D3282: add backgroundHints for the panel View (disable/enable Effects and shadows for a Panel)

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3282 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmund

Re: Review Request 129377: Remove trash kcm docbook from kio-extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129377/#review100783 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 11, 201

[Discussion] - Plasma Panels Future Enhancements?

Hello everyone, I am working in the plasma panels codepage these days, trying to enhance their features and I would like your opinion in some aspects of it. This effort is based a lot in the Now Dock Panel and its needs. I have sent some feature requests and lately I have sent some patches fo

Re: Review Request 129377: Remove trash kcm docbook from kio-extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129377/ --- (Updated Nov. 11, 2016, 4:12 nachm.) Review request for Documentation, Pl

Review Request 129377: Remove trash kcm docbook from kio-extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129377/ --- Review request for Documentation, Plasma and Aleix Pol Gonzalez. Reposito

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/ --- (Updated Nov. 11, 2016, 3:39 nachm.) Review request for Documentation, KD

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/ --- (Updated Nov. 11, 2016, 3:38 nachm.) Review request for Documentation, Lo

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

> On Nov. 11, 2016, 1:51 nachm., Luigi Toscano wrote: > > If I understand it correctly, the review include two separate change > > (import + fixes), is it correct? Then it's fine by me (pending confirmation > > for the shipit), the changes are fine and we can refine it later (better > > than t

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

> On Nov. 11, 2016, 1:51 nachm., Luigi Toscano wrote: > > If I understand it correctly, the review include two separate change > > (import + fixes), is it correct? Then it's fine by me (pending confirmation > > for the shipit), the changes are fine and we can refine it later (better > > than t

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review100778 --- If I understand it correctly, the review include two separat

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review100777 --- If I understand it correctly, the review include two separat

[Differential] [Updated, 98 lines] D3210: make scrollbar size configurable

mart updated this revision to Diff 8094. mart added a comment. - tie the new scrollbar style to animations enabled REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=8093&id=8094 BRANCH arcpatch-D3210 REVISION DETAIL https://phabricator.kde.org/

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. done. It looks maybe a bit too "magic", but may be a good thing REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3210 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #vdg, hpereiradacosta Cc:

[Differential] [Updated, 102 lines] D3210: make scrollbar size configurable

mart updated this revision to Diff 8093. mart added a comment. - tie the new scrollbar style to animations enabled REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=7870&id=8093 BRANCH arcpatch-D3210 REVISION DETAIL https://phabricator.kde.org/

[Differential] [Closed] D3306: Convert virtual backend to per screen rendering

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN1776b5f92788: Convert virtual backend to per screen rendering (authored by davidedmundson). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3306?vs=8037&id=8091 REVIS

[Differential] [Accepted] D3338: [effects] Save zoom settings using kcfg generated class

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH zoom-save-config REVISION DETAIL https://phabricator.kde.org/D3338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3340: [effects] Clean up saving of DesktopGrid config

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH desktop-grid-drop-double-save REVISION DETAIL https://phabricator.kde.org/D3340 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D3306: Convert virtual backend to per screen rendering

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D3306 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3306: Convert virtual backend to per screen rendering

davidedmundson added a comment. > does the sceneqpaintertest pass? That's probably the only one which could be affected by this change. Yes, that passes REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3306 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Accepted] D3339: [effects] Drop loading shadow config from MagicLamp

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. +1 for spring cleanings REPOSITORY rKWIN KWin BRANCH magiclamp-drop-shadow-config REVISION DETAIL https://phabricator.kde.org/D3339 EMAIL PREFERENCES http

[Differential] [Accepted] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3330 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik

[Differential] [Request, 66 lines] D3341: add connector name to screen model

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY to uniquely identify screens (in QScreen::name()) add the conenctor name and id (such as HDMI-A-1) to the mode

[Differential] [Accepted] D3327: VirtualDesktopGrid operates on VirtualDesktop objects

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH vd-grid REVISION DETAIL https://phabricator.kde.org/D3327 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland,

[Differential] [Request, 4 lines] D3340: [effects] Clean up saving of DesktopGrid config

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The DesktopNameAlignment was once set through the kcfg generated file and once manually. We don

[Differential] [Changed Subscribers] D3336: Pass function ptr to resolve glFunctions to initGL

broulik added inline comments. INLINE COMMENTS > kwinglutils_funcs.cpp:26 > // Resolves given function, using getProcAddress > -#define GL_RESOLVE( function ) \ > -if (platformInterface == GlxPlatformInterface) \ > -function = (function ## _func)getProcAddress( #function ); \ > -

[Differential] [Request, 16 lines] D3339: [effects] Drop loading shadow config from MagicLamp

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This has basically been dead code for ages. The Shadow effect got dropped in an early 4.x versi

[Differential] [Request, 10 lines] D3338: [effects] Save zoom settings using kcfg generated class

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY We have the kcfg generated settings object, so no need to manually write the config save code f

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/ --- (Updated Nov. 11, 2016, 9:31 vorm.) Review request for Documentation, KDE

[Differential] [Request, 67 lines] D3337: Remove KWin::display from kwinglobals

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY And finally nothing inside libkwineffects, libkwinglutils, libkwin

[Differential] [Updated] D3336: Pass function ptr to resolve glFunctions to initGL

graesslin added a dependent revision: D3337: Remove KWin::display from kwinglobals. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3336 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-d

[Differential] [Updated] D3337: Remove KWin::display from kwinglobals

graesslin added a dependency: D3336: Pass function ptr to resolve glFunctions to initGL. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: pla

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/ --- (Updated Nov. 11, 2016, 9:02 vorm.) Review request for Documentation, Loc

[Differential] [Updated] D3335: Move resolving glxSwapIntervalMesa into platform plugin

graesslin added a dependent revision: D3336: Pass function ptr to resolve glFunctions to initGL. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3335 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland

[Differential] [Updated] D3336: Pass function ptr to resolve glFunctions to initGL

graesslin added a dependency: D3335: Move resolving glxSwapIntervalMesa into platform plugin. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3336 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc

[Differential] [Request, 63 lines] D3336: Pass function ptr to resolve glFunctions to initGL

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY KWin still resolves some OpenGL function pointers. For that it needs