[Differential] [Updated] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

subdiff added a reviewer: graesslin. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3078 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, graesslin Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jen

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/ --- (Updated Okt. 17, 2016, 8:43 vorm.) Review request for Plasma and Martin

[Differential] [Request, 2 lines] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

subdiff created this revision. subdiff added reviewers: graesslin, broulik. subdiff added a subscriber: Plasma. subdiff set the repository for this revision to rPLASMADESKTOP Plasma Desktop. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY

[Differential] [Commented On] D3064: Port away from KDELibs4Support

davidk added a comment. Abandoned, because it includes stuff which should be in it's own RR. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3064 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk Cc: plasma-deve

[Differential] [Updated, 208 lines] D3019: [kstyle] Implement window moving on Wayland

graesslin updated this revision to Diff 7443. graesslin added a comment. Moved the hasPointer lambda into an own method for better readability and less nesting. The registry interfacesAnnounced is still a lambda to not need to keep the variable around and the handling of the pointer bu

[Differential] [Changed Policy] D3064: Port away from KDELibs4Support

davidk changed the visibility from "No One" to "All Users". REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3064 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk Cc: plasma-devel, lesliezhai, ali-mohamed, jensreute

[Differential] [Request, 25 lines] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)

subdiff created this revision. subdiff added a subscriber: Plasma. subdiff set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. subdiff added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add new DBus method for toggling the l

[Differential] [Closed] D3044: Set color scheme X property in the X11Integration

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONe47245f96ed1: Set color scheme X property in the X11Integration (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDAT

[Differential] [Closed] D3046: Pass color scheme hint to Wayland compositor using window property

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONf8a0f8c0c82e: Pass color scheme hint to Wayland compositor using window property (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES

[Differential] [Closed] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINe9d20b80e9a7: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2953?vs=7337&id=74

Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/ --- Review request for Plasma. Bugs: 367685 http://bugs.kde.org/show_bug.

Info about data from store.kde.org + kdepim

Hi, Before store.kde.org, kdepim ues knewstuff to get data from server. We had for example kmail header theme on old server. But now in new server I can't see them. Do you have an idea why we don't get them now ? Thanks for info. Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE

[Differential] [Closed] D3015: Fix shortcut triggering with shift+letter

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN78a2732a9a42: Fix shortcut triggering with shift+letter (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3015?vs=7293&id=7436 REVISION DETAIL

[Differential] [Closed] D2943: Support LEDs in Xkb and libinput

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4c7752c965ab: Support LEDs in Xkb and libinput (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2943?vs=7112&id=7434 REVISION DETAIL https:/

[Differential] [Closed] D2996: [kwinrules] Hide all autogroup related widgets

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINdb95b96854e5: [kwinrules] Hide all autogroup related widgets (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2996?vs=7240&id=7435 REVISION DE

[Differential] [Closed] D3016: [server] Send pointer events to all wl_pointer resources of a client

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND79cf85cf90f9: [server] Send pointer events to all wl_pointer resources of a client (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Closed] D3018: [client] Add methods to get ShellSurface from a QWindow

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND75478ec7472a: [client] Add methods to get ShellSurface from a QWindow (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3018?vs=7298

[Differential] [Closed] D3045: [server] Implement the generic window property in QtSurfaceExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDfe95610ac28c: [server] Implement the generic window property in QtSurfaceExtension (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Closed] D3049: Support passing generic QIcon through PlasmaWindow interface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDbd2b966523e7: Support passing generic QIcon through PlasmaWindow interface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3049?vs

[Differential] [Commented On] D2931: Destroy DebugConsole on hide of QWindow

graesslin added inline comments. INLINE COMMENTS > luebking wrote in debug_console.cpp:547 > Wouldn't that prevent the QWindow signal just as well? Maybe, maybe not. That's the point I haven't investigated it and it might be that an additional call is required for QWidget to be supported. REPO

Re: Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/#review100058 --- CMakeLists.txt (line 47)

[Breeze] [Bug 370981] New: Can't enter LUKS password

https://bugs.kde.org/show_bug.cgi?id=370981 Bug ID: 370981 Summary: Can't enter LUKS password Product: Breeze Version: 5.8.0 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priorit

Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review100053 --- Maybe plasma people would be more confortable if the "Todo n

[Powerdevil] [Bug 370966] Battery not recognized

https://bugs.kde.org/show_bug.cgi?id=370966 --- Comment #2 from hrvo...@jankovci.net --- 'Unfortunatelly' after restart the battery is showing. If it happens again I will run upower -d. Here it is for now: Device: /org/freedesktop/UPower/devices/line_power_AC native-path: AC power su

[Powerdevil] [Bug 370966] Battery not recognized

https://bugs.kde.org/show_bug.cgi?id=370966 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|---

[Powerdevil] [Bug 370966] New: Battery not recognized

https://bugs.kde.org/show_bug.cgi?id=370966 Bug ID: 370966 Summary: Battery not recognized Product: Powerdevil Version: 5.7.5 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal

[Differential] [Commented On] D2931: Destroy DebugConsole on hide of QWindow

luebking added inline comments. INLINE COMMENTS > graesslin wrote in debug_console.cpp:547 > It might be a bug in KWin's QPA, so I wouldn't blame Qt here (yet). Wouldn't that prevent the QWindow signal just as well? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2931 E

[Differential] [Commented On] D3037: Support docks which take input

luebking added a comment. In https://phabricator.kde.org/D3037#56298, @graesslin wrote: > > I don't see any real world cases where that would be needed. Embedded runners/search widgets (pretty famous item on KDE3 times, no idea whether it's relevant) "You have been

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

graesslin added inline comments. INLINE COMMENTS > usta wrote in kwaylandintegration.cpp:57 > #include removed and #include isn't this also should be change ? no? We try to not change unrelated code. The include of QGuiApplication is due to the usage of QGuiApplication::topLevelWindows. For t

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

usta added inline comments. INLINE COMMENTS > graesslin wrote in kwaylandintegration.cpp:57 > this is completely unrelated code not touched in this change. #include removed and #include https://phabricator.kde.org/D3046 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Commented On] D3051: [applets/notification] Add nullptr check

graesslin added a comment. In https://phabricator.kde.org/D3051#56876, @sebas wrote: > So, warn, but don't crash? It might be that this was a local qt self-destruction event. I recompiled Qt on Thursday and afterwards everything was broken, especially QtQuick. It might be that th

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

graesslin added inline comments. INLINE COMMENTS > usta wrote in kwaylandintegration.cpp:57 > QCoreApplication -> QGuiApplication this is completely unrelated code not touched in this change. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH color-scheme-wayla

[Differential] [Commented On] D3019: [kstyle] Implement window moving on Wayland

graesslin added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezewindowmanager.cpp:264 > mmm. I know delta functions are handy, but isn't this one a tad complicated ? > Personnally I find this code quite hard to read. (especially the sequence of > closing }s and )s later on ...

[Differential] [Commented On] D3019: [kstyle] Implement window moving on Wayland

graesslin added a comment. In https://phabricator.kde.org/D3019#56891, @hpereiradacosta wrote: > I'm using kwayland from git master. Are there some commits missing ? yes, see the linked dependencies. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3019

[Differential] [Commented On] D3019: [kstyle] Implement window moving on Wayland

hpereiradacosta added inline comments. INLINE COMMENTS > breezewindowmanager.cpp:264 > +[registry, this] { > +const auto interface = registry->interface( > Registry::Interface::Seat ); > +if( interface.name != 0 ) { mmm. I know delta functions are han

[Differential] [Updated] D3019: [kstyle] Implement window moving on Wayland

hpereiradacosta added a comment. From here, code does not compile. Maybe I am missing something: /home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp:874:29: error: ‘fromWindow’ is not a member of ‘KWayland::Client::ShellSurface’ I'm using kwayland from git master

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

usta added a comment. In line 57 QCoreApplication -> QGuiApplication INLINE COMMENTS > kwaylandintegration.cpp:57 > qputenv("QT_WAYLAND_DISABLE_WINDOWDECORATION", "1"); > QCoreApplication::instance()->installEventFilter(this); > } QCoreApplicat

[Differential] [Accepted] D3059: [effects] Make screenshot effect work with multiple output rendering

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH screenshot-multiple-output REVISION DETAIL https://phabricator.kde.org/D3059 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D3058: Pass the current output geometry to ScreenPaintData

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH screen-paint-data-current-output REVISION DETAIL https://phabricator.kde.org/D3058 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Accepted] D3056: Fix glBlitFramebuffer for per-output rendering

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH render-target-geometry REVISION DETAIL https://phabricator.kde.org/D3056 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Commented On] D3051: [applets/notification] Add nullptr check

sebas added a comment. So, warn, but don't crash? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3051 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, broulik Cc: sebas, plasma-devel, lesl

[Differential] [Accepted] D3047: Support custom color scheme for Wayland windows

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH color-scheme-wayland REVISION DETAIL https://phabricator.kde.org/D3047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Accepted] D3046: Pass color scheme hint to Wayland compositor using window property

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH color-scheme-wayland REVISION DETAIL https://phabricator.kde.org/D3046 EMAIL PREFERENCES https://p

[Differential] [Accepted] D3045: [server] Implement the generic window property in QtSurfaceExtension

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH extended-surface-property REVISION DETAIL https://phabricator.kde.org/D3045 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Accepted] D3044: Set color scheme X property in the X11Integration

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH color-scheme-atom REVISION DETAIL https://phabricator.kde.org/D3044 EMAIL PREFERENCES https://phab

[Differential] [Accepted] D3037: Support docks which take input

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH dock-wants-input REVISION DETAIL https://phabricator.kde.org/D3037 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ T

[Differential] [Accepted] D3036: Support forceActiveWindow for Panels

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland BRANCH force-active-window-panel REVISION DETAIL https://phabricator.kde.org/D3036 EMAIL PREFERENCES

[Differential] [Accepted] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Other than @subdiff 's comment, it looks good to me. INLINE COMMENTS > subdiff wrote in plasma-shell.xml:373 > Use another name instead of "skip" (copy paste fr

[Differential] [Accepted] D3023: Set icon to wayland if desktop file is not found

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rKWIN KWin BRANCH wayland-icon-name REVISION DETAIL https://phabricator.kde.org/D3023 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Commented On] D3019: [kstyle] Implement window moving on Wayland

sebas added a comment. Looks good from my side. Let's have @hpereiradacosta have a look as well, though. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3019 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_o

[Differential] [Accepted] D3018: [client] Add methods to get ShellSurface from a QWindow

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rKWAYLAND KWayland BRANCH shell-surface-from-qt REVISION DETAIL https://phabricator.kde.org/D3018 EMAIL PREFERENCES https://pha

[Differential] [Accepted] D3016: [server] Send pointer events to all wl_pointer resources of a client

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rKWAYLAND KWayland BRANCH server-seat-pointers REVISION DETAIL https://phabricator.kde.org/D3016 EMAIL PREFERENCES https://phab

[Differential] [Accepted] D3015: Fix shortcut triggering with shift+letter

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY rKWIN KWin BRANCH consumed-mods-ignore-letters REVISION DETAIL https://phabricator.kde.org/D3015 EMAIL PREFERENCES https://pha

[Differential] [Accepted] D2996: [kwinrules] Hide all autogroup related widgets

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH rules-autogroup-hide-5.8 REVISION DETAIL https://phabricator.kde.org/D2996 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D2943: Support LEDs in Xkb and libinput

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rKWIN KWin BRANCH keyboard-leds-5.8 REVISION DETAIL https://phabricator.kde.org/D2943 EMAIL PREFERENCES https://phabricator.kde

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #39 from adam.miku...@centrum.cz --- Hi, I'm happy to report that the problem seems to be finally fixed with plasma 5.8 (just confirmed by my experience, not changelog). -- You are receiving this mail because: You are the assignee for the b

Re: [Differential] [Request, 161 lines] D3064: Port away from KDELibs4Support

Hey, Sorry, thats my fault. I didn't get the differences between Reviewboard and Phabricator, and included things into the review, which shouldn't be there. When I tried to abandon the revision, I restricted the access to myself. I just uploaded a new RR which should work fine. Am Sonntag, 16.

[Differential] [Request, 125 lines] D3071: Port away from KDELibs4Support

davidk created this revision. davidk added a reviewer: Plasma. davidk added a subscriber: plasma-devel. davidk added a project: Plasma. TEST PLAN Builds and works fine, including the password dialog. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.

Re: [Differential] [Request, 161 lines] D3064: Port away from KDELibs4Support

I get an error trying to view this. "You Shall Not Pass: Restricted Differential Revision" I can view others fine. Does anyone else have this problem? Bshah, can you see if user-manager is set up differently?

Re: Review Request 129187: Fix dangling pointer in KPackageJob

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129187/ --- (Updated Oct. 16, 2016, 12:13 p.m.) Status -- This change has been m

[Differential] [Accepted] D3050: Use new PlasmaWindowInterface::setIcon

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. This revision is now accepted and ready to land. Tested with Inkscape, Chrome, Gimp. Works fine, for Gimp (tested only in single-window mode) it needed some time to show the app/icon in the taskbar, bu

[Differential] [Accepted] D3049: Support passing generic QIcon through PlasmaWindow interface

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. Told you, I had problems compiling at first. Works now for unknown reason and icons are displayed together with https://phabricator.kde.org/D3050. INLINE COMMENTS > graesslin wrote in plasmawindowmana