---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/
---
(Updated Sept. 29, 2016, 11:50 p.m.)
Review request for KDE Frameworks an
> On Sept. 29, 2016, 8:25 a.m., Marco Martin wrote:
> > are you sure they are completely interchangeable? (would have to have an
> > ifdef otherwise)
they're not completely intechangable normally, but for this particular case it
seems fine.
I've just filled in the Testing Done propery.
This
> Plasma 5.8 tars are available on depot for packaging, release is on Tuesday
\o/
Is there info about the last commit id for the tars?
Cheers,
Ivan
--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3 45DF C9C5 77AF 0A37 240A
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The current code registers the session bus *after* app->exec() this
effectively means it won'
This revision was automatically updated to reflect the committed changes.
Closed by commit rLIBKSCREEN097956b704f8: add flag to for per-display scaling
(authored by sebas).
REPOSITORY
rLIBKSCREEN KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2866?vs=6966&id=6992
REV
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 29 Sep 2016 13:42:56 +
Build duration: 8 min 15 sec
CHANGE SET
Revision f49216b7211026bfb08d8
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 29 Sep 2016 13:42:56 +
Build duration: 8 min 15 sec
CHANGE SET
Revision f49216b7211026bfb08d8
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPf49216b72110: Fixing loading for the wallpaper
thumbnails in the activity switcher (authored by ivan).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricat
ivan updated this revision to Diff 6990.
ivan added a comment.
Removed debugging output before landing
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2886?vs=6989&id=6990
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D
On Thursday 29 September 2016 14:08:10 Jonathan Riddell wrote:
> Plasma 5.8 tars are available on depot for packaging, release is on Tuesday
Cheers!
\o/
--
Marco Martin
Plasma 5.8 tars are available on depot for packaging, release is on Tuesday
Jonathan
mart accepted this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D2886
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D2886
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan,
ivan updated this revision to Diff 6989.
ivan added a comment.
With some debugging output
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2886?vs=6988&id=6989
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D2886
AFFECTE
mart added a comment.
In https://phabricator.kde.org/D2886#53635, @ivan wrote:
> Note: It still does reparseConfiguration() - it does not work as expected
otherwise.
I'm in favor of the patch in general..
If the file was changed by another process or somewhere else in the same n
mart added inline comments.
INLINE COMMENTS
> widgetexplorer.cpp:138
> for (auto data : list) {
> const KPluginInfo info(data);
> if (!info.isValid()) {
this shouldn't be necessary anymore as data should be a kplugininfo now?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
ivan added a comment.
Note: It still does reparseConfiguration() - it does not work as expected
otherwise.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2886
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: iva
ivan abandoned this revision.
ivan added a comment.
New patch is here: https://phabricator.kde.org/D2886
(it is no longer about config file settling, so I opened a separate one)
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2820
EMAIL PREFEREN
ivan created this revision.
ivan added reviewers: Plasma, davidedmundson, mart.
ivan added a subscriber: plasma-devel.
ivan added a project: Plasma.
REVISION SUMMARY
- Using shared config object for retrieving the wallpaper
- Adding preference for taking the wallpaper from the containment with
ivan added a comment.
It works without the timer, but not without reparseConfiguration.
I need to see why.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2820
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP44866deb0261: use KPluginSelector to enable
runners (authored by mart).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2872?vs=6952&id=698
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEad9eda5d49f2: kconfig update script for
enabled runners (authored by mart).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2873?vs=6
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEe496a2874324: avoid duplicate desktopviews on
first startup (authored by mart).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2885?
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
phab/no2desktops
REVISION DETAIL
https://phabricator.kde.org/D2885
EMAIL PREFERENCES
https://phabr
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rLIBKSCREEN KScreen Library
BRANCH
sebas/perdisplayscalingflag
REVISION DETAIL
https://phabricator.kde.org/D2866
EMAIL PREFERENCES
https://
mart updated the summary for this revision.
mart updated the test plan for this revision.
mart added a reviewer: Plasma.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2885
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferen
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
on first startup all the desktop views already exist after the
script has been executed, so check the screen doesn't already have
a view for t
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 29 Sep 2016 10:18:13 +
Build duration: 2 min 25 sec
CHANGE SET
Revision ac439ffd687769b4c6d2c
broulik added inline comments.
INLINE COMMENTS
> kcm.cpp:47
> : KCModule(parent, args)
> -, m_config(QStringLiteral("krunnerrc"))
> -, m_configGroup(m_config.group("PlasmaRunnerManager"))
> +, m_config("krunnerrc")
> {
Are you even using that still? All I see is a KSharedConfig
https://bugs.kde.org/show_bug.cgi?id=369520
Bug ID: 369520
Summary: FISH: directories are mistaken for files and
vice-versa
Product: kio-extras
Version: unspecified
Platform: Gentoo Packages
OS: Linux
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP6f8a26c7a7ac: [Kickoff] Draw FrameSvg behind
icon preview (authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2884?vs=69
mart accepted this revision.
mart added a reviewer: mart.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2884
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, #plasma, davidedmundson, mart
C
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Nice
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2884
EMAIL PREFERENCES
htt
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This ensures we
broulik updated the test plan for this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2884
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, al
Hi,
white on light gray is what happens when using Plasma icon item (which follows
the Plasma theme) in a dialog that uses application theme. (I did that..)
Perhaps instead of a regular button it could render a FrameSvg behind it (which
then would also use Plasma theme) to look more like a prev
didn't know that you can configure kickoff in this way.
the best solution would be if the background color is the kickoff
background color, than it would work in all themes.
Andreas_K
2016-09-22 19:01 GMT+02:00 John Salatas :
> Hi!
>
> My desktop is configured as follows:
> Look and Feel: Breez
Hi!
My desktop is configured as follows:
Look and Feel: Breeze
Desktop Theme: Breeze
Screenshot 1 shows Kickoff's Application Launcher Settings
Now I change Desktop Theme to Breeze Dark
Screenshot 2 shows Kickoff's Application Launcher Settings again.
As you can see the Icon (start-here-kde) a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/#review99654
---
are you sure they are completely interchangeable? (would have
39 matches
Mail list logo
