This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP8bfd1e94a57d: Prevent "TypeError: Cannot read
property 'Layout' of null" warning on… (authored by eliasp).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabr
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 24 Sep 2016 12:34:02 +
Build duration: 1 min 54 sec
CHANGE SET
Revision c9830d0ac6e55355161d3
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEdc1e6ae26073: warnings-- (authored by
davidedmundson).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2849?vs=6900&id=6911
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP5c966a42554f: Let kicker display executable
items instead of empty buttons. (authored by ochurlaud).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator
mart accepted this revision.
mart added a reviewer: mart.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2846
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ochurlaud, hein, #plasma, davidedmundson, mart
Cc: mart,
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2849
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefe
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2846
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ochurlaud, hein, #plasma, d
ochurlaud updated this revision to Diff 6909.
ochurlaud added a comment.
Use !contains() instead of index() == -1
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2846?vs=6906&id=6909
BRANCH
master
REVISION DETAIL
https://phabricator.kd
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Me neither :(
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2850
EMAIL PREFEREN
ochurlaud updated this revision to Diff 6906.
ochurlaud added a comment.
Check for type, as asked by Sho
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2846?vs=6896&id=6906
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28
eliasp added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Panel.qml:78
> in theory, this line should be doing that.
>
> Any idea why it isn't?
Unfortunately - no idea why it doesn't prevent that.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kd
davidedmundson added inline comments.
INLINE COMMENTS
> Panel.qml:78
> property: "length"
> when: containment
> value: {
in theory, this line should be doing that.
Any idea why it isn't?
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricato
davidedmundson closed this revision.
davidedmundson added a comment.
Submitted as
https://phabricator.kde.org/rPLASMADESKTOPc8d3546a9e3ea1dfdb1853a33172824e7ff46feb
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2847
EMAIL PREFERENCES
https://pha
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP5fe0c2398218: Don't load system apps model twice
(authored by davidedmundson).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2841?vs=6886
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP94a94548418e: Add kinfocenter to the computer
tab of Kickoff (authored by davidedmundson).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/369/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 24 Sep 2016 10:16:36 +
Build duration: 5 min 47 sec
CHANGE SET
Revision f7bba1ce7486ea7adc966854faa6167
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/369/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 24 Sep 2016 10:16:36 +
Build duration: 5 min 47 sec
CHANGE SET
Revision f7bba1ce7486ea7adc966854faa6167
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D2834
EMAIL PREFERENCES
https://phabricator
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPa544bd5c0ee8: Fix binding loop in pager
(authored by davidedmundson).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2848?vs=6898&id=6903
hein accepted this revision.
hein added a reviewer: hein.
hein added a comment.
This revision is now accepted and ready to land.
Thanks!
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2848
EMAIL PREFERENCES
https://phabricator.kde
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2847
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: fvogt, #
hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> recentusagemodel.cpp:175
>
> -if (!service || !service->isApplication()) {
> +if (!service || service->exec().isEmpty()) {
> return QVariant();
hein accepted this revision.
hein added a reviewer: hein.
hein added a comment.
IIRC there was a reason for this related to migrating from the legacy config,
where stuff had to be merged ... but since I didn't add a code comment to the
effect, oh well, let's try I guess.
REPOSITORY
rPLASMA
hein accepted this revision.
hein added a reviewer: hein.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2842
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, mart, #plasma, hein
Cc:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106911/#review99497
---
This is for kde-workspace which is now deprecated. Closing.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106911/
---
(Updated Sept. 24, 2016, 10:04 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129009/#review99496
---
I don't think we can try and "fix" application bugs in a libr
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/368/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 24 Sep 2016 09:52:00 +
Build duration: 45 sec
CHANGE SET
Revision a7b5856387ce35d132e61436b876d7120b4b0
eliasp created this revision.
eliasp added a reviewer: Plasma.
eliasp set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
eliasp added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When starting `plasmashell`, the following warnin
29 matches
Mail list logo
