[Differential] [Updated] D2693: Standardize Drawer width

2016-09-07 Thread mart (Marco Martin)
mart added a comment. Just want to give it a try on android then i'm happy :) REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2693 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: broulik, plasma-de

Re: Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

2016-09-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128856/ --- (Updated Sept. 7, 2016, 9:43 p.m.) Status -- This change has been ma

Howto start desktop/context menu in windowed mode for testing

2016-09-07 Thread Gregor Mi
Hi, I am trying to add a menu entry to the desktop context menu to open the "Display configuration" KCM. I found that this is a good place /kde/workspace/plasma-workspace/krunner/view.cpp because there is "Run Command..." and "Activities..." and I thought this might be a good place for the new

Re: Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

2016-09-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128856/#review98979 --- Other than that, LGTM. src/downloaddialog.h (line 126)

Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

2016-09-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128856/ --- Review request for Plasma, Aleix Pol Gonzalez, Kai Uwe Broulik, and David F

[Differential] [Commented On] D2693: Standardize Drawer width

2016-09-07 Thread apol (Aleix Pol Gonzalez)
apol added a comment. In https://phabricator.kde.org/D2693#50118, @broulik wrote: > I have to test it how it looks on a phone i agree on the concept, not sure on the implementation as it's potentially breaking on applications How do you foresee it breaking applications? It becomes

[Differential] [Updated] D2580: possible to use OverlaySheet with ListView

2016-09-07 Thread apol (Aleix Pol Gonzalez)
apol added a subscriber: colomar. apol added a comment. We've been looking into it with @colomar and we like how it works. We think it would be useful if we'd get a small margin on either side so that it's easy to close when we're half-way through the scrolling process. Other than that,

[Differential] [Commented On] D2693: Standardize Drawer width

2016-09-07 Thread broulik (Kai Uwe Broulik)
broulik added a comment. I have to test it how it looks on a phone i agree on the concept, not sure on the implementation as it's potentially breaking on applications REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2693 EMAIL PREFERENCES https://phabricator.

[Differential] [Request, 2 lines] D2693: Standardize Drawer width

2016-09-07 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it wider, not dependent in terms of the title size REPOSITORY rKIRIGAMI Kirigami BRANCH master

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

2016-09-07 Thread Ivan Čukić
ivan added a comment. I meant more of a single shortcut 'Meta+PlasmaKey' which focusses on plasma and shows the overlays. No further shortcuts needed. And this would be possible to generalize later to access systray applets, etc. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAI

Re: Review Request 128793: [kio_mtp] Improve warning message

2016-09-07 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128793/ --- (Updated Sept. 7, 2016, 10:35 a.m.) Review request for Plasma and KDE Usa

[Differential] [Accepted] D2691: [Touchpad plasmoid] Major cleanup

2016-09-07 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > touchpad.qml:37 > + > +Plasmoid.preferredRepresentation: Plasmoid.compactRepresentation > +Plasmoid.icon: touchpadEnabled ? "input-touch

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

2016-09-07 Thread broulik (Kai Uwe Broulik)
broulik added a comment. > Has the alternative of having a shortcut that shows up small 'hints' on the tasks - number or letter that should be pressed in order to activate the task been considered? I thought about, say, longpress Meta and it shows up the numbers but I have no clue how/i

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

2016-09-07 Thread Ivan Čukić
ivan added a comment. Has the alternative of having a shortcut that shows up small 'hints' on the tasks - number or letter that should be pressed in order to activate the task been considered? Like Konqueror and KMail had with the 'ctrl'? Along the lines of https://www.qutebrowser.o

[Differential] [Commented On] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

2016-09-07 Thread hein (Eike Hein)
hein added a comment. Sorry, got too enthusiastic with all the deleting maybe ;). Fixed now. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2677 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart, david

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

2016-09-07 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2680#49986, @hein wrote: > I feel like this could all be on the C++ side and driven by the constructors+destructors of the Backend class, keeping a static instance counter in there. It would cut down on the boilerplate and avoid expos

[Differential] [Accepted] D2690: [System Tray] Set applet status to RequiresAttention when popup is open

2016-09-07 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2690 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 154 lines] D2691: [Touchpad plasmoid] Major cleanup

2016-09-07 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Use the compa

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 315 - Still Unstable!

2016-09-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/315/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 07 Sep 2016 09:18:52 + Build duration: 9 min 47 sec CHANGE SET Revision 1f84a41c812a0805e3a94b68104a3d

[Differential] [Commented On] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

2016-09-07 Thread lbeltrame (Luca Beltrame)
lbeltrame added a comment. As many others have noted already, the .desktop file is missing in this diff, and that broke kdeplasma-addons build. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2677 EMAIL PREFERENCES https://phabricator.kde.org/set

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 314 - Still Unstable!

2016-09-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/314/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 07 Sep 2016 07:18:41 + Build duration: 8 min 56 sec CHANGE SET Revision 35802ab87d4edfde81f4be8a8874bf