[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2016-08-26 Thread Elvis Angelaccio via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #10 from Elvis Angelaccio --- (In reply to Elvis Angelaccio from comment #9) > sftp:// is also affected. Actually sftp is fine. I thought that kdeconnect was using sftp://, but instead it has its own kio slave, so I filed another report for

[Differential] [Request, 8 lines] D2596: [Colors KCM] Disable "Edit Scheme" button if cannot be edited

2016-08-26 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The default scheme cannot be e

[Differential] [Updated, 287 lines] D2595: Fix comic applet appearance

2016-08-26 Thread gladhorn (Frederik Gladhorn)
gladhorn updated this revision to Diff 6308. gladhorn added a comment. Testing arc diff update... Just a small improvement to the indentation look. REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2595?vs=6307&id=6308 BRANCH master REVIS

[Differential] [Request, 288 lines] D2595: Fix comic applet appearance

2016-08-26 Thread gladhorn (Frederik Gladhorn)
gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Move all the code that was supposed to be the applet into Plasmoid.fullReprensentation. Otherwise only the compact representation is shown

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 287 - Still Unstable!

2016-08-26 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/287/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 18:25:47 + Build duration: 14 min CHANGE SET Revision 97075f3a0f7323b11387fb2fa9658c409f5f

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 286 - Still Unstable!

2016-08-26 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/286/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 18:17:24 + Build duration: 5 min 41 sec CHANGE SET Revision bc3b11c0aa860b85fc4049beda8566

Re: Review Request 128770: Proofread solid-device-automounter kcm docbook to 5.7

2016-08-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128770/ --- (Updated Aug. 26, 2016, 11:24 p.m.) Status -- This change has been m

Re: Review Request 128769: Update solid-actions kcm docbook to 5.7

2016-08-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128769/ --- (Updated Aug. 26, 2016, 8:17 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 285 - Still Unstable!

2016-08-26 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/285/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 18:10:34 + Build duration: 5 min 58 sec CHANGE SET Revision 0b95dd333b07f7942f2d28d0aacf0e

Re: Review Request 128772: Proofread + update baloo kcm docbook

2016-08-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128772/ --- (Updated Aug. 26, 2016, 6:10 p.m.) Status -- This change has been ma

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2016-08-26 Thread Elvis Angelaccio via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #9 from Elvis Angelaccio --- sftp:// is also affected. -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Accepted] D2591: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height

2016-08-26 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart, #plasma, hein Cc: plasma-devel, lesliezhai

[Differential] [Commented On] D2594: Add new session button to SessionsModel

2016-08-26 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > mart wrote in CMakeLists.txt:1 > unrelated? I was introducting i18n into components/sessionsprivate which previously didn't have it I didn't want to make a new .pot for 2 words, so I moved the -DTRANSLATION_DOMAN and Messages.sh from co

[Differential] [Abandoned] D2462: Remove deprecated code in kscreenlocker theme

2016-08-26 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2462 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, graesslin Cc: mart, graesslin, plasma-devel, l

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread Thomas Lübking
luebking added a comment. They'll unredirect the window. The property is however not mandarory: "The compositing manager MAY bypass compositing for both fullscreen and non-fullscreen windows if bypassing is requested" (the supplemental "but MUST NOT bypass if it would cause differences f

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

[Differential] [Accepted] D2594: Add new session button to SessionsModel

2016-08-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:1 > +add_definitions(-DTRANSLATION_DOMAIN=\"plasmashellprivateplugin\") > + unrelated? > CMakeLists.txt:20 > KF5::ConfigGu

[Differential] [Request, 74 lines] D2594: Add new session button to SessionsModel

2016-08-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This (optionally) appends an entry to the SessionsModel to append a "New Session" option. The

[Differential] [Request, 18 lines] D2593: Unify looks of the GlobalDrawer

2016-08-26 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make sure we specify a sourceSize so that we can render svg images of any size. Make it possible to sp

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2584#48381, @broulik wrote: > Plasma is the only major desktop environment that still supports a non-composited uscase. Unity and Gnome cannot disable it in the first place. Oh, so they just ignore that request from applicat

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Anthony Fieroni
> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Plasma is the only major desktop environment that still supports a non-composited uscase. Unity and Gnome cannot disable it in the first place. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.or

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Actually, I'm not really convinced of this. Blocking compositing is done via an official, cross-desktop API, isn't it? It's not a KWin-specific feature, right? If so, then KWin should not go alone in offering this config option. If I'm an application developer and

[Differential] [Closed] D2592: Properly place the title in the layout

2016-08-26 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI47337e8b7c34: Properly place the title in the layout (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2592?vs=6302&id=6303 REVISION DET

[Differential] [Accepted] D2592: Properly place the title in the layout

2016-08-26 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2592 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasm

[Differential] [Request, 7 lines] D2592: Properly place the title in the layout

2016-08-26 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Let the text elide if it doesn't fit Use layout properties instead of adding an empty item REPOSITORY

[Differential] [Accepted] D2585: [Applet Configuration] Only scroll down if item is barely visible

2016-08-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2585 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D2591: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height

2016-08-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Re: Review Request 128772: Proofread + update baloo kcm docbook

2016-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128772/#review98697 --- Fix it, then Ship it! doc/kcontrol/baloo/index.docbook (l

Re: Review Request 128769: Update solid-actions kcm docbook to 5.7

2016-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128769/#review98696 --- doc/kcontrol/solid-actions/index.docbook (line 17)

Re: Review Request 128769: Update solid-actions kcm docbook to 5.7

2016-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128769/#review98695 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2016, 10:0

Re: Review Request 128770: Proofread solid-device-automounter kcm docbook to 5.7

2016-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128770/#review98694 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2016, 10:1

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread David Edmundson
> On Aug. 26, 2016, 11:16 a.m., Martin Gräßlin wrote: > > Ship It! Not merging yet as someone (loa) on IRC reports a crash with this - I'm quite sure I know what it'll be, the runnable trying to access WindowThumbnail after it's been deleted. I think I'll have to split all the vars that I mark

Re: Review Request 128767: Fix crash when no QApplication is available.

2016-08-26 Thread David Faure
> On Aug. 26, 2016, 1:06 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qmenu.cpp, line 91 > > > > > > and these ones? Not called by qmlpluginscanner, but yeah if you prefer I can add if

Re: Review Request 128767: Fix crash when no QApplication is available.

2016-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/#review98691 --- src/declarativeimports/plasmacomponents/qmenu.cpp (line 91)

[Differential] [Request, 3 lines] D2591: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height

2016-08-26 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By reducing spacing and lineHe

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

2016-08-26 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 12:38:16 + Build duration: 14 min CHANGE SET Revision b20c89677b56075e3e27808c88438b4

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

2016-08-26 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 12:38:16 + Build duration: 14 min CHANGE SET Revision b20c89677b56075e3e27808c88438b4

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 389 - Still Failing!

2016-08-26 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/389/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 12:32:32 + Build duration: 4 min 20 sec CHANGE SET Revision 16cff5424074eeb6f55e39ac6c602

Review Request 128772: Proofread + update baloo kcm docbook

2016-08-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128772/ --- Review request for Documentation, Plasma and Vishesh Handa. Repository: p

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > luebking wrote in compositing.h:63 > The "is" prefix is a QML mandate, right? > > isObeyingCompositorBlockRequests > isCompositorBlockAllowed > > However, afaiu the biggest complaint was that it was broken (due to shadow > deletion) yesno? Rea

[Differential] [Updated, 99 lines] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread Martin Gräßlin
graesslin updated this revision to Diff 6296. graesslin added a comment. reword to applications instead of windows REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2584?vs=6286&id=6296 BRANCH blocking-compositing REVISION DETAIL https://phabricator.kde.or

[Differential] [Changed Subscribers] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > compositing.h:63 > int openGLPlatformInterface() const; > +bool isWindowsBlockingCompositing() const; > The "is" prefix is a QML mandate, right? isObeyingCompositorBlockRequests isCompositorBlockAllowed However, afaiu the biggest com

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 388 - Still Failing!

2016-08-26 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/388/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 12:07:49 + Build duration: 3 min 43 sec CHANGE SET Revision 85a561b71008c4baee6e6a1f8e09a

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 387 - Failure!

2016-08-26 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/387/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 12:00:07 + Build duration: 7 min 33 sec CHANGE SET Revision 792ca1d6489d6428de4039c25f289

[Differential] [Closed] D2587: Set proper component name for plasma-discover

2016-08-26 Thread bshah (Bhushan Shah)
This revision was automatically updated to reflect the committed changes. Closed by commit rDISCOVER663b245051ad: Set proper component name for plasma-discover (authored by bshah). REPOSITORY rDISCOVER Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2587?vs=629

[Differential] [Closed] D2588: Load QtQuickSettings

2016-08-26 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE792ca1d6489d: Load QtQuickSettings (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2588?vs=6291&id=6294

[Differential] [Accepted] D2587: Set proper component name for plasma-discover

2016-08-26 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I thought so. REPOSITORY rDISCOVER Discover Software Store BRANCH setpropercomponentname (branched from master) REVISION DETAIL https://phabricator.kde.org/D2587 EMAIL PREFERENCES htt

[Differential] [Accepted] D2588: Load QtQuickSettings

2016-08-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D2588 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread mart (Marco Martin)
mart added a comment. yeah, should be "allow applications" even if not 100% correct REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, #vdg Cc:

[Differential] [Request, 15 lines] D2590: Use new inline revealpassword action

2016-08-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. davidedmundson added a subscriber: plasma-devel. davidedmundson added a project: Plasma. TEST PLAN Clicked a new connection. Toggled show/hide action REPOSITORY rPLASMANM Plasma Network Management Applet BRANCH

[Differential] [Request, 2 lines] D2589: Make the AbstractListItem a Rectangle

2016-08-26 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As described by the documentation and as it makes sense. TEST PLAN Seems to just work REPOSITORY rKI

[Differential] [Request, 5 lines] D2588: Load QtQuickSettings

2016-08-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL h

[Differential] [Commented On] D2587: Set proper component name for plasma-discover

2016-08-26 Thread bshah (Bhushan Shah)
bshah added a comment. In https://phabricator.kde.org/D2587#48297, @apol wrote: > Are you sure it wasn't because of this? > http://commits.kde.org/discover/31ccc5d258a1833bc67a9af0ae8c9e70d951edd8 setWindowIcon doesn't work on wayland.. See - https://blog.martin-graesslin.com/

[Differential] [Abandoned] D2455: Use new inline revealpassword action

2016-08-26 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. davidedmundson added a comment. Will re-upload this REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2455 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #pl

[Differential] [Updated] D2587: Set proper component name for plasma-discover

2016-08-26 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Are you sure it wasn't because of this? http://commits.kde.org/discover/31ccc5d258a1833bc67a9af0ae8c9e70d951edd8 REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D2587 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Abandoned] D2567: Load QtQuick rendering settings from config

2016-08-26 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2567 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: broulik, mart, graesslin, plasma-devel, les

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98684 --- Ship it! Ship It! - Martin Gräßlin On Aug. 26, 2016, 3:

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread Martin Gräßlin
> On Aug. 26, 2016, 9:49 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686 > > > > > > we probably need to do the same for EGL, don't we? > > David Edmundson wrote: >

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Anthony Fieroni
> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this

Re: Review Request 128765: Fix cannot assign undefined to double warning in DayDelegate

2016-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128765/ --- (Updated Aug. 26, 2016, 11:14 a.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 284 - Still Unstable!

2016-08-26 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/284/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 26 Aug 2016 10:56:37 + Build duration: 15 min CHANGE SET Revision 52d6f260addb2f99082b5ce61a63b5fca9af

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread David Edmundson
> On Aug. 26, 2016, 7:49 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, lines 682-686 > > > > > > we probably need to do the same for EGL, don't we? GLX and ELG are the same. I

[Differential] [Request, 2 lines] D2587: Set proper component name for plasma-discover

2016-08-26 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added reviewers: Plasma, apol, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Plasma discover installs desktop file as org.kde.discover, but it instead sets its component na

[Differential] [Updated] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread Martin Gräßlin
graesslin added a dependent revision: D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

2016-08-26 Thread Martin Gräßlin
graesslin added a dependency: D2584: Introduce a config option whether applications are allowed to block compositing. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2586 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwi

[Differential] [Request, 41 lines] D2586: [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required

2016-08-26 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On Wayland compositing is required. It doesn't make any sense to off

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-26 Thread Painless Roaster
> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? I do not have an account on github. - Painless --- This is an automatically generated e-mail. To

Review Request 128771: powerdevil lcm docbook update to 5.7

2016-08-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128771/ --- Review request for Documentation and Plasma. Repository: powerdevil Des

Review Request 128770: Proofread solid-device-automounter kcm docbook to 5.7

2016-08-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128770/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Review Request 128769: Update solid-actions kcm docbook to 5.7

2016-08-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128769/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

2016-08-26 Thread Peter Wu
> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-08-26 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128768/ --- Review request for Plasma and David Faure. Bugs: 366569 https://bugs.

[Differential] [Closed] D2583: DiscardWindowPixmap when Surface size changes

2016-08-26 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINbe79d1aeda4e: DiscardWindowPixmap when Surface size changes (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2583?vs=6283&id=6288 REVISION DET

[Differential] [Request, 10 lines] D2585: [Applet Configuration] Only scroll down if item is barely visible

2016-08-26 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The logic for scrolling a focu

[Differential] [Accepted] D2583: DiscardWindowPixmap when Surface size changes

2016-08-26 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH discard-window-pixmap-surface-size-changed REVISION DETAIL https://phabricator.kde.org/D2583 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Changed Subscribers] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread bshah (Bhushan Shah)
bshah added inline comments. INLINE COMMENTS > compositing.ui:294 > + > + Allow windows to block compositing > + Even though windows is more correct term here technically, IMO it makes more sense to have it as "Allow applications to block compositing". what do you think? REPOSI

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread Martin Gräßlin
graesslin added a comment. F269479: Spectacle.Z21567.png REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_waylan

[Differential] [Request, 95 lines] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, VDG. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY From feedback we got it seems that not all users agree to games

[Breeze] [Bug 367818] Password textfield is not visible when using dm-crypt

2016-08-26 Thread Harald Sitter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367818 Harald Sitter changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED

Re: Review Request 128767: Fix crash when no QApplication is available.

2016-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/#review98676 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2016, 7:05

Re: Review Request 128765: Fix cannot assign undefined to double warning in DayDelegate

2016-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128765/#review98675 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2016, 2:14

[Differential] [Closed] D2573: [SessionManagementScreen] Limit width of innerLayout

2016-08-26 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE09903d637229: [SessionManagementScreen] Limit width of innerLayout (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

[Differential] [Closed] D2572: [Lock Screen] Remove unused Label

2016-08-26 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe3b4df44e1a6: [Lock Screen] Remove unused Label (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2572?vs=6253&i

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review98673 --- src/declarativeimports/core/windowthumbnail.cpp (lines 680 -

Review Request 128767: Fix crash when no QApplication is available.

2016-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor