Re: [PATCH 6/7] add kirigami icons as resource

Am 16.08.2016 um 21:27 schrieb Marco Martin: > did some comments inline but would be better if this was done in phabricator > > On Tuesday 16 August 2016 20:23:51 Martin Gysel wrote: >> alias="icons/document-decrypt.svg">breeze-icons/icons/actions/32/document-d >> ecrypt.svg +> alias="icon

[Differential] [Closed] D2471: Translate Qt key events through the unicode text with xkbcommon

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN9581f23ed86c: Translate Qt key events through the unicode text with xkbcommon (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2471?vs=5999&id=

[Differential] [Updated, 18 lines] D2470: [upowerbackend] set cached brightness manually in case of led backlight

bshah updated this revision to Diff 6004. bshah added a comment. - more readable variable name REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2470?vs=5998&id=6004 BRANCH workaround-broken-backlight-driver (branched from master) REVISION DETAIL

[Differential] [Closed] D2466: Introduce env variable KWIN_XKB_DEFAULT_KEYMAP to force default layout creation

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINea22b8f15dd7: Introduce env variable KWIN_XKB_DEFAULT_KEYMAP to force default layout creation (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Changed Subscribers] D2470: [upowerbackend] set cached brightness manually in case of led backlight

graesslin added inline comments. INLINE COMMENTS > powerdevilupowerbackend.h:122 > +// property if brightness control is leds subsystem > +bool m_isBrightnessControlLed; > + I suggest to use a different name. I read it as Controlled and just wanted to complain that the second L is upper

[Differential] [Closed] D2469: Only show full opacity on selected item

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEeab328e78592: Only show full opacity on selected item (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

Re: Review Request 128598: system-xxx icons are available only monochrome

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128598/ --- (Updated Aug. 17, 2016, 9:30 p.m.) Status -- This change has been ma

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

broulik added a comment. Ping. I just noticed, the search is also broken, ie. the delegates don't visually indicate that they're disabled when no result was shown (a spotlight kind of highlight would be nice, though ;) REPOSITORY rSYSTEMSETTINGS System Settings REVISION DETAIL http

[Differential] [Commented On] D2465: [kded] correctly restore lidOpened configuration on startup

graesslin added inline comments. INLINE COMMENTS > sebas wrote in daemon.cpp:167-169 > It won't find a config file with _lidOpened appended, since that is only ever > created when the lidClosedChanged signal is fired (which only happens when > the device is a laptop and actually has a lid). So

Re: Review Request 128703: [kcm_mouse] Sync KDE4 config after writing the KF5 settings, not before

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/ --- (Updated Aug. 17, 2016, 7:56 p.m.) Review request for Plasma. Changes -

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

> On Aug. 17, 2016, 7:40 p.m., Martin Gräßlin wrote: > > Ship It! I meanwhile noticed that the kcminputrc settings have the same problem (and additionally they are no written to KDE4 at all because of a bug in Kdelibs4SharedConfig::syncConfigGroup()) As it is closely related, I think I'll jus

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/#review98441 --- Ship it! Ship It! - Martin Gräßlin On Aug. 17, 2016, 4:

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

> On Aug. 17, 2016, 5:26 p.m., Martin Gräßlin wrote: > > kcms/input/mouse.cpp, line 761 > > > > > > isn't that too much? That will also sync unrelated settings in group > > "KDE", wouldn't it? > > Wolfgang Baue

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

> On Aug. 16, 2016, 7:05 vorm., David Faure wrote: > > doc/kcontrol/khtml-general/index.docbook, line 7 > > > > > > Yeah I don't understand what this docbook is doing here :-) these docbooks are probably here beca

Re: Review Request 128685: Proofread + update performance kcm docbook

> On Aug. 16, 2016, 7:11 vorm., David Faure wrote: > > Can you move it to kde-baseapps, along with any other konqueror-related > > docbook? move khtml-behavior, bookmarks, html-java-js, khtml-adblock, history, performance, kcmcss, filemanager, khtml-general preserving history from plasma-desk

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

> On Aug. 17, 2016, 5:26 p.m., Martin Gräßlin wrote: > > kcms/input/mouse.cpp, line 761 > > > > > > isn't that too much? That will also sync unrelated settings in group > > "KDE", wouldn't it? I supppose so, ye

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/#review98435 --- kcms/input/mouse.cpp (line 760)

[Differential] [Request, 9 lines] D2471: Translate Qt key events through the unicode text with xkbcommon

graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY KKeyServer does an incorrect translation to keysyms: it always translat

[Differential] [Accepted] D2471: Translate Qt key events through the unicode text with xkbcommon

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Looks good.. REPOSITORY rKWIN KWin BRANCH virtualkeyboard-sym-translation REVISION DETAIL https://phabricator.kde.org/D2471 EMAIL PREFERENCES https://

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/ --- (Updated Aug. 17, 2016, 4:47 nachm.) Review request for Plasma. Bugs: 3

Re: Review Request 128703: [kcm_mouse] Sync KDE4 kdeglobals after writing the KF5 settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/ --- (Updated Aug. 17, 2016, 4:46 nachm.) Review request for Plasma. Summary

Review Request 128703: [kcm_input] Sync KDE4 kdeglobals after writing the KF5 settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/ --- Review request for Plasma. Bugs: 367074 https://bugs.kde.org/show_bug

[Differential] [Request, 18 lines] D2470: [upowerbackend] set cached brightness manually in case of led backlight

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In normal backlight subsystem's drivers typical workflow is, - setBrightness gets called - it writ

[Differential] [Commented On] D2465: [kded] correctly restore lidOpened configuration on startup

sebas added inline comments. INLINE COMMENTS > graesslin wrote in daemon.cpp:167-169 > how does that behave if the device has no lid? It won't find a config file with _lidOpened appended, since that is only ever created when the lidClosedChanged signal is fired (which only happens when the dev

Plasma 5.8 schedule update

As discussed on this list and in meetings I've updated the 5.8 release schedule at SuSE's request making the repo freeze during akademy and the release two weeks earlier at the end of september/start of october. Other dates become two weeks earlier too. https://community.kde.org/Schedules/Plasma_

[Differential] [Closed] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc04e7643699e: [platforms/hwcomposer] Reset old brightness when turning screen back on (authored by bshah). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5996

[Differential] [Updated, 14 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah updated this revision to Diff 5996. bshah marked an inline comment as done. bshah added a comment. nitpick REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5995&id=5996 BRANCH bshah/hwcomposer-restore-brightness (branched from master) REVISION

[Differential] [Accepted] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > hwcomposer_backend.cpp:147 > { > + > if(!QDBusConnection::sessionBus().connect(QStringLiteral("org.kde.Solid.PowerManagement"), > +

[Differential] [Updated, 14 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah updated this revision to Diff 5995. bshah marked an inline comment as done. bshah added a comment. static-- REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5994&id=5995 BRANCH bshah/hwcomposer-restore-brightness (branched from master) REVISIO

[Differential] [Commented On] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

graesslin added inline comments. INLINE COMMENTS > hwcomposer_backend.cpp:47 > > +const static QString s_solidPowerManagementService = > QStringLiteral("org.kde.Solid.PowerManagement"); > + given the other parts of the connect are not static: I think we can get rid of that one, too REPOSITO

[Differential] [Updated, 16 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah updated this revision to Diff 5994. bshah added a comment. appearantly I don't need ServiceWatcher dance REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2468?vs=5991&id=5994 BRANCH bshah/hwcomposer-restore-brightness (branched from master) REVISION D

[Differential] [Updated, 8 lines] D2469: Only show full opacity on selected item

davidedmundson updated this revision to Diff 5993. davidedmundson added a comment. changed to long duration to match list view switch time REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2469?vs=5992&id=5993 REVISION DETAIL https://ph

[Differential] [Request, 8 lines] D2469: Only show full opacity on selected item

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY See https://phabricator.kde.org/M58/196/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANC

[Differential] [Request, 28 lines] D2468: [platforms/hwcomposer] Reset old brightness when turning screen back on

bshah created this revision. bshah added reviewers: Plasma on Wayland, broulik, graesslin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Now powerdevil can adjust brightness using leds subsystem, how

Re: more Kirigami patches

On 16.08.2016 20:42, Martin Gysel wrote: Am 16.08.2016 um 20:28 schrieb Marco Martin: On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote: Hi Here are some patches I have in my branch. It contains a script to (re)generate the qml file, one the generate a resource file with possibly used icons

Re: Review Request 128702: Use default weight rather than normal weight

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128702/#review98426 --- Ship it! do you have commit access? - David Edmundson O