Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/#review98255 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 10, 2016

Review Request 128642: Fix blatant bug in code that was pushed unreviewed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128641/#review98253 --- Ship it! Ship It! - Sebastian Kügler On Aug. 9, 2016, 1

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98254 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 10, 2016

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98252 --- Ship it! Ship It! - Sebastian Kügler On Aug. 9, 2016, 1

Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128641/ --- Review request for KDE Frameworks, Plasma and David Faure. Repository: pl

Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/ --- Review request for KDE Frameworks, Plasma and David Faure. Repository: pl

[Differential] [Commented On] D2330: [xrandr backend] fall back to preferred mode, fix crash

sebas added inline comments. INLINE COMMENTS > graesslin wrote in xrandrconfig.cpp:556-558 > I think you want to remove the if clause now No, this part is a bit different from the above hunk, it uses the xOutput by default, and if that is empty, falls back to kscreen's currentModeId or the pre

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

graesslin added inline comments. INLINE COMMENTS > kwinqml.cpp:153 > +if (m_seat != nullptr) { > +m_seat->keyPressed(event->nativeScanCode() - 8); > +} only do that on X11, if we are on Wayland that would be wrong. So do something like: const int magicOffset = KWindowSystem::

[Differential] [Closed] D2372: Make powerdevil normal executable instead of kded module

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVILa5a325e20c15: Make powerdevil normal executable instead of kded module (authored by bshah). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2372?vs=5

[Differential] [Accepted] D2372: Make powerdevil normal executable instead of kded module

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil BRANCH powerdevil-executable (branched from master) REVISION DETAIL https://phabricator.kde.org/D2372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

broulik added a comment. I was thinking about that but where would you want to place it? The only place where it wouldn't look like crap is right of the "Notifications" heading but this is done by system tray and we cannot place items there from within an applet. REPOSITORY rPLASMAWORKSPA

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

colomar added a comment. Shouldn't that button rather be in the popup itself? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2383 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_de

[Differential] [Request, 20 lines] D2383: [Notifications] Add "Clear Notifications" context menu entry

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Th

[Differential] [Changed Subscribers] D2381: Share logic for passing AbstractTasksModelIface methods to source model

hein added inline comments. INLINE COMMENTS > abstracttasksproxymodeliface.h:164 > /** > - * Request moving the task at the given index to the specified > activities. > + * Request moving the task at the given index to the specified virtual > + * activities. "Specified virtual

[Differential] [Closed] D2374: [kded] fix monitoring for newly appearing outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN68423ccdf3f8: [kded] fix monitoring for newly appearing outputs (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2374?vs=5770&id=5771 REV

[Differential] [Accepted] D2374: [kded] fix monitoring for newly appearing outputs

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/newdockoutputs REVISION DETAIL https://phabricator.kde.org/D2374 EMAIL PREFERENCES https://phabricator.kde.or

[Differential] [Accepted] D2374: [kded] fix monitoring for newly appearing outputs

graesslin accepted this revision. graesslin added a reviewer: graesslin. REPOSITORY rKSCREEN KScreen BRANCH sebas/newdockoutputs REVISION DETAIL https://phabricator.kde.org/D2374 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, davidedm

[Differential] [Updated, 10 lines] D2374: [kded] fix monitoring for newly appearing outputs

sebas updated this revision to Diff 5770. sebas added a comment. - Also connect disconnected outputs REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2374?vs=5747&id=5770 BRANCH sebas/newdockoutputs REVISION DETAIL https://phabricator.kde.org/D2374

Re: Plasma desktop window uses RGBA

On Tuesday, August 9, 2016 11:16:33 AM CEST Martin Graesslin wrote: > Hi all, > > I just noticed that Plasma's desktop window uses an RGBA format. This is not > only completely pointless as it's the bottom most window, it's also > destroying all optimizations in KWin. KWin always has to go into th

[Differential] [Request, 1,377 lines] D2381: Share logic for passing AbstractTasksModelIface methods to source model

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Create a subclass of AbstractTasksModelIface which proxies the call to the source model.

[Differential] [Closed] D2380: Allow disabling filtering by SkipTaskbar.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb58f6ee2a3c5: Allow disabling filtering by SkipTaskbar. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2380?vs=5

[Differential] [Closed] D2379: Factor windowing system arbitration out of TasksModel.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEacfbcb4fa522: Factor windowing system arbitration out of TasksModel. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Accepted] D2379: Factor windowing system arbitration out of TasksModel.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2379 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Commented On] D2379: Factor windowing system arbitration out of TasksModel.

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in windowtasksmodel.h:43 > Idea: > if you a subclass of AbstractTasksModelIface with a > virtual QAbstractProxyModel* source() > > you could kill a tonne of duplicated code I'm having trouble parsing this due to missing words(?

[Differential] [Updated] D2379: Factor windowing system arbitration out of TasksModel.

hein added a comment. > To export WindowTasksModel directly? It's already exported ...? See the change to CMakeLists.txt and the TASKMANAGER_EXPORT macro. > You'd still need to go via TaskFilterProxyModel Yes, TaskFilterProxyModel is also useful with some changes (see https://p

[Differential] [Accepted] D2380: Allow disabling filtering by SkipTaskbar.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH optionalfilterskiptaskbar REVISION DETAIL https://phabricator.kde.org/D2380 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Updated] D2379: Factor windowing system arbitration out of TasksModel.

davidedmundson added a comment. One question first: > It allows users of libtaskmanager which are solely interested in window data (e.g. the Pager) to skip the unnecessary complexity of TasksModel, while still sharing the windowing monitoring with users of TasksModel. What's your lo

[Differential] [Request, 41 lines] D2380: Allow disabling filtering by SkipTaskbar.

hein created this revision. hein added reviewers: Plasma, mart, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This makes TaskFilterProxyModel useful for filtering a source tasks model (e.g. WindowTasksModel) without impl

[Differential] [Commented On] D2372: Make powerdevil normal executable instead of kded module

bshah added a comment. mark comments as done REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, #plasma, broulik, graesslin Cc: davidedmundson, shumski, plasma-de

[Differential] [Closed] D2377: use the feature summary to communicate runtime deps

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONf1191def10a0: use the feature summary to communicate runtime deps (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2377?vs=5754&id=5764#toc REPOSITORY rPLASM

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

sitter added a comment. In https://phabricator.kde.org/D2377#44513, @heikobecker wrote: > Also imagine a user investigating why the two packages don't show up although he has installed them. In the landing version I have added notes about them not being detected automatically and

[Differential] [Updated, 109 lines] D2372: Make powerdevil normal executable instead of kded module

bshah updated this revision to Diff 5763. bshah added a comment. set desktopSettingsAware to false REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2372?vs=5759&id=5763 BRANCH powerdevil-executable (branched from master) REVISION DETAIL https:

[Differential] [Request, 401 lines] D2379: Factor windowing system arbitration out of TasksModel.

hein created this revision. hein added reviewers: Plasma, mart, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This introduces a new WindowTasksModel which is a QIdentityProxyModel around an instance of either WaylandTask

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

heikobecker added a comment. In https://phabricator.kde.org/D2377#44495, @sitter wrote: > In https://phabricator.kde.org/D2377#44484, @heikobecker wrote: > > > So I think two Find... modules are also needed or "message..." should stay. > > > Well. No. > > https://cmake.org/c

[Differential] [Accepted] D2377: use the feature summary to communicate runtime deps

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. I don't think we need the comments at the end. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRA

[Differential] [Closed] D2378: Instanciate the launcher tasks model only when needed.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc802bb8789c8: Instanciate the launcher tasks model only when needed. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Updated] D2377: use the feature summary to communicate runtime deps

mart added a reviewer: Plasma. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2377 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, #plasma Cc: heikobecker, plasma-devel, leslie

[Differential] [Accepted] D2378: Instanciate the launcher tasks model only when needed.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2378 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Updated, 346 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 5760. mart added a comment. - prototype for support of per-looknfeel layout - monitor for file creation - delete views and arrays in the proper order - be silent - prototype of JS config dump - more complete config js dumper - generic kconfiggroup

[Differential] [Updated, 108 lines] D2372: Make powerdevil normal executable instead of kded module

bshah updated this revision to Diff 5759. bshah marked an inline comment as done. bshah added a comment. - Make it autorestart on crash - Make it unique so there are not multiple powerdevil REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2372?vs=

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

sitter added a comment. In https://phabricator.kde.org/D2377#44484, @heikobecker wrote: > So I think two Find... modules are also needed or "message..." should stay. Well. No. https://cmake.org/cmake/help/v3.0/command/find_package.html > Every non-REQUIRED find_package ca

[Differential] [Updated, 98 lines] D2372: Make powerdevil normal executable instead of kded module

bshah updated this revision to Diff 5758. bshah added a comment. fix powerdevil exiting on wayland REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2372?vs=5751&id=5758 BRANCH powerdevil-executable (branched from master) REVISION DETAIL https:

Plasma desktop window uses RGBA

Hi all, I just noticed that Plasma's desktop window uses an RGBA format. This is not only completely pointless as it's the bottom most window, it's also destroying all optimizations in KWin. KWin always has to go into the blending code path, which means rendering from bottom to top instead of r

[Differential] [Request, 60 lines] D2378: Instanciate the launcher tasks model only when needed.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Previously the launcher tasks model was always instanciated; with this change it's only done once a launcher list ge

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

heikobecker added a comment. I like packages stating their dependencies (even runtime ones) because that's where I look first as a packager. But if I'm not missing something (maybe a git add?) this change is a bit misleading because they can never be found. So I think two Find... modules are

[Differential] [Changed Subscribers] D2372: Make powerdevil normal executable instead of kded module

davidedmundson added inline comments. INLINE COMMENTS > powerdevilapp.cpp:137 > > -#include "kdedpowerdevil.moc" > +int main(int argc, char **argv) > +{ Should it have KCrash::setFlags(AutoRestart) ? REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2372 EMA

[Differential] [Accepted] D2325: Don't unconditionally emit buttonPressed on profile load

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. This is like a tutorial in how to make useless code comments. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- (Updated Aug. 9, 2016, 8:37 a.m.) Status -- This change has been mar

Re: Review Request 128612: Add translation domain to wallpaper QML object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128612/ --- (Updated Aug. 9, 2016, 8:37 a.m.) Status -- This change has been mar

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review98219 --- Ship it! Ship It! - Martin Gräßlin On July 21, 2016, 3:

[Differential] [Commented On] D2345: use a separate configuration per look and feel

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:383 > No > > you need to loop through containments() rather than the views > (same for panel section) > > Otherwise: > > - you're only saving the currently plugged in screens. > - this won't save the conf

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

bdhruve added a comment. In https://phabricator.kde.org/D1989#44453, @graesslin wrote: > I just remembered: on X11 one needs to subtract 8 from the key code... The keyEvents are working perfectly now because of the solution you gave. Thank you. :-) Are there any other issues in

[Differential] [Commented On] D2345: use a separate configuration per look and feel

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:321 > If we go with this patch > > you should filter out ItemGeometries and AppletOrder here as you're making a > special case out of them. > Otherwise you're saving garbage data in the config which could conf

[Differential] [Updated, 347 lines] D1989: Introduce QQuickItem to nest kwin_wayland

bdhruve updated this revision to Diff 5755. bdhruve added a comment. Added back the keyEvent handling and works perfectly now. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5753&id=5755 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org

[Differential] [Request, 15 lines] D2377: use the feature summary to communicate runtime deps

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN - cmake - prints warning - can be overridden with CMAKE_DISABLE_FIND_PACKAGE_foo REPOSITORY rPLASMAINTEGRATION Integration for Qt applications i

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

graesslin added a comment. I just remembered: on X11 one needs to subtract 8 from the key code... REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, bshah, graesslin, #plas

[Differential] [Updated, 328 lines] D1989: Introduce QQuickItem to nest kwin_wayland

bdhruve updated this revision to Diff 5753. bdhruve added a comment. Remove keyEvent handling. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1989?vs=5713&id=5753 BRANCH kwinqml REVISION DETAIL https://phabricator.kde.org/D1989 AFFECTED FILES config-

[Differential] [Commented On] D2325: Don't unconditionally emit buttonPressed on profile load

broulik added a comment. Ping. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2325 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, afiestas Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, a

[Differential] [Updated, 97 lines] D2372: Make powerdevil normal executable instead of kded module

bshah updated this revision to Diff 5751. bshah added a comment. read shortcuts from kded5 component, unfortunately its close to impossible to migrate shortcuts using kconf_update REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2372?vs=5749&id=575