[Differential] [Updated] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-29 Thread net147 (Jonathan Liu)
net147 updated the summary for this revision. net147 updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2310 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, #plasma Cc: p

[Differential] [Request, 2 lines] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

2016-07-29 Thread net147 (Jonathan Liu)
net147 created this revision. net147 added a reviewer: Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I have many entries in the favori

[sysadmin/ci-master-config] docker/ubuntu-wily-slave: Include libcanberra-dev in the CI system image for KF5 based builds, as needed by Plasma PA.

2016-07-29 Thread Ben Cooksley
Git commit 02fdad704cca5fa4a141c7b9a18cfa89c4e4cf9c by Ben Cooksley. Committed on 29/07/2016 at 20:21. Pushed by bcooksley into branch 'master'. Include libcanberra-dev in the CI system image for KF5 based builds, as needed by Plasma PA. This should fix it's CI build. @PlasmaDevs: Please ask for

[Differential] [Updated] D1816: Switch to Hack as default monospace font

2016-07-29 Thread dhaumann (Dominik Haumann)
dhaumann added a comment. Yes, the font faces are all there, so HACK does qualify. On a personal note, I think the 'i' looks a bit strange, but that's probably to distinguish it form better form a 'j'. Here, to my eyes, the 'i' from the Source Code Pro font looks better, but given I did

Re: Is it possible to know when a PlasmaCore IconItem is ready?

2016-07-29 Thread Michail Vourlakos
David, sorry for the previous e-mail it was sent by mistake... I also thought maybe is something wrong with the IconItem so I used the following code, a static image for all tasks... Same problem... my guess is that that the DropShadow is updating because there is a change it its scale even though

Re: Is it possible to know when a PlasmaCore IconItem is ready?

2016-07-29 Thread Michail Vourlakos
PlasmaCore.IconItem { id: iconImage width:64 height:64 anchors.centerIn: parent } DropShadow { id:shadowImageNoActive width: 64 height: 64 scale: wrapper.scale * wrapper.appearScale anchors.centerIn: parent

Re: Is it possible to know when a PlasmaCore IconItem is ready?

2016-07-29 Thread David Edmundson
Given you already have usePlasmaTheme:false does using QIconItem from KQuickControlsAddons work any better? David On Fri, Jul 29, 2016 at 4:35 PM, Michail Vourlakos wrote: > > > > Move the IconItem outside the DropShadow. > > Otherwise you're scaling the source still, which is what we want to

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-29 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/ --- (Updated July 29, 2016, 3:40 p.m.) Review request for Plasma, Kai Uwe Bro

Re: Is it possible to know when a PlasmaCore IconItem is ready?

2016-07-29 Thread Michail Vourlakos
> > Move the IconItem outside the DropShadow. > Otherwise you're scaling the source still, which is what we want to avoid. > > Out of curiosity, how are you measuring performance? > David even this way I get the same bad performance... This is the code inside a task delegate. I have implemented a

Re: Plasma 5.8 and openSUSE 42.2

2016-07-29 Thread Marco Martin
On Wednesday 27 July 2016 18:44:16 Antonio Larrosa wrote: > 2016-09-01: openSUSE 42.2 Beta 1 (this would include the last Plasma > release available at that time, 5.7.4 or 5.7.5) > 2016-09-08: Plasma 5.8 Repo Freeze (last day of Akademy, maybe that > could be moved to freeze the repo just before Qt

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-29 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/#review97909 --- containments/desktop/plugins/folder/foldermodel.cpp (line 93

Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

2016-07-29 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/ --- Review request for Plasma, Kai Uwe Broulik and Bhushan Shah. Repository:

Plasma 5.7 scripting

2016-07-29 Thread Ivan Čukić
Hi all, Unfortunately, since the new multiscreen code landed, we had a few really big issues regarding plasma scripting - namely with the execution of the the layout.js. The bugs were both in the scripting engine, and both in our upstream layout.js and the custom ones shipped by the distros. Thes

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 289 - Still Unstable!

2016-07-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/289/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 29 Jul 2016 14:13:52 + Build duration: 5 min 9 sec CHANGE SET Revision 475bed7373142afe20927acbc465f

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-29 Thread apol (Aleix Pol Gonzalez)
apol added a comment. In https://phabricator.kde.org/D2306#43024, @mart wrote: > it should just be a fixed header, always visible and laid out with the main content or flickable, it should be in Page (and just happening to work in scrollablepage too) and the property called just header,

Re: Review Request 128549: [TextField] Hide clear button properly

2016-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128549/#review97906 --- Ship it! Ship It! - Marco Martin On July 29, 2016, 12:1

Re: Review Request 128551: [TextFieldStyle] Calculate right padding with clear button properly

2016-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128551/#review97907 --- Ship it! Ship It! - Marco Martin On July 29, 2016, 12:2

Re: Review Request 128550: [TextField] Bind to TextField length instead of text

2016-07-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128550/ --- (Updated July 29, 2016, 1:42 p.m.) Status -- This change has been ma

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-29 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2306#43005, @apol wrote: > In https://phabricator.kde.org/D2306#42989, @mart wrote: > > > seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange > > > What is that you d

Re: Review Request 128550: [TextField] Bind to TextField length instead of text

2016-07-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128550/#review97904 --- Ship it! Ship It! - David Edmundson On July 29, 2016, 1

Review Request 128551: [TextFieldStyle] Calculate right padding with clear button properly

2016-07-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128551/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 128550: [TextField] Bind to TextField length instead of text

2016-07-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128550/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 128549: [TextField] Hide clear button properly

2016-07-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128549/ --- Review request for Plasma. Repository: plasma-framework Description ---

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 288 - Still Unstable!

2016-07-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/288/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 29 Jul 2016 12:10:52 + Build duration: 5 min 15 sec CHANGE SET Revision d204265370f7bd60756c1e3c8d44

[Differential] [Closed] D2298: allow for lnf packages to override templates

2016-07-29 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd204265370f7: allow for lnf packages to override templates (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2298?v

[Differential] [Accepted] D2298: allow for lnf packages to override templates

2016-07-29 Thread Ivan Čukić
ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Seems ok REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/paneltemplate REVISION DETAIL https://phabricator.kde.org/D2298 EMAIL PREFERENCES https://phabricator.kde.org/setting

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 55 - Failure!

2016-07-29 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 29 Jul 2016 11:47:19 + Build duration: 7 min 56 sec CHANGE SET Revision 61389485e8148709786d9

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 287 - Still Unstable!

2016-07-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/287/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 29 Jul 2016 11:25:32 + Build duration: 11 min CHANGE SET Revision dc8879e3652db760dbe943e743b5589a10

Re: Is it possible to know when a PlasmaCore IconItem is ready?

2016-07-29 Thread David Edmundson
On Thu, Jul 28, 2016 at 10:40 PM, Michail Vourlakos wrote: > > > >> for DropShadow and the animation for hover to add it > >> in the PlasmaCore.IconItem right? > >> > > > > I'd put the animation in the DropShadow itself and scale that. > > > > I bet changing the size of a ShaderEffectSource trigg

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-29 Thread apol (Aleix Pol Gonzalez)
apol added a comment. In https://phabricator.kde.org/D2306#42989, @mart wrote: > seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange What is that you don't like exactly? I can look into it if you tell me. REPOSITORY rKI

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 286 - Still Unstable!

2016-07-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/286/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 29 Jul 2016 08:54:32 + Build duration: 17 min CHANGE SET Revision b5cdc85975be718e46e322fafb11646180

[Differential] [Updated] D2306: Make it possible to provide a page header to ScrollablePage

2016-07-29 Thread mart (Marco Martin)
mart added a comment. seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2306 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer