---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128301/
---
(Updated July 22, 2016, 8:33 a.m.)
Status
--
This change has been ma
> On July 19, 2016, 6:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which
> > basically checks if we're using the KDE platfor
ivan created this revision.
ivan added reviewers: mart, garg.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We have a method to add an activity in plasma script, but
not to remove it. This patch fixes this situation.
Yippee, build fixed!
http://build.neon.kde.org/job/xenial_stable_plasma_user-manager/16/
On 21 July 2016 at 18:00, David Edmundson wrote:
>
> Done
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma
Done
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Will fix.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
the change to fix a memory leak from
https://phabricator.kde.org/D2215
which was commited as e9c7e86d47b6ef04ea9fbe4efadb825c55b297e2 by
David E has caused a build failure
http://build.neon.kde.org/job/xenial_stable_plasma_user-manager_bin_amd64/14/console
src/lib/accountmodel.cpp:58:47: error:
> On July 19, 2016, 4:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which
> > basically checks if we're using the KDE platfor
davidedmundson added a comment.
Something has got messed up with the patch?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2218
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: davidedmundso
> On July 19, 2016, 4:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which
> > basically checks if we're using the KDE platfor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128493/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
> On July 19, 2016, 4:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which
> > basically checks if we're using the KDE platfor
sebas added inline comments.
INLINE COMMENTS
> graesslin wrote in Output.qml:254
> this one looks confusing to my: why is the vendor compared to output.name?
> Just from reading it, one doesn't assume that root.output.name is also the
> vendor.
This label may show the output name, if it does,
graesslin added a comment.
generally looks ok to me.
INLINE COMMENTS
> Output.qml:254
> id: label
> -text: if (root.isCloneMode === true) {
> -return "";
> - } else if (root.output.type != KScreenOut
mart updated this revision to Diff 5391.
mart added a comment.
- make the test work
- get rid of m_idForDesktopView
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2218?vs=5308&id=5391
BRANCH
mart/screenConnectorManagement
REVISION
sebas updated the summary for this revision.
sebas removed a subscriber: graesslin.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2248
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc: plasma-devel, jensreuterb
sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When identical displays are connected, the identify overlay would display
the output name, while the preview in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128493/
---
(Updated Juli 21, 2016, 2:45 nachm.)
Review request for Plasma.
Bugs: 3
ivan added inline comments.
INLINE COMMENTS
> graesslin wrote in splashapp.cpp:155
> yes that's on my todo list since last Akademy... - in pretty much exactly the
> way you just outlined here.
Please do, I have grepped plasma codebases, and we have platformName() calls in
quite a few places.
mart added a comment.
In https://phabricator.kde.org/D2218#41550, @davidedmundson wrote:
> When adding a new design can you describe the design in words. i.e what
roles a class has
> It'd make things a lot easier.
>
> ScreenPool:
> It seems to have two jobs:
>
> - you've go
ivan added inline comments.
INLINE COMMENTS
> graesslin wrote in splashwindow.cpp:151
> well tricky then. I need to get to the kwayland integration done in
> KSplashApp. I need a way to get to that. And if it's not using KSplashApp
> that needs to be done somewhere else. If you have ideas how t
> On Juni 24, 2016, 2:52 nachm., Andrey Bondrov wrote:
> > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done:
> > 1. KF 5.23.0
> > 2. Plasma 5.6.5
> > 3. MiminizeAll applet latest snapshot from github (May 31, 2016)
> > 4. ShowDesktop applet from Plasma 5.6.5.
> >
> > I ad
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128491/
---
(Updated July 21, 2016, 2:25 p.m.)
Review request for Plasma and John Tap
> On July 21, 2016, 5:44 a.m., Martin Gräßlin wrote:
> > How would one test this?
>
> Martin Gräßlin wrote:
> I mean manual testing. If I pull in the patch, what do I need to do in
> ksysguard to actually see it in action?
make a new tab. open the sensor browser, and look under ACPI/{Cooli
graesslin added inline comments.
INLINE COMMENTS
> ivan wrote in splashapp.cpp:155
> Ok, to KWindowSystem then. It could be a method with inner cached static
> result so that the consecutive calls to it do not need to perform any string
> comparisons.
>
> This is not really a nice thing to hav
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/
---
(Updated July 21, 2016, 1:37 p.m.)
Review request for KDE Frameworks and
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 13:29:19 +
Build duration: 7 min 57 sec
CHANGE SET
Revision dbe70588ac269d139cede
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 13:29:19 +
Build duration: 7 min 57 sec
CHANGE SET
Revision dbe70588ac269d139cede
ivan added inline comments.
INLINE COMMENTS
> graesslin wrote in splashapp.cpp:155
> nah, if at all to KWindowSystem.
Ok, to KWindowSystem then. It could be a method with inner cached static result
so that the consecutive calls to it do not need to perform any string
comparisons.
This is not
davidedmundson added a comment.
> You have a crash if:
edit, that final crash doesn't exist anymore. Didn't see that you'd removed
the numScreens check in p-f
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2218
EMAIL PREFERENCES
https://
bdhruve added inline comments.
INLINE COMMENTS
> graesslin wrote in kwinqml.cpp:68
> ideally you don't need to repaint everything, but could just update the
> actual changed areas (carried in the damaged signal)
I am not much knowledgeable about how to render only specific area in QtQuick,
i t
bdhruve updated this revision to Diff 5389.
bdhruve added a comment.
- Performed the nullptr check for the buffer attached to the surface.
- Removed qDebug() statements.
- Fixed coding style.
- Fixed issue of only first frame rendering.
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 12:00:08 +
Build duration: 3 min 30 sec
CHANGE SET
Revision 8ee323bb91072d7c940fd
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 11:05:02 +
Build duration: 20 min
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 11:05:02 +
Build duration: 20 min
CHANGE SET
No changes
JUNIT RESULTS
https://bugs.kde.org/show_bug.cgi?id=358957
--- Comment #11 from Kai Uwe Broulik ---
If you set button handling to *no action* this doesn't mean some other service
should randomly do stuff instead...
--
You are receiving this mail because:
You are the assignee for the bug.
_
graesslin added inline comments.
INLINE COMMENTS
> ivan wrote in splashapp.cpp:155
> Maybe it would be a good idea to add this as a static method to KWayland
> somwehere?
nah, if at all to KWindowSystem.
> ivan wrote in splashwindow.cpp:151
> Can this be done differently - the splash is also u
ivan added a comment.
Mostly looks ok, though I can not comment on wayland-specific things.
INLINE COMMENTS
> splashapp.cpp:155
> +{
> +if
> (!QGuiApplication::platformName().startsWith(QLatin1String("wayland"),
> Qt::CaseInsensitive)) {
> +return;
Maybe it would be a good idea
https://bugs.kde.org/show_bug.cgi?id=358957
Thomas Fruehbeck changed:
What|Removed |Added
CC||fruehb...@aon.at
--- Comment #10 from Thomas
> On Юни 24, 2016, 5:52 след обяд, Andrey Bondrov wrote:
> > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done:
> > 1. KF 5.23.0
> > 2. Plasma 5.6.5
> > 3. MiminizeAll applet latest snapshot from github (May 31, 2016)
> > 4. ShowDesktop applet from Plasma 5.6.5.
> >
> > I
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 10:36:24 +
Build duration: 10 min
CHANGE SET
Revision 843d5185c397a2d06878dea18bb
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
On Wayland ksplash only showed on one screen. This is due to QtWayland
not passing any hint to the comp
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:46:29 +
Build duration: 25 min
CHANGE SET
Revision 3799151fd53d3aa645ac15785
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:46:29 +
Build duration: 25 min
CHANGE SET
Revision 3799151fd53d3aa645ac15785
apol added inline comments.
INLINE COMMENTS
> WidgetExplorer.qml:264
> id: closeButton
> -anchors {
> -right: parent.right
If it needs to be aligned to the right, shouldn't it have a `Layout.alignment:
Qt.AlignRight`?
REPOSITORY
rPLASMADESKTOP Plasma
> On June 24, 2016, 2:52 p.m., Andrey Bondrov wrote:
> > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done:
> > 1. KF 5.23.0
> > 2. Plasma 5.6.5
> > 3. MiminizeAll applet latest snapshot from github (May 31, 2016)
> > 4. ShowDesktop applet from Plasma 5.6.5.
> >
> > I adde
> Give it a try: move a window towards the dock. At some point it will start
> to snap against it.
I think this is happening only if I have configured the panel to be
"Always Visible", in all other cases... "Autohide, Windows can overlap the
Panel etc." there is no snaping issue
Cheers,
michail
On Mon, Jul 18, 2016 at 2:29 PM, Bhushan Shah wrote:
> Hello plasma team,
>
> I am not much happy to write this, but here it goes,
>
> Since last three Plasma release it always bugged me that there were no
> usefull changes in plasma-mediacenter, mostly because after being
> contracted by Bluesyst
> On Juni 24, 2016, 2:52 nachm., Andrey Bondrov wrote:
> > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done:
> > 1. KF 5.23.0
> > 2. Plasma 5.6.5
> > 3. MiminizeAll applet latest snapshot from github (May 31, 2016)
> > 4. ShowDesktop applet from Plasma 5.6.5.
> >
> > I ad
On Thursday, July 21, 2016 11:25:21 AM CEST Michail Vοurlakos wrote:
> Στις Πέμπτη, 21 Ιουλίου 2016 7:31:20 Π.Μ. EEST Martin Graesslin έγραψε:
> > On Wednesday, July 20, 2016 8:53:03 PM CEST Marco Martin wrote:
> > > On Wednesday 20 July 2016 21:15:33 Michail Vοurlakos wrote:
> > > > Hello,
> > > >
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:27:48 +
Build duration: 10 min
CHANGE SET
No changes
JUNIT RESULTS
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2241
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 08:27:49 +
Build duration: 1 min 1 sec
CHANGE SET
No changes
https://bugs.kde.org/show_bug.cgi?id=362198
--- Comment #5 from Ivan Čukić ---
Great that we got to the bottom of it. Issues like these are always the worst
ones to catch since you do not expect them. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Στις Πέμπτη, 21 Ιουλίου 2016 7:31:20 Π.Μ. EEST Martin Graesslin έγραψε:
> On Wednesday, July 20, 2016 8:53:03 PM CEST Marco Martin wrote:
> > On Wednesday 20 July 2016 21:15:33 Michail Vοurlakos wrote:
> > > Hello,
> > >
> > > I am trying to implement a plasmoid task manager that behaves
> > > lik
https://bugs.kde.org/show_bug.cgi?id=362198
Mebuntu changed:
What|Removed |Added
Resolution|--- |WORKSFORME
Status|UNCONFIRMED
Hi fellow plasma-developers,
we have a new repository called plasma-tests. This holds the test
orchestration from plasma-workspace/shell/tests.
The tests got moved there as they were always timing out on plasma-workspace
repository due to missing dependencies. In the new plasma-tests repository
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 07:09:25 +
Build duration: 5 min 32 sec
CHANGE SET
Revision 08c32339eb180759e54c1607d7aed
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 07:09:25 +
Build duration: 5 min 32 sec
CHANGE SET
Revision 08c32339eb180759e54c1607d7aed
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN56ce6689fda0: [platforms/virtual] Use rendernode or vgem
device if available for egl (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2216?vs=5294&id=5375#toc
REPOSITORY
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/205/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 06:36:17 +
Build duration: 26 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/205/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 21 Jul 2016 06:36:17 +
Build duration: 26 min
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
62 matches
Mail list logo
