Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread Yichao Yu
> On 六月 4, 2016, 4:02 p.m., Yichao Yu wrote: > > LGTM, this should be added to the configure UI. The tab for popup menu > > should work. The .ui file needs to be updated to include the checkbox for > > this and a corresponding rule should be added to the .cpp file (There > > should already be

[Differential] [Commented On] D1765: [KRunner] Disable high dpi scaling

2016-06-04 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. That's working round a genuine bug rather than fixing it. If it's in Qt, and you want to do this temporarily, go ahead and ship it. But you have to at least investigate first. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://ph

[Differential] [Updated] D1765: [KRunner] Disable high dpi scaling

2016-06-04 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1765 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, sebas _

[Differential] [Request, 3 lines] D1765: [KRunner] Disable high dpi scaling

2016-06-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It uses Plasma components

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread René J . V . Bertin
> On June 4, 2016, 10:02 p.m., Yichao Yu wrote: > > LGTM, this should be added to the configure UI. The tab for popup menu > > should work. The .ui file needs to be updated to include the checkbox for > > this and a corresponding rule should be added to the .cpp file (There > > should already

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/#review96189 --- LGTM, this should be added to the configure UI. The tab for p

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread René J . V . Bertin
> On June 4, 2016, 5:52 p.m., Yichao Yu wrote: > > qt4/style/qtcurve.cpp, line 6171 > > > > > > Hm? Shouldn't this use the option? Of course it should, thanks, missed that one. - René J.V. -

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/ --- (Updated June 4, 2016, 9:53 p.m.) Review request for KDE Software on Mac

[Differential] [Accepted] D1670: New login screen

2016-06-04 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Just fix those minor nitpicks and then good to go, thanks! INLINE COMMENTS > screenModel.qml:14 > > //We create two monitors here, the left one 8

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/#review96183 --- qt4/style/qtcurve.cpp (line 6171)

Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128097/ --- Review request for KDE Software on Mac OS X, Plasma and Yichao Yu. Reposi

Phabricator subprojects

2016-06-04 Thread Bhushan Shah
Hello people, Few days ago I learned about Phabricator sub projects, recent update of Phab allows to create sub projects of the project, which I believe Martin was waiting for quite sometime, so he can make KWin sub-project of the Plasma. So I want to suggest that we start using sub projects now,

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-06-04 Thread kdea
Oops, I meant: > But I have prioritized the reduction of effort required to create the new > page, just by cloning another page in https://www.opendesktop.org/ .     ___ Plasma-devel mailin

[Differential] [Accepted] D1755: [server] Trigger error if a transient request tries to parent to itself

2016-06-04 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH error-transient-surface REVISION DETAIL https://phabricator.kde.org/D1755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-06-04 Thread kdea
On Sun May 29 11:17:16 UTC 2016, Kevin Krammer wrote: > > They suggested me to upload the library to the "Qt Components" section > > of http://qt-apps.org/ , so I did it, and the library is now available > > to other developers. > > Wouldn't it make much more sense to register it with inqlude.o

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-06-04 Thread kdea
No answer for now :-( I have re-sent the message directly to their email account, instead of by web form.     Sent: Saturday, May 28, 2016 at 4:05 PM From: kdea To: plasma-devel@kde.org Subject: Re: Proposal: kde-libs.org, a repository of contributed libraries I'm copying here the message I hav

[Differential] [Accepted] D1747: Set ShellClient on all desktop depending on Plasma Surface role

2016-06-04 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH role-implies-on-all-desktops REVISION DETAIL https://phabricator.kde.org/D1747 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-06-04 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96182 --- Andreas already has most design bases covered. I'm not sure