Re: Plasma 5.6.4

2016-05-16 Thread Martin Graesslin
On Sunday, May 15, 2016 11:14:42 AM CEST Nicolas Lécureuil wrote: > Le 2016-05-10 21:06, Jonathan Riddell a écrit : > > Plasma 5.6.4 is now released > > https://www.kde.org/announcements/plasma-5.6.4.php > > > > More translations and useful bug fixes, highlights: > > > > Make sure kcrash is initi

[Differential] [Closed] D1604: Support touch events in DecorationEventFilter

2016-05-16 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN73fae5e63df3: Support touch events in DecorationEventFilter (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1604?vs=3798&id=3830 REVISION DET

[Differential] [Closed] D1605: [plugins/qpa] Add support for QT_WAYLAND_FORCE_DPI env variable

2016-05-16 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN1350653d4497: [plugins/qpa] Add support for QT_WAYLAND_FORCE_DPI env variable (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1605?vs=3803&id=

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/#review95519 --- kcms/componentchooser/componentchooserbrowser.cpp (line 101)

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 16, 2016, 10:52 p.m.) Review request for Plasma and David Fa

[Differential] [Accepted] D1617: Remove unused duplicated code

2016-05-16 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. Wow, that must have been dead code for ages. Good catch! REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://p

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated May 16, 2016, 9:49 p.m.) Review request for KDE Software on Mac

[Breeze] [Bug 363147] New: Breeze cursors should have more sizes (patch included)

2016-05-16 Thread James Lee via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363147 Bug ID: 363147 Summary: Breeze cursors should have more sizes (patch included) Product: Breeze Version: 5.6.4 Platform: Compiled Sources OS: Linux Status: UNCONFIRMED

[Differential] [Abandoned] D1616: Fix the intial panel width when using xmonad (and probably other tiling WMs).

2016-05-16 Thread tcberner (Tobias C. Berner)
tcberner abandoned this revision. tcberner added a comment. This issue seems to be fixed with the `resizePanel()` you mentioned that has appeared in `12f7cbf5`. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1616 EMAIL PREFERENCES https://pha

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

2016-05-16 Thread Marco Martin
On Monday 16 May 2016, David Faure wrote: > On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote: > > GENERAL INFO > > > > BUILD UNSTABLE > > Build URL: > > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/ > > PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated May 16, 2016, 3:21 p.m.) Review request for KDE Software on Mac

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

2016-05-16 Thread sitter (Harald Sitter)
sitter added a comment. alas, doesn't seem to work http://build.neon.kde.org/job/xenial_unstable_plasma_kde-cli-tools_adt/3/console REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 62 - Failure!

2016-05-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 12:31:53 + Build duration: 2 min 23 sec CHANGE SET Revision 99e278d7635986f3aa3cea19d9852680

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

2016-05-16 Thread Marco Martin
On Monday 16 May 2016, David Faure wrote: > > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

2016-05-16 Thread Marco Martin
On Monday 16 May 2016, David Faure wrote: > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure ico

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 89 - Still Unstable!

2016-05-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 10:32:12 + Build duration: 15 min CHANGE SET Revision 7d6fbfddafad4e3c0f994cec291d9f8bffd

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux, All, gcc - Build # 44 - Still Unstable!

2016-05-16 Thread David Faure
On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote: > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/ PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project: > PLATFORM=Linux,Variation=All,compiler=gcc > Date of bui

[Differential] [Request, 429 lines] D1617: Remove unused duplicated code

2016-05-16 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Mouse theme code is in kcms/cursortheme Some stuff seems to have been left TEST PLAN Still

Re: Review Request 127937: Use SAX instead of DOM for Plasma::Svg stylesheet replacement

2016-05-16 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127937/#review95504 --- Could you please benchmark this to make sure it's faster? Per

Review Request 127937: Use SAX instead of DOM for Plasma::Svg stylesheet replacement

2016-05-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127937/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Commented On] D1616: Fix the intial panel width when using xmonad (and probably other tiling WMs).

2016-05-16 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D1616#29853, @davidedmundson wrote: > As an alternate fix look at ::resizePanel and make sure the args to resize() is constrained within min and max size. Agree, that's the way to go REPOSITORY rPLASMAWORKSPACE Plasma Workspa

[Differential] [Accepted] D1604: Support touch events in DecorationEventFilter

2016-05-16 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH touch-input-decoration REVISION DETAIL https://phabricator.kde.org/D1604 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1604: Support touch events in DecorationEventFilter

2016-05-16 Thread mart (Marco Martin)
mart accepted this revision. REPOSITORY rKWIN KWin BRANCH touch-input-decoration REVISION DETAIL https://phabricator.kde.org/D1604 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel, sebas

[Differential] [Commented On] D1616: Fix the intial panel width when using xmonad (and probably other tiling WMs).

2016-05-16 Thread mart (Marco Martin)
mart added a comment. well, setLength, is pretty much a shortcut for setting the proper size (width or height) given the location.. i think the patch kinda makes sense REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1616 EMAIL PREFERENCES ht

[Differential] [Commented On] D1616: Fix the intial panel width when using xmonad (and probably other tiling WMs).

2016-05-16 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. As an alternate fix look at ::resizePanel and make sure the args to resize() is constrained within min and max size. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1616 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Requested Changes To] D1616: Fix the intial panel width when using xmonad (and probably other tiling WMs).

2016-05-16 Thread davidedmundson (David Edmundson)
davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. No. Length refers to the size of the contents of the panel. It should not be constrained by the user setti

Re: Review Request 127875: Selected state concept for icons

2016-05-16 Thread Marco Martin
> On May 15, 2016, 7:26 p.m., David Faure wrote: > > src/kiconloader.cpp, line 820 > > > > > > Could q->theme() be NULL here in some cases? > > See > > https://build.kde.org/job/khtml%20master%20kf5-qt5/PLAT

[Differential] [Request, 1 line] D1616: Fix the intial panel width when using xmonad (and probably other tiling WMs).

2016-05-16 Thread tcberner (Tobias C. Berner)
tcberner created this revision. tcberner added a reviewer: drosca. tcberner set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The function `PanelVie