[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

2016-05-15 Thread dfaure (David Faure)
dfaure added a comment. Haha, don't assume my code is stupid on purpose, it can also be stupid by oversight :-) I pushed a fix for kservice, can you check if it fixes your issue? http://commits.kde.org/kservice/f82de1626f8efdb56ca810fc827d40bf7eed4601 REPOSITORY rKDECLITOOLS KDE CLI

[Differential] [Changed Subscribers] D1366: Add Event Sounds stream to Applications list

2016-05-15 Thread markg (Mark Gaiser)
markg added inline comments. INLINE COMMENTS src/context.cpp:424 You can merge this one and the earlier isNew i think. Something like: ``` auto result = m_sinkInputs.data().constFind(eventRoleIndex); if (result == m_sinkInputs.data().constEnd()) { emit m_sinkInputs.added(

Re: Review Request 127875: Selected state concept for icons

2016-05-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95492 --- src/kiconloader.cpp (line 820)

Re: Plasma 5.6.4

2016-05-15 Thread Nicolas Lécureuil
Le 2016-05-10 21:06, Jonathan Riddell a écrit : Plasma 5.6.4 is now released https://www.kde.org/announcements/plasma-5.6.4.php More translations and useful bug fixes, highlights: Make sure kcrash is initialized for discover. Build Breeze Plymouth and Breeze Grub tars from correct branch [digi