[Differential] [Updated] D1595: Unmap PlasmaWindowInterface instead of deleting directly

graesslin added a dependency: D1594: Improve the deconstruction of PlasmaWindows. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1595 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas _

[Differential] [Updated] D1594: Improve the deconstruction of PlasmaWindows

graesslin added a dependent revision: D1595: Unmap PlasmaWindowInterface instead of deleting directly. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1594 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc:

Re: KWin in docker container for Plasma Mobile Emulator

On Wednesday, May 11, 2016 9:27:58 PM CEST Bhavisha Dhruve wrote: > On Wed, May 11, 2016 at 6:00 PM, Martin Graesslin > > wrote: > > Please enable all debug output for all kwin categories and used libraries > > (e.g. kwayland, kwindowsystem, etc.) and run kwin again. Then please > > provide > > t

[Differential] [Accepted] D1589: [Location Runner] Cleanup

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1589 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D1593: Remove superfluous KAuthorised check with new name

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. Where's the unlockedDesktop action defined? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricato

Re: Kirigami popup

On Tue, May 10, 2016 at 10:43 AM, Marco Martin wrote: > On Tuesday 10 May 2016 10:23:28 Martin Klapetek wrote: > > Hey, > > > > so in SpaceBar, there's a button that opens a 1/3-screen-height > > popup with emojis for the user to select. How should that be > > styled? I found no Kirigami componen

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/ --- (Updated May 12, 2016, 1:20 a.m.) Review request for KDE Frameworks, Plas

[Differential] [Request, 2 lines] D1593: Remove superfluous KAuthorised check with new name

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We already have code in plasma that will hide this action using the KAuthorised ID "plasma/pla

[Differential] [Abandoned] D1588: [Shell] Replace foreach by range-for where possible

broulik abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1588 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: apol, davidedmundson, plasma-devel, sebas

[Differential] [Commented On] D1588: [Shell] Replace foreach by range-for where possible

apol added a comment. In https://phabricator.kde.org/D1588#29377, @davidedmundson wrote: > maybe we can, but why? > > foreach is always correct > > for is sometimes correct > > what's the benefit? I tend to think along those lines... if it was actually a problem, it cou

[Differential] [Closed] D1587: [PanelShadows] Cache access to QX11Info::display()

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE54ef12d60194: [PanelShadows] Cache access to QX11Info::display() (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.or

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

colomar added a comment. Ah sorry, I overlooked the bug you mentioned. Alright, go ahead, then! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1592 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

broulik added a comment. You neven suggested this yourself in https://bugs.kde.org/show_bug.cgi?id=351592 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1592 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D1591: [Shell Runner] Add "Run in Terminal" option

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design Cc: plasma-devel, sebas __

[Differential] [Request, 128 lines] D1591: [Shell Runner] Add "Run in Terminal" option

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to run the gi

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

colomar added a comment. What's the reason for this feature? Have users complained about the popup? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1592 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

broulik added a comment. F124260: Screenshot_20160511_202641.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1592 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 18 lines] D1592: [Device Notifier] Add option to disable popup on new device

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 351592 FIXED-IN: 5

[Differential] [Request, 26 lines] D1589: [Location Runner] Cleanup

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use QStringRef where possible and remove

[Differential] [Request, 13 lines] D1590: [Places Runner] Add mimeDataForMatch

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to drag found places, like "

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

broulik added inline comments. INLINE COMMENTS applets/devicenotifier/package/contents/ui/devicenotifier.qml:171 Just noticed, that one is for the "You can now safely remove this device" or "Failed to mount device" which should still cause devicenotifier to open. REPOSITORY rPLASMAWORKSPACE

[Differential] [Commented On] D1591: [Shell Runner] Add "Run in Terminal" option

broulik added a comment. F124257: Screenshot_20160511_201045.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Commented On] D1591: [Shell Runner] Add "Run in Terminal" option

colomar added a comment. Yup, makes sense! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design Cc: colomar, plasma-devel, sebas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 79 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 17:45:48 + Build duration: 16 min CHANGE SET Revision 54ef12d60194910e0c688123392281cb64f

Re: Review Request 127893: [DialogShadows] Cache access to QX11Info::display()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127893/ --- (Updated May 11, 2016, 5:59 p.m.) Status -- This change has been mar

Re: Review Request 127893: [DialogShadows] Cache access to QX11Info::display()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127893/#review95385 --- Ship it! this code looks awfully familiar to something I j

[Differential] [Commented On] D1588: [Shell] Replace foreach by range-for where possible

davidedmundson added a comment. maybe we can, but why? foreach is always correct for is sometimes correct what's the benefit? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1588 EMAIL PREFERENCES https://phabricator.kde.org/sett

[Differential] [Commented On] D1588: [Shell] Replace foreach by range-for where possible

broulik added a comment. Not sure about m_env->corona()->containments() "this" is const but corona() is not, I see why apol wanted to use foreach all over the place :P but for the non-controversial parts like const auto foo; we can really do this... REPOSITORY rPLASMAWORKSPAC

[Differential] [Accepted] D1587: [PanelShadows] Cache access to QX11Info::display()

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1587 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Request, 36 lines] D1588: [Shell] Replace foreach by range-for where possible

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Either because we already have a const o

Review Request 127893: [DialogShadows] Cache access to QX11Info::display()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127893/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-framewor

[Differential] [Request, 25 lines] D1587: [PanelShadows] Cache access to QX11Info::display()

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's called several times and even in a

Re: KWin in docker container for Plasma Mobile Emulator

On Wed, May 11, 2016 at 6:00 PM, Martin Graesslin wrote: > > Please enable all debug output for all kwin categories and used libraries > (e.g. kwayland, kwindowsystem, etc.) and run kwin again. Then please > provide > the debug output to us. That should tell us more. > Here is the output: No ba

Re: Plasma 5.6.4

On Tue, May 10, 2016 at 08:06:32PM +0100, Jonathan Riddell wrote: > Plasma 5.6.4 is now released > https://www.kde.org/announcements/plasma-5.6.4.php > > More translations and useful bug fixes, highlights: > > Make sure kcrash is initialized for discover. > Build Breeze Plymouth and Breeze Grub

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 11, 2016, 12:12 p.m.) Review request for KDE Frameworks and

Re: KWin in docker container for Plasma Mobile Emulator

On Wednesday, May 11, 2016 4:06:37 PM CEST Bhavisha Dhruve wrote: > Hello, > > I am Bhavisha Dhruve a participant of gsoc. My project is to Devise the > Plasma-Mobile Emulator. The link for the same is: > https://summerofcode.withgoogle.com/projects/#4529407473483776 > > I've started with initi

[Differential] [Closed] D1545: [libinput] Support toggleTouchpad

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN5e284224eeba: [libinput] Support toggleTouchpad (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1545?vs=3720&id=3762 REVISION DETAIL https:

[Differential] [Closed] D1543: [libinput] Support for left-handed pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN254573bee11f: [libinput] Support for left-handed pointer (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1543?vs=3759&id=3760#toc REPOSITORY rKWIN KWin CHANGES SINCE

[Differential] [Closed] D1544: [lbinput] Support setting pointer acceleration

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN78c70a077532: [lbinput] Support setting pointer acceleration (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1544?vs=3719&id=3761#toc REPOSITORY rKWIN KWin CHANGES S

[Differential] [Accepted] D1543: [libinput] Support for left-handed pointer

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. INLINE COMMENTS libinput/connection.cpp:358 Ok, fine, at least cache constEnd() :) for (auto it = foo.constBegin(), end = foo.constEnd(); it != end; ++it) REPOSITORY rKWIN

[Differential] [Updated, 70 lines] D1543: [libinput] Support for left-handed pointer

graesslin updated this revision to Diff 3759. graesslin added a comment. Removed the weird reading of MouseButtonMapping settings REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1543?vs=3718&id=3759 BRANCH linput-left-handed REVISION DETAIL https://phabr

[Differential] [Commented On] D1543: [libinput] Support for left-handed pointer

graesslin added inline comments. INLINE COMMENTS libinput/connection.cpp:346 I tried to follow the logic of the mouse kcm which doesn't have a default. The idea would be to set the device default if nothing is configured. But as we don't do that one could indeed just change it to the one

[Differential] [Commented On] D1543: [libinput] Support for left-handed pointer

graesslin added inline comments. INLINE COMMENTS libinput/connection.cpp:358 I don't like the std::for_each that much as I find it difficult to use if one doesn't have a method to invoke. In this case I think putting the logic into a lambda is a little bit overhead. REPOSITORY rKWIN KWin R

[Differential] [Request, 178 lines] D1586: Delay maximize button click to next event cycle

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The delay to next cycle dance is needed for Aurorae. Maximizing a window can result in the decoration b

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 78 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/78/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 May 2016 11:10:21 + Build duration: 11 min CHANGE SET Revision 6abc546d30170c37163ba0ce1ae00415169

[Differential] [Closed] D1584: start struts timer in resizeEvent

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6abc546d3017: start struts timer in resizeEvent (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1584?vs

Re: Review Request 127875: Selected state concept for icons

> On May 11, 2016, 10:52 a.m., David Edmundson wrote: > > src/kiconloader.cpp, line 840 > > > > > > 1) For the unselected case, do you think we want Text and Base rather > > than Window and WindowText? > > f

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/#review95382 --- src/widgets/kfileitemdelegate.cpp (line 1220)

Re: Review Request 127888: use selected icon effect for current KPageView page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127888/#review95381 --- Ship it! - David Edmundson On May 10, 2016, 3:12 p.m., M

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95350 --- src/kiconloader.cpp (line 840)

KWin in docker container for Plasma Mobile Emulator

Hello, I am Bhavisha Dhruve a participant of gsoc. My project is to Devise the Plasma-Mobile Emulator. The link for the same is: https://summerofcode.withgoogle.com/projects/#4529407473483776 I've started with initial Dockerfile that can run kwin_wayland, it displays the window however it doesn

[Differential] [Commented On] D1543: [libinput] Support for left-handed pointer

broulik added inline comments. INLINE COMMENTS libinput/connection.cpp:346 Why this extra check? libinput/connection.cpp:358 std::for_each? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[plasmashell] [Bug 362924] Red battery icon shown for desktop pc

https://bugs.kde.org/show_bug.cgi?id=362924 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC|

[Powerdevil] [Bug 362924] Red battery icon shown for desktop pc

https://bugs.kde.org/show_bug.cgi?id=362924 --- Comment #6 from d...@post.com --- Created attachment 98893 --> https://bugs.kde.org/attachment.cgi?id=98893&action=edit Popup of the battery icon -- You are receiving this mail because: You are the assignee for the bug. __

[Powerdevil] [Bug 362924] Red battery icon shown for desktop pc

https://bugs.kde.org/show_bug.cgi?id=362924 --- Comment #5 from d...@post.com --- Created attachment 98892 --> https://bugs.kde.org/attachment.cgi?id=98892&action=edit Tooltip of the battery icon -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 362924] Red battery icon shown for desktop pc

https://bugs.kde.org/show_bug.cgi?id=362924 --- Comment #4 from d...@post.com --- Created attachment 98891 --> https://bugs.kde.org/attachment.cgi?id=98891&action=edit Battery icon in the panel -- You are receiving this mail because: You are the assignee for the bug. __

[Powerdevil] [Bug 362924] Red battery icon shown for desktop pc

https://bugs.kde.org/show_bug.cgi?id=362924 --- Comment #3 from d...@post.com --- Actually not, the icon is always visible in the panel (see screenshots). If this is the intended functionality, I see two problems: 1. Displaying always a red icon is misleading and suggests to the user, that there c