Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

> On May 6, 2016, 7:50 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 245 > > > > > > showing you the icon look up code from KWin, which is close to > > perfection (doesn't

Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

> On Май 6, 2016, 8:50 преди обяд, Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 245 > > > > > > showing you the icon look up code from KWin, which is close to > > perfection (d

[Differential] [Closed] D1538: [libinput] Add a wrapper class Device for a libinput_device

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4d7134f6c74a: [libinput] Add a wrapper class Device for a libinput_device (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1538?vs=3641&id=3654

[Differential] [Accepted] D1532: validate the config before checking if it can be applied

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. INLINE COMMENTS src/config.cpp:104 you don't need to add "canBeApplied" - the method name can be set through QT_MESSAGE_PATTERN REPOSITORY rLIBKSCREEN KScreen Library BR

[Differential] [Commented On] D1533: guard access to unsafe config pointer

graesslin added a comment. what about a test case for this? If it's too deep inside KScreen just push without. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1533 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, Plasm

[Differential] [Accepted] D1534: make the serializer a bit more robust

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. Thanks for adding the test case. I appreciate that! REPOSITORY rKSCREEN KScreen BRANCH sebas/fortifyserializer REVISION DETAIL https://ph

Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127826/#review95221 --- src/declarativeimports/core/windowthumbnail.cpp (line 245) <

[Differential] [Commented On] D1538: [libinput] Add a wrapper class Device for a libinput_device

graesslin added a comment. In https://phabricator.kde.org/D1538#28537, @sebas wrote: > Looks good to me. > > I've tested it on my laptop, and it shows all kind of devices, generally the output makes sense. When turning the laptop into tablet mode, nothing seems to happen to the keybo

Re: Review Request 127753: [taskmanager] Fixing typos

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127753/ --- (Updated Май 6, 2016, 6:25 преди обяд) Review request for Plasma, Kai Uwe

Re: boot logo

On Thu, May 5, 2016 at 4:14 PM, Marco Martin wrote: > On Thursday 05 May 2016 14:51:54 Jonathan Riddell wrote: >> 1cddf9ba2d38a671cbd2d2536d968aa366547281 switched the plymouth logo >> from KDE logo to Plasma logo >> >> Are there any plans to do the same on the ksplash theme? It seems >> strange

Re: Review Request 127842: take highlight and highlightedText from proper color group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/#review95212 --- Switching themes no longer properly updates the highlight col

[kio-extras] [Bug 362709] kio_sftp.cpp:1239]: (style) Suspicious condition

https://bugs.kde.org/show_bug.cgi?id=362709 Christoph Feck changed: What|Removed |Added Component|general |default Version|Git

Re: boot logo

On Thursday 05 May 2016 14:51:54 Jonathan Riddell wrote: > 1cddf9ba2d38a671cbd2d2536d968aa366547281 switched the plymouth logo > from KDE logo to Plasma logo > > Are there any plans to do the same on the ksplash theme? It seems > strange to have one logo in one screen and another logo in the next

boot logo

1cddf9ba2d38a671cbd2d2536d968aa366547281 switched the plymouth logo from KDE logo to Plasma logo Are there any plans to do the same on the ksplash theme? It seems strange to have one logo in one screen and another logo in the next screen. What should distro themers do? Jonathan

Re: Review Request 127842: take highlight and highlightedText from proper color group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/ --- (Updated May 5, 2016, 12:22 p.m.) Status -- This change has been mar

Re: Review Request 127842: take highlight and highlightedText from proper color group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/#review95200 --- Ship it! Ship It! - Sebastian Kügler On May 5, 2016, 9:

Re: Review Request 127842: take highlight and highlightedText from proper color group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/ --- (Updated May 5, 2016, 9:54 a.m.) Review request for KDE Frameworks and Pl

Review Request 127842: take highlight and highlightedText from proper color group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127842/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 73 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/73/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 May 2016 09:07:32 + Build duration: 17 min CHANGE SET Revision 97322fa45118c9ad4670a55288f1bd754ad

Re: Feedback on xdg-shell v5

On Fri, Apr 29, 2016 at 4:38 AM Martin Graesslin wrote: > On Thursday, April 28, 2016 5:36:58 PM CEST Jonas Ådahl wrote: > > On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote: > > > Hi Wayland and Plasma, > > > > > > I finished the implementation of xdg-shell in KWayland [1] and KW

[Differential] [Accepted] D1487: Don't depend on operation mode in WindowPixmap

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. Looks sensible. REPOSITORY rKWIN KWin BRANCH window-pixmap-improve-checks REVISION DETAIL https://phabricator.kde.org/D1487 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

Re: Feedback on xdg-shell v5

Hi, On 29 April 2016 at 10:37, Pekka Paalanen wrote: > On Fri, 29 Apr 2016 15:31:28 +0800 > Jonas Ådahl wrote: >> On Thu, Apr 28, 2016 at 02:08:07PM +0300, Pekka Paalanen wrote: >> > On Thu, 28 Apr 2016 17:36:58 +0800 >> > Jonas Ådahl wrote: >> > > Because you don't ping a surface, you ping the

[Differential] [Accepted] D1486: Only create damage_handle for Toplevel's without a Wayland Surface

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH damage-handle-only-create-no-surface REVISION DETAIL https://phabricator.kde.org/D1486 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Commented On] D1126: Remove Desktop.SystemSettings import

mart added a comment. fine for me, modulo just the >= REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1126 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, sebas Cc: sebas, mart, plasma-devel _