Re: Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127780/#review95003 --- src/platformtheme/khintssettings.cpp (line 58)

Re: Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127780/#review94999 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 28, 201

[Powerdevil] [Bug 361022] Laptop goes to sleep when closing lid even with an external display connected

https://bugs.kde.org/show_bug.cgi?id=361022 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote: > > You broke the zoomed out view, ie. in the year/decade overview you now get > > a tick at *every* cell... Oops, I'll fix, thanks. - Martin --- This is an automatically generated

Re: Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127780/#review94991 --- Ship it! Ship It! - Marco Martin On April 28, 2016, 4:3

Re: Review Request 127781: Remove clearly broken code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127781/#review94990 --- that was done for distributions, but wasn't supposed to be an

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94987 --- You broke the zoomed out view, ie. in the year/decade overvie

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 5:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94984 --- LGTM. Have we considered the implications of using such them

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 5:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 125648: Add method to run a script from DBus directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125648/#review94983 --- bump Marco you seemed to be leaning towards this, can I have

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 5:05 p.m.) Review request for KDE Frameworks and

Review Request 127781: Remove clearly broken code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127781/ --- Review request for Plasma. Repository: plasma-integration Description -

Review Request 127780: Don't open kdeglobals explicitly in font/hint settings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127780/ --- Review request for Plasma. Repository: plasma-integration Description -

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:08 p.m., Milian Wolff wrote: > > src/kiconloader.cpp, line 66 > > > > > > this and the line below should be rewritten to > > > > namespace { > > QString NULL_EFFECT_FINGERPRINT(

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:08 p.m., Milian Wolff wrote: > > src/kiconloader.cpp, line 66 > > > > > > this and the line below should be rewritten to > > > > namespace { > > QString NULL_EFFECT_FINGERPRINT(

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first vers

[Powerdevil] [Bug 361022] Laptop goes to sleep when closing lid even with an external display connected

https://bugs.kde.org/show_bug.cgi?id=361022 isk...@posteo.org changed: What|Removed |Added CC||isk...@posteo.org --- Comment #3 from isk...

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first vers

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first vers

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. > > Marco Martin wrote: > I have to get back to the first vers

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 825 > > > > > > maybe return contents? > > Marco Martin wrote: > contents of what? `return contents;` > On April 28,

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 2:01 p.m., Kai Uwe Broulik wrote: > > src/kiconloader.cpp, line 67 > > > > > > global statics in library are bad Or use Q_GLOBAL_STATIC - Aleix ---

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 870 > > > > > > I'd only use QBuffer in the case of svg. I have to get back to the first version of the patch with processS

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 3:52 p.m., Aleix Pol Gonzalez wrote: > > I like the idea, but I think it needs polishing still. > > > > Some kind of assessment about the performance impact would be very > > appreciated. Also could we get a test? It's an important feature... What impact will it have with

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94964 --- I like the idea, but I think it needs polishing still. Some

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 1:08 p.m., Milian Wolff wrote: > > src/kiconloader.cpp, line 66 > > > > > > this and the line below should be rewritten to > > > > namespace { > > QString NULL_EFFECT_FINGERPRINT(

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 27 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 13:04:29 + Build duration: 8 min 23 sec CHANGE SET Revision ef984a4cf8db89551f013

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94961 --- +1 on the idea and rest of the code, just a minor nitpick fro

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 12:19 p.m., Emmanuel Pescosta wrote: > > src/kiconloader.cpp, lines 843-845 > > > > > > Missing in the SVG path. > > > > IMHO it would be nicer if you put the SVG stuff into a new st

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 12:59 p.m.) Review request for KDE Frameworks an

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 12:58 p.m.) Review request for KDE Frameworks an

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94957 --- src/kiconloader.cpp (lines 843 - 845)

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review94956 --- Nice! > can i use karchive in this framework? KIconThemes i

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 11:53 a.m.) Review request for KDE Frameworks an

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 28, 2016, 11:52 a.m.) Review request for KDE Frameworks an

Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- Review request for KDE Frameworks and Plasma. Repository: kiconthemes D

[Differential] [Commented On] D1507: Add support for xdg-shell version 5 interface

graesslin added a comment. In https://phabricator.kde.org/D1507#27879, @mart wrote: > togerther Shellclient? wasn't in kwayland usually one different class implementation per protocol? this is KWin, not kwayland ;-) REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.k

Re: Review Request 127753: [toolbutton] Tool button disappear when move fast hover from him to task item in taskmanager

> On Април 28, 2016, 1:35 след обяд, Kai Uwe Broulik wrote: > > -1 I will discard it. This is the problem -> https://git.reviewboard.kde.org/r/127755/ if you can help with my comment above :) - Anthony --- This is an automatically gene

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

> On Април 28, 2016, 11:35 преди обяд, Thomas Pfeiffer wrote: > > Thank you for providing a screenshot! > > > > Now I just need to understand what problem this applet is supposed to solve. > > The original problem Sebas wanted to solve was that "Show Desktop" hid the > > panel. That has been fi

Re: Review Request 127753: [toolbutton] Tool button disappear when move fast hover from him to task item in taskmanager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127753/#review94951 --- -1 applets/taskmanager/package/contents/ui/ToolTipDelegate.

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 61 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 28 Apr 2016 09:10:33 + Build duration: 17 min CHANGE SET Revision 6b70416fac127a66055a28a2512f97dd8f0

[Differential] [Accepted] D1490: Don't call xcb_damage_subtract for Wayland windows

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH no-subtract-damage-for-wayland REVISION DETAIL https://phabricator.kde.org/D1490 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Closed] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6b70416fac12: [kioslave/desktop] Ensure there are no multiple / when creating the file path (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1507: Add support for xdg-shell version 5 interface

mart added a comment. togerther Shellclient? wasn't in kwayland usually one different class implementation per protocol? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1507 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graessli

[Differential] [Accepted] D1504: [Service Runner] Search for Jump List Actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS runners/services/servicerunner.cpp:266 is this context enough? it seems to imply this is always about web browser, wouldn't be better saying explicitly "this is about jum

[Differential] [Closed] D1456: Fix loading of widgetStyle in KHintsSettings

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONa58f4d180eab: Fix loading of widgetStyle in KHintsSettings (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE h

[Differential] [Closed] D1455: Auto-test to verify that the empty defaults are loaded correctly in KHintsSettings

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATION7fc4aa2329d5: Auto-test to verify that the empty defaults are loaded correctly in… (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANG

Feedback on xdg-shell v5

Hi Wayland and Plasma, I finished the implementation of xdg-shell in KWayland [1] and KWin [2]. Overall it was more straight forward than I would have expected. Especially the changes to KWin were surprisingly minor (with one huge exception). Now some questions/remarks: * What's a server suppos

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/#review94945 --- Thank you for providing a screenshot! Now I just need to und

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/ --- (Updated Април 28, 2016, 11:11 преди обяд) Review request for Plasma, KDE

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

> On Април 27, 2016, 1:56 след обяд, Thomas Pfeiffer wrote: > > As usual: No usability feedback without screenshot. Martin G wants usability in https://git.reviewboard.kde.org/r/123653/ because this plasmoid can be unusable. So screenshot is not something special, the plasmoid mostly place in

[Differential] [Updated] D1506: [server] Add support for xdg-shell

graesslin added a dependent revision: D1507: Add support for xdg-shell version 5 interface. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1506 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-deve

[Differential] [Updated] D1507: Add support for xdg-shell version 5 interface

graesslin added a dependency: D1506: [server] Add support for xdg-shell. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1507 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas ___

[Differential] [Request, 316 lines] D1507: Add support for xdg-shell version 5 interface

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The WaylandServer creates the XdgShellV5 interface and hooks it up to create a ShellSurface whenever an

[Differential] [Commented On] D1506: [server] Add support for xdg-shell

graesslin added a comment. The FindModule for WaylandProtocols is in https://git.reviewboard.kde.org/r/127694/ REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1506 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Request, 2,459 lines] D1506: [server] Add support for xdg-shell

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change introduces support for the unstable xdg-shell interface in the server. The implementation i

Re: Review Request 127753: [toolbutton] Tool button disappear when move fast hover from him to task item in taskmanager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127753/ --- (Updated Април 28, 2016, 10:13 преди обяд) Review request for Plasma, Kai