[Differential] [Updated, 2 lines] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

graesslin updated this revision to Diff 3534. graesslin added a comment. Just drop the added / when constructing local path REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1497?vs=3529&id=3534 BRANCH fix-kioslave-desktop REVISION DET

[Differential] [Accepted] D1499: add override to bufferForScreen

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH sebas/scene-qpainter-add-missing-override REVISION DETAIL https://phabricator.kde.org/D1499 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 2 lines] D1499: add override to bufferForScreen

sebas created this revision. sebas added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This seems to just have been forgotten here. TEST PLAN Builds REPOSITORY rKWIN KWin BRANCH sebas/scen

[Differential] [Updated] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

dfaure added a comment. I'm pretty sure it should work. What changed in QUrl is that setPath used to normalize the path and doesn't do that anymore. (qtbase commit 2e1de7f3c4ca). So in 5.5 the double slash got simplified to a single slash, while in 5.6 it stays and breaks the test. Not pu

[Differential] [Accepted] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1222 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 59 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/59/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 26 Apr 2016 16:13:15 + Build duration: 17 min CHANGE SET Revision d5494afe48a671383ac676802910c596847

Re: Kirigami: pageRow refactor ready for testing

On Friday 22 April 2016, Dirk Hohndel wrote: > > tried on the laptop so far, after a few fixes on the branch it seems to > > work fine (not super familiar on all aspects of the app tough) > > the only thing, i would then push the little change on the header api > > that caused problems, for which t

[Differential] [Closed] D1498: Fix memory leak in system tray

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd5494afe48a6: Fix memory leak in system tray (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1498?vs=3530&id=3531#toc REPOSITORY rPLASMAWORKSPACE Plas

[Differential] [Accepted] D1498: Fix memory leak in system tray

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. LGTM, thanks! REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1498 EMAIL PREFERENCES https://phabr

[Differential] [Commented On] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

graesslin added inline comments. INLINE COMMENTS kioslave/desktop/kio_desktop.cpp:161 > So it seems to me that just removing the '/' would be enough in practice. hmm, does that work also with older Qt (e.g. Qt 5.5)? Given that the test passes on Qt 5.5, but not on Qt 5.6, I fear that ther

[Differential] [Request, 33 lines] D1498: Fix memory leak in system tray

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently we leak an IconLoader for each icon for the time the system tray is in memory.

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 26 Apr 2016 14:58:49 + Build duration: 9 min 17 sec CHANGE SET Revision d0b017204f20bb012d5cf70cda5a1

[Differential] [Commented On] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

dfaure added inline comments. INLINE COMMENTS kioslave/desktop/kio_desktop.cpp:161 Can the path really *not* start with a '/' in this code ? From a QUrl point of view, it can happen with relative URLs ("desktop:foo.txt"), but we very rarely use that in KDE code, if at all (it's unusable wit

[Differential] [Commented On] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

graesslin added a comment. @dfaure I saw that you modified QUrl::setPath lately. Is this the correct approach here? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH fix-kioslave-desktop REVISION DETAIL https://phabricator.kde.org/D1497 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Updated] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

graesslin added a reviewer: dfaure. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH fix-kioslave-desktop REVISION DETAIL https://phabricator.kde.org/D1497 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hein, dfaure Cc: plasma-d

[Differential] [Accepted] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH fix-kioslave-desktop REVISION DETAIL https://phabricator.kde.org/D1497 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

Re: Review Request 127744: [taskmanager] ToolTipDelegate Dragon fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127744/#review94861 --- Stripping the reverse domain name is a no-no. The way this is

[Differential] [Request, 6 lines] D1497: [kioslave/desktop] Ensure there are no multiple / when creating the file path

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes failing test. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH fix-kioslave-desktop REVIS

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 57 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 26 Apr 2016 14:11:42 + Build duration: 9 min 26 sec CHANGE SET No changes JUNIT RESULTS Na

Plasma 5.7 Test Days prep meeting #3 notes & log

attendees: eike, jensreu, bshah, einar77, colomar, kbroulik chair: eike a) ISO status - Luca Beltrame (einar77) says stable base + latest KDE bits openSUSE ISOs should be available on the 19th -- [19:07] Sho_: http://download.opensuse.org/repositories/KDE:/Medias/images/iso/?P=openSUSE_Argon.x