Re: Review Request 127739: [Volume applet] Show application icon

2016-04-24 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127739/#review94826 --- https://git.reviewboard.kde.org/r/127467/ Sorry I didn't comm

Re: Review Request 127263: Add Wireless Energy Saving action

2016-04-24 Thread Jan Grulich
> On Dub. 24, 2016, 9:46 odp., Kai Uwe Broulik wrote: > > Thanks! I cannot push it until this gets solved too https://git.reviewboard.kde.org/r/127325/. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.

[Differential] [Accepted] D1476: Conditionally compile tests which depend on XCB_ICCCM

2016-04-24 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D1476 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, graesslin Cc: plasma-dev

[Differential] [Updated] D1478: [Notifications] Don't group job finished notifications

2016-04-24 Thread mck182 (Martin Klapetek)
mck182 added a comment. In https://phabricator.kde.org/D1478#27445, @colomar wrote: > Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore. > Only errors

Review Request 127739: [Volume applet] Show application icon

2016-04-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127739/ --- Review request for Plasma, KDE Usability and David Rosca. Repository: pla

Re: Review Request 127263: Add Wireless Energy Saving action

2016-04-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review94820 --- Ship it! Thanks! - Kai Uwe Broulik On März 9, 2016, 4:1

Re: Review Request 127263: Add Wireless Energy Saving action

2016-04-24 Thread Thomas Pfeiffer
> On March 9, 2016, 2:47 p.m., Thomas Pfeiffer wrote: > > Thank you for the screenshot! > > It looks good to me, the only thing I'd change is relabeling "Manual > > configuration" to "Leave unchanged" (and changing functionality if that > > isn't what it does atm) and putting that as the first

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

2016-04-24 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Why can we not make it scroll? REVISION DETAIL https://phabricator.kde.org/D1479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design, mck182 Cc: colomar, plasma-devel, sebas __

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

2016-04-24 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore. Only errors should be persistent. REPOSITORY rPLASMAWORKSPACE Plasma Workspac

[Differential] [Updated, 15 lines] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

2016-04-24 Thread broulik (Kai Uwe Broulik)
broulik removed rPLASMAWORKSPACE Plasma Workspace as the repository for this revision. broulik updated this revision to Diff 3498. broulik added a comment. Remove leftovers from other patch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1479?vs=3497&id=3498 REVISION DETAIL https:

[Differential] [Request, 111 lines] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

2016-04-24 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This limits the s

[Differential] [Request, 96 lines] D1478: [Notifications] Don't group job finished notifications

2016-04-24 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, mck182, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise you'll

Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

2016-04-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127734/ --- (Updated April 24, 2016, 10:22 p.m.) Review request for Plasma. Reposit

Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

2016-04-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127734/ --- Review request for Plasma. Repository: plasma-workspace Description ---

[Differential] [Request, 24 lines] D1476: Conditionally compile tests which depend on XCB_ICCCM

2016-04-24 Thread ltoscano (Luigi Toscano)
ltoscano created this revision. ltoscano added a reviewer: graesslin. ltoscano added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Move/Resize and Strut tests Wayland tests are affected. TEST PLAN Successful compilation when XCB_ICCCM is not foun

[Differential] [Request, 76 lines] D1475: [OSD] Load QML file on demand

2016-04-24 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik added a subscriber: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Started pla