[Differential] [Updated, 19 lines] D1291: Add microphone volume OSD

2016-04-15 Thread drosca (David Rosca)
drosca updated this revision to Diff 3373. drosca added a comment. Update to use new icons REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1291?vs=3072&id=3373 BRANCH mic-osd REVISION DETAIL https://phabricator.kde.org/D1291 AFFEC

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-04-15 Thread LUIS GUSTAVO BARRETO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review94644 --- src/plasma/corona.cpp (line 179)

[Differential] [Request, 23 lines] D1425: Disallow ptrace on greeter and kwin_wayland process on FreeBSD [... for the future]

2016-04-15 Thread tcberner (Tobias C. Berner)
tcberner created this revision. tcberner added reviewers: rakuco, graesslin. tcberner set the repository for this revision to rKWIN KWin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Similar to[[ https://phabricator.kde

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-15 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127631/ --- (Updated Април 15, 2016, 7:33 след обяд) Status -- This change has b

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-15 Thread Thomas Lübking
> On April 11, 2016, 5:45 vorm., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

[Differential] [Request, 19 lines] D1423: Disallow ptrace on polkit agent on FreeBSD

2016-04-15 Thread tcberner (Tobias C. Berner)
tcberner created this revision. tcberner added reviewers: rakuco, graesslin. tcberner set the repository for this revision to rPOLKITKDEAGENT Policykit (Polkit) KDE Agent. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY S

[Differential] [Commented On] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

2016-04-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS CMakeLists.txt:100 sorry, but my CMake foo is not sufficient to try to get this into a Find-module. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH lnf-virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1360 EMAIL PREFERE

[Differential] [Accepted] D1421: Warp the cursor pos to the specificed global position in a NET::Move request

2016-04-15 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH net-move-warp-pointer REVISION DETAIL https://phabricator.kde.org/D1421 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hein

[Differential] [Request, 92 lines] D1421: Warp the cursor pos to the specificed global position in a NET::Move request

2016-04-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The cursor position is the reference KWin uses while moving a window. If we don't warp the cursor

[Differential] [Commented On] D1418: Expose client shade state to kwayland's interface.

2016-04-15 Thread hein (Eike Hein)
hein added inline comments. INLINE COMMENTS abstract_client.cpp:651 Some info: https://howtospell.co.uk/droptheerule.php http://english.stackexchange.com/questions/55193/when-to-drop-the-e-when-ending-in-able It's a wash. kwin uses e here. kwayland actually has both e and no-e example

[Differential] [Commented On] D1418: Expose client shade state to kwayland's interface.

2016-04-15 Thread hein (Eike Hein)
hein added inline comments. INLINE COMMENTS abstract_client.cpp:651 I chose to go without the 'e' because kwayland has existing API in this style, e.g. IsMinimizable and IsMaximizable. Maybe there's some sort of orthography rule deciding when it's dropped and when it's kept ... REPOSITORY r

[Differential] [Commented On] D1418: Expose client shade state to kwayland's interface.

2016-04-15 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS abstract_client.cpp:652 for historic reasons in KWin it's called isShade and not isShaded REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1418 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Closed] D1415: Don't check for waylandServer() when accessing the platform in Compositor

2016-04-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4ef07494bd9c: Don't check for waylandServer() when accessing the platform in Compositor (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1415?v

[Differential] [Closed] D1413: Move the EglOnXBackend to the x11 platforms

2016-04-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN702b84b925d2: Move the EglOnXBackend to the x11 platforms (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1413?vs=3347&id=3357#toc REPOSITORY rKWIN KWin CHANGES SINC

[Differential] [Closed] D1416: Don't check window system when creating SceneQPainter

2016-04-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd47e206bebdc: Don't check window system when creating SceneQPainter (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1416?vs=3352&id=3360 REVI

[Differential] [Closed] D1414: Move clients/ to plugins/kdecorations/

2016-04-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINe4c333a372ae: Move clients/ to plugins/kdecorations/ (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1414?vs=3350&id=3359#toc REPOSITORY rKWIN KWin CHANGES SINCE LAS

[Differential] [Updated] D1414: Move clients/ to plugins/kdecorations/

2016-04-15 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rKWIN KWin BRANCH clients-to-plugins REVISION DETAIL https://phabricator.kde.org/D1414 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: sebas, plasma-devel

[Differential] [Accepted] D1416: Don't check window system when creating SceneQPainter

2016-04-15 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH scene-qpainter-no-wayland-check REVISION DETAIL https://phabricator.kde.org/D1416 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D1414: Move clients/ to plugins/kdecorations/

2016-04-15 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. INLINE COMMENTS plugins/CMakeLists.txt:6 spaces-- (also next line) REPOSITORY rKWIN KWin BRANCH clients-to-plugins REVISION DETAIL https://phabricator.kde.org/D1414 EMAIL PREFE

[Differential] [Commented On] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

2016-04-15 Thread Martin Gräßlin
graesslin added a comment. Thanks for accepting, but I haven't create the Find module yet ;-) REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH lnf-virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

plasma-mobile

2016-04-15 Thread Mēooarco Allegretti
Hello I would like to bring plasma-mobile on my device . I have access to the Stock Rom but the vendor does not provide me the binary blobs at this stage. Can anyone help me to extract them or to obtain a list of drivers to be extracted ? ___ Plasma-devel

[Differential] [Request, 445 lines] D1419: Move the WindowBasedEdge into the X11 platform and create Edge through Platform

2016-04-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove the AreaBasedEdge class No difference to Edge. Add ::window() and ::approachWindow as vi

[Differential] [Accepted] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

2016-04-15 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH lnf-virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1360 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Updated, 185 lines] D1417: Add window shade support to protocol, interfaces and test.

2016-04-15 Thread hein (Eike Hein)
hein updated this revision to Diff 3355. hein added a comment. - Add API version info; fix references to protocol version. REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1417?vs=3353&id=3355 BRANCH master REVISION DETAIL https://phabricator.kde.

[Plasma Workspace Wallpapers] [Bug 361778] 4k default wallpaper

2016-04-15 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361778 Sebastian Kügler changed: What|Removed |Added Severity|wishlist|normal Status|UNCONFIRMED

[Differential] [Requested Changes To] D1417: Add window shade support to protocol, interfaces and test.

2016-04-15 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. In Registry you need to adjust: {Registry::Interface::PlasmaWindowManagement, { 2, QByteArrayLiteral("org_kde_plasma_window_management"), &o

[Differential] [Updated] D1417: Add window shade support to protocol, interfaces and test.

2016-04-15 Thread hein (Eike Hein)
hein added a dependent revision: D1418: Expose client shade state to kwayland's interface.. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1417 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin Cc: plasma-devel,

[Differential] [Request, 8 lines] D1418: Expose client shade state to kwayland's interface.

2016-04-15 Thread hein (Eike Hein)
hein created this revision. hein added a reviewer: graesslin. hein added a subscriber: plasma-devel. hein added a dependency: D1417: Add window shade support to protocol, interfaces and test.. Restricted Application added a project: Plasma. REVISION SUMMARY Makes use of new API in kwayland to e

[Differential] [Request, 163 lines] D1417: Add window shade support to protocol, interfaces and test.

2016-04-15 Thread hein (Eike Hein)
hein created this revision. hein added a reviewer: graesslin. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This adds support for 'shadable' and 'shaded' states to the protocol and to the client and server classes, as well as the window

[Differential] [Request, 18 lines] D1416: Don't check window system when creating SceneQPainter

2016-04-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For one SceneQPainter is only used on Wayland and it can be created through the Platform, so no differe

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-15 Thread Andreas Hartmetz
> On April 11, 2016, 5:45 a.m., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-15 Thread Thomas Lübking
> On April 11, 2016, 5:45 vorm., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

2016-04-15 Thread Andreas Hartmetz
> On April 11, 2016, 5:45 a.m., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

Re: Taking over KRunner maintainership

2016-04-15 Thread Ivan Čukić
Hi Kai, Great news! Strangely enough, this is something I talked to Marco about during the CERN sprint, so it is nice to see that you are the maintainer both defacto and de jure :) As far as the architecture is concerned (Sprinter, or something else), that is probably worth looking into. I was pl

[Differential] [Request, 11,959 lines] D1414: Move clients/ to plugins/kdecorations/

2016-04-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KWin's plugins are now all in a plugins subdirectory. This is a good argument to also move the window d

Re: Review Request 127652: ScrollArea: Fix warning when contentItem is not Flickable

2016-04-15 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127652/ --- (Updated April 15, 2016, 8:35 a.m.) Status -- This change has been m

Review Request for KWayland for inclusion in frameworks

2016-04-15 Thread Martin Graesslin
Hi frameworks-developers, based on the thread "KWayland as framework" [1] I want to start the review process for including KWayland into frameworks. To make it easier I'm giving an overview: Policies [2]: * Tier 1/integration - dependencies on Qt::Gui (5.4) and Wayland (1.7) * directory structur

[Differential] [Closed] D1341: Add metainfo.yaml as needed for frameworks

2016-04-15 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND3bec31abdd41: Add metainfo.yaml as needed for frameworks (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1341?vs=3186&id=3349 REV

[Differential] [Accepted] D1341: Add metainfo.yaml as needed for frameworks

2016-04-15 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH metainfo REVISION DETAIL https://phabricator.kde.org/D1341 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ T