RFC: A Wayland virtual framebuffer server for our tests

Hi Plasmates, this week I spent some thoughts on how we can do something like Xvfb with Wayland. The reasoning is simple: we need to run our test cases also on Wayland and not just on X11. Currently something like this doesn't really exist so we might need to write it. I have a few ideas how it

[Differential] [Commented On] D1412: [kdecoration] Give a proper name to the Oxygen window decoration

graesslin added a comment. Before change: F109459: deco-names-old.png After change: F109461: Spectacle.V24001.png REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D1412 EMAIL PRE

[Differential] [Changed Subscribers] D1411: [kdecoration] Give a proper name to the Breeze window decoration

graesslin added a subscriber: plasma-devel. graesslin added a project: Plasma. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D1411 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hpereiradacosta Cc: plasma-devel

[Differential] [Request, 4 lines] D1412: [kdecoration] Give a proper name to the Oxygen window decoration

graesslin created this revision. graesslin added reviewers: Plasma, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The deco did not define the name, so in the listing the plugin id was used. With this c

Re: Review Request 123653: New Minimize Windows Plasmoid

> On Април 14, 2016, 2:37 след обяд, Martin Gräßlin wrote: > > applets/minimizeall/plugin/minimizeall.h, line 49 > > > > > > I'm not convinced that keeping the minimized windows in a list. As > > explained: this

Re: Review Request 123653: New Minimize Windows Plasmoid

> On April 14, 2016, 1:37 p.m., Martin Gräßlin wrote: > > applets/minimizeall/plugin/minimizeall.h, line 49 > > > > > > I'm not convinced that keeping the minimized windows in a list. As > > explained: this was a

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94624 --- Looks good! src/declarativeimports/calendar/daysmodel.h (li

[Differential] [Closed] D1392: Move glxbackend to x11 standalone plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN248991223b19: Move glxbackend to x11 standalone plugin (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1392?vs=3334&id=3344#toc REPOSITORY rKWIN KWin CHANGES SINCE L

[Differential] [Closed] D1409: [autotest] Add test for PlasmaWindowModel

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDe1a7a37f1fc3: [autotest] Add test for PlasmaWindowModel (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1409?vs=3340&id=3343 REVI

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/ --- (Updated Април 15, 2016, 7:05 преди обяд) Review request for Plasma, KDE

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On Април 11, 2016, 8:45 преди обяд, Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/ --- (Updated April 15, 2016, 4:28 a.m.) Review request for KDE Frameworks and

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 10:28 a.m., Marco Martin wrote: > > what's the status of this? > > Martin Klapetek wrote: > Working on it. > > Martin Klapetek wrote: > Ok so I'm unable to render that svg, it is properly installed > and everything, but this doesn't show anything (not even error

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 10:28 a.m., Marco Martin wrote: > > what's the status of this? > > Martin Klapetek wrote: > Working on it. > > Martin Klapetek wrote: > Ok so I'm unable to render that svg, it is properly installed > and everything, but this doesn't show anything (not even error

Re: Review Request 127652: ScrollArea: Fix warning when contentItem is not Flickable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127652/#review94617 --- Ship it! - David Edmundson On April 14, 2016, 6:46 p.m.,

Re: Taking over KRunner maintainership

On Fri, Apr 15, 2016 at 12:13 AM, Kai Uwe Broulik wrote: > Hi all, > > as was already briefly mentioned in the Plasma hangout this Monday Vishesh > asked me to take over maintainership of KRunner and I'm willing to accept. > > While I am not confident to have the skills required to really move fo

Taking over KRunner maintainership

Hi all,as was already briefly mentioned in the Plasma hangout this Monday Vishesh asked me to take over maintainership of KRunner and I'm willing to accept.While I am not confident to have the skills required to really move forward KRunner's architecture (cf. Sprinter) I had already been the de-fa

[Plasma Workspace Wallpapers] [Bug 361778] New: 4k default wallpaper

https://bugs.kde.org/show_bug.cgi?id=361778 Bug ID: 361778 Summary: 4k default wallpaper Product: Plasma Workspace Wallpapers Version: unspecified Platform: Neon Packages OS: Linux Status: UNCONFIRMED Seve

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/#review94614 --- applets/minimizeall/package/metadata.desktop (line 3)

Review Request 127652: ScrollArea: Fix warning when contentItem is not Flickable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127652/ --- Review request for Plasma and David Edmundson. Repository: plasma-framewo

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On April 11, 2016, 5:45 vorm., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

[Differential] [Closed] D1393: Refactor models

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA9b4cb4957bbc: Refactor models (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1393?vs=3302&id=3341 REVISION DETAIL

Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127651/ --- Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian Küg

Re: hail to the new plasma-pa maintainer

On Thursday 14 April 2016 14:02:50 Sebastian Kügler wrote: > Hi all, > > David has been working tirelessly on plasma-pa, our pulseaudio volume > controller applet. Since by now, he understands the code much better than me > (the current maintainer), it's only fair to transfer maintainership to him

Re: Review Request 123653: New Minimize Windows Plasmoid

> On Април 14, 2016, 2:37 след обяд, Martin Gräßlin wrote: > > I will make separate review request for this. > On Април 14, 2016, 2:37 след обяд, Martin Gräßlin wrote: > > applets/minimizeall/plugin/minimizeall.h, line 49 > >

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On Април 11, 2016, 8:45 преди обяд, Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote

[Differential] [Accepted] D1409: [autotest] Add test for PlasmaWindowModel

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH test-plasma-window-model REVISION DETAIL https://phabricator.kde.org/D1409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Pl

[Differential] [Request, 581 lines] D1409: [autotest] Add test for PlasmaWindowModel

graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKWAYLAND KWayland BRANCH test-plasma-window-model REVISION DETAIL https://phabricator.kde.org/D1409

Re: Review Request 127623: [digital-clock] Fix display of seconds with certain locales

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127623/ --- (Updated April 14, 2016, 3:11 nachm.) Review request for Plasma, Kai Uwe

Re: Review Request 127646: Add a placement property to Menu and make use of it in a new openRelative() invokable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127646/ --- (Updated April 14, 2016, 3:12 p.m.) Status -- This change has been m

[Differential] [Commented On] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

sebas added inline comments. INLINE COMMENTS CMakeLists.txt:100 Other than E-C-M, not really. You can just put it here and perhaps copy it into plasma-workspace for now, it's simple enough so that it shouldn't cause a lot of churn. Once more people are interested, it can perhaps still go

Re: [Kde-hardware-devel] hail to the new plasma-pa maintainer

Good luck David ! On Thu, Apr 14, 2016 at 2:32 PM, Lamarque Souza wrote: > > > On Thu, Apr 14, 2016 at 9:02 AM, Sebastian Kügler wrote: > >> Hi all, >> >> David has been working tirelessly on plasma-pa, our pulseaudio volume >> controller applet. Since by now, he understands the code much bette

Re: [Kde-hardware-devel] hail to the new plasma-pa maintainer

On Thu, Apr 14, 2016 at 9:02 AM, Sebastian Kügler wrote: > Hi all, > > David has been working tirelessly on plasma-pa, our pulseaudio volume > controller applet. Since by now, he understands the code much better than > me > (the current maintainer), it's only fair to transfer maintainership to hi

[Differential] [Accepted] D1393: Refactor models

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. nice job REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH models-rewrite REVISION DETAIL https://phabricator.kde.org/D1393 EMAIL PREFERENCES htt

[Differential] [Updated] D1392: Move glxbackend to x11 standalone plugin

graesslin marked an inline comment as done. REPOSITORY rKWIN KWin BRANCH glxbackend-in-platform REVISION DETAIL https://phabricator.kde.org/D1392 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: sebas, plasma-devel

[Differential] [Accepted] D1392: Move glxbackend to x11 standalone plugin

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. INLINE COMMENTS plugins/platforms/x11/standalone/x11_platform.cpp:62 Might as well move this line up above the "case "GlxPlatformInterface:, makes it more logical. No need to suppl

[Differential] [Updated, 356 lines] D1392: Move glxbackend to x11 standalone plugin

graesslin updated this revision to Diff 3334. graesslin added a comment. Reworked the X11StandalonePlatform::createOpenGLBackend() to compile also when HAVE_EPOXY_GLX is not set. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1392?vs=3296&id=3334 BRANCH

[Differential] [Commented On] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

graesslin added inline comments. INLINE COMMENTS CMakeLists.txt:100 yeah might be a good idea, any idea where we could put it to share it between kscreenlocker and plasma-workspace? lookandfeel/contents/lockscreen/LockScreen.qml:33 > Where is this set to true? see https://phabricator.kde

hail to the new plasma-pa maintainer

Hi all, David has been working tirelessly on plasma-pa, our pulseaudio volume controller applet. Since by now, he understands the code much better than me (the current maintainer), it's only fair to transfer maintainership to him. So, please applaud the new maintainer of plasma-pa: David Rosca.

[Differential] [Commented On] D1392: Move glxbackend to x11 standalone plugin

graesslin added inline comments. INLINE COMMENTS plugins/platforms/x11/standalone/x11_platform.cpp:62 I also stumbled over this when moving the code. I decided to leave it as it is for the move. But yeah there is clearly a problem as it would no longer compile with the dependency missing.

[Differential] [Closed] D1399: [shell] Commit surface after removing it's shadow

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE1d0ee7c88d10: [shell] Commit surface after removing it's shadow (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

Re: Review Request 123653: New Minimize Windows Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review94605 --- applets/minimizeall/plugin/minimizeall.h (line 49)

[Differential] [Closed] D1397: Depend on Breeze to set the default style name

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATION70049ac737aa: Depend on Breeze to set the default style name (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1397?vs=3309&id=3332#toc REPOSITORY rPLASMAI

[Differential] [Closed] D1403: [autotest] Extend test to verify the code which handles buffer deletions

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDd651a3e03458: [autotest] Extend test to verify the code which handles buffer deletions (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.

[Differential] [Accepted] D1403: [autotest] Extend test to verify the code which handles buffer deletions

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH test-destroy-buffer REVISION DETAIL https://phabricator.kde.org/D1403 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Accepted] D1399: [shell] Commit surface after removing it's shadow

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH panelshadow-remove REVISION DETAIL https://phabricator.kde.org/D1399 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

Re: Review Request 123653: New Minimize Windows Plasmoid

[I put plasma-devel back in CC:] On Thursday, April 14, 2016 01:14:26 PM you wrote: > Yeah, i know it can't be downloaded because it's need to be compiled. > It's not a problem, from my side, to add in kde' repo, i have dev access, > but i don't know where to push it etc. Original review puts

[Differential] [Accepted] D1397: Depend on Breeze to set the default style name

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH depend-on-breeze REVISION DETAIL https://phabricator.kde.org/D1397 EMAIL PREFERENCES https://phabr

Re: Review Request 123653: New Minimize Windows Plasmoid

Hi Anthony, On Wednesday, April 13, 2016 06:00:24 PM Anthony Fieroni wrote: > This applet is must have for many users, let's make'm happy :) => > http://kde-look.org/content/show.php/Minimize+All?content=175817 I had discarded this review request since I didn't have time to maintain the applet a

[Differential] [Updated, 138 lines] D1402: add X11Integration for xcb qpa workarounds

mart removed rPLASMAINTEGRATION Integration for Qt applications in Plasma as the repository for this revision. mart updated this revision to Diff 3328. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1402?vs=3321&id=3328 REVISION DETAIL https://phabricator.kde.org/D1402 AFFECTED FILE

[Differential] [Closed] D1402: add X11Integration for xcb qpa workarounds

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATION3500c766f107: add X11Integration for xcb qpa workarounds (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1402?vs=3328&id=3329#toc REPOSITORY rPLASMAINTEG

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 8:28 a.m., Marco Martin wrote: > > what's the status of this? > > Martin Klapetek wrote: > Working on it. > > Martin Klapetek wrote: > Ok so I'm unable to render that svg, it is properly installed > and everything, but this doesn't show anything (not even error)

Re: Review Request 127646: Add a placement property to Menu and make use of it in a new openRelative() invokable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127646/#review94601 --- Ship it! Ship It! - Marco Martin On April 13, 2016, 9:2