Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/ --- (Updated Фев. 6, 2016, 9:19 преди обяд) Status -- This change has be

Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126811/ --- (Updated Feb. 6, 2016, 2 a.m.) Review request for Plasma. Changes -

Re: Review Request 126995: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126995/#review92110 --- Ship it! Ship It! - David Edmundson On Feb. 5, 2016, 8:

Re: Review Request 126996: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/#review92109 --- Fix it, then Ship it! One minor question imports/activit

Re: Review Request 126994: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92108 --- dataengines/CMakeLists.txt (line 30)

[PATCH] ActionButton.qml: centre-align the clickable part of the button

ActionButton.qml: centre-align the clickable part of the button buttonGraphics.x refers to the centre of the action button. For the click to be within the central area of the button, mouse.x needs to be between: buttonGraphics.x - buttonGraphics.width / 2, and buttonGraphics.x + bu

Review Request 126996: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 126995: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126995/#review92107 --- +1 - Marco Martin On Feb. 5, 2016, 8:25 p.m., Aleix Pol Go

Re: Review Request 126994: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92106 --- I suppose that getting rid of KDELibs4Support isn't a bad thi

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 418 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/418/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 20:36:13 + Build duration: 5 min 4 sec CHANGE SET Revision efdb5e97d975a0f86e42b37e81d693

Re: Review Request 126994: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/#review92105 --- drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cp

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 7:58 p.m., Aleix Pol Gonzalez wrote: > > It's only on your system because for some reason you are probably not > > including KDELibs4Support. > > > > It should be something like this, but it isn't: > > https://paste.kde.org/pv12ioe89 > > René J.V. Bertin wrote: > I inde

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/ --- (Updated Feb. 5, 2016, 9:35 p.m.) Status -- This change has been mar

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 7:58 p.m., Aleix Pol Gonzalez wrote: > > It's only on your system because for some reason you are probably not > > including KDELibs4Support. > > > > It should be something like this, but it isn't: > > https://paste.kde.org/pv12ioe89 I indeed removed the reference to KDELib

Review Request 126995: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126995/ --- Review request for Plasma. Repository: kio-extras Description ---

Review Request 126994: Drop usage of Qt4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126994/ --- Review request for Plasma and René J.V. Bertin. Repository: plasma-worksp

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 417 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/417/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 19:35:18 + Build duration: 6 min 40 sec CHANGE SET Revision 638897d0432f69db73f152d30f83b

Re: Restoring weather applet in kdeplasma-addons

On Friday 05 February 2016 18:39:00 Friedrich W. H. Kossebau wrote: > > I see. And found it now, plasma-workspace/dataengines/weather. Seems it > was started in 2014, but then lost focus of developers. Some "ions" > library is installed, but the dataengine plugin itself is not even build. > > Wil

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/#review92098 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 5, 2016,

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/#review92097 --- It's only on your system because for some reason you are prob

Re: Restoring weather applet in kdeplasma-addons

On Friday 05 February 2016 18:39:00 Friedrich W. H. Kossebau wrote: > Hi Martin, > > I see. And found it now, plasma-workspace/dataengines/weather. Seems it > was started in 2014, but then lost focus of developers. Some "ions" > library is installed, but the dataengine plugin itself is not even bu

Re: Restoring weather applet in kdeplasma-addons

Hi Martin, Am Freitag, 5. Februar 2016, 17:05:43 CET schrieb Marco Martin: > On Friday 05 February 2016 16:23:38 Friedrich W. H. Kossebau wrote: > > Hi, > > > > I am missing the weather applet in my Plasma5 workspace. I found the > > sources in kdeplasma-addons/applets/weather, but it seems not y

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/ --- (Updated Feb. 5, 2016, 6:18 p.m.) Review request for KDE Software on Mac

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote: > > drkonqi/drkonqi.cpp, lines 183-188 > > > > > > yes this is possible and there is even a Krazy check for this. The > > QWeakPointer is the proper fix to thi

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote: > > drkonqi/drkonqi.cpp, lines 183-188 > > > > > > yes this is possible and there is even a Krazy check for this. The > > QWeakPointer is the proper fix to thi

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote: > > drkonqi/drkonqi.cpp, lines 183-188 > > > > > > yes this is possible and there is even a Krazy check for this. The > > QWeakPointer is the proper fix to thi

Re: Restoring weather applet in kdeplasma-addons

On Friday 05 February 2016 16:23:38 Friedrich W. H. Kossebau wrote: > Hi, > > I am missing the weather applet in my Plasma5 workspace. I found the > sources in kdeplasma-addons/applets/weather, but it seems not yet ported > and is disabled from the build. > > So I would see to port it over now my

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote: > > drkonqi/drkonqi.cpp, lines 183-188 > > > > > > yes this is possible and there is even a Krazy check for this. The > > QWeakPointer is the proper fix to thi

Restoring weather applet in kdeplasma-addons

Hi, I am missing the weather applet in my Plasma5 workspace. I found the sources in kdeplasma-addons/applets/weather, but it seems not yet ported and is disabled from the build. So I would see to port it over now myself. A few questions I have: Q1: Is anyone already looking into it? Any gener

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 3:57 p.m., Martin Gräßlin wrote: > > drkonqi/drkonqi.cpp, lines 183-188 > > > > > > yes this is possible and there is even a Krazy check for this. The > > QWeakPointer is the proper fix to thi

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/#review92090 --- drkonqi/drkonqi.cpp (lines 179 - 184)

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 6:59 p.m., Bhushan Shah wrote: > > drkonqi/CMakeLists.txt, line 86 > > > > > > Erm wait, drkonqi is gui program, no? > > René J.V. Bertin wrote: > Yes, but: > - on Linux, that statement

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/ --- (Updated Feb. 5, 2016, 3:13 p.m.) Review request for KDE Software on Mac

Re: Review Request 126993: drkonqi : fix build errors and build nongui

> On Feb. 5, 2016, 2:29 p.m., Bhushan Shah wrote: > > drkonqi/CMakeLists.txt, line 86 > > > > > > Erm wait, drkonqi is gui program, no? Yes, but: - on Linux, that statement does nothing AFAIK (drkonqi continues t

[Differential] [Accepted] D908: [Baloo Runner] Add mime data to matches

vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. I'm guessing this is for drag and drop. Seems fairly straightforward. INLINE COMMENTS runners/baloo/baloosearchrunner.cpp:180 I don't think this is required. From the QMimeData d

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/#review92087 --- drkonqi/CMakeLists.txt (line 86)

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/#review92085 --- The QLatin1String changes look fine given fromAscii is deprec

Re: Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/#review92084 --- Not sure if this is related, but when drkonqi is launched bec

Review Request 126993: drkonqi : fix build errors and build nongui

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126993/ --- Review request for KDE Software on Mac OS X and Plasma. Repository: plasm

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote: > > Nice to see this applet coming back! > > > > I was wondering if there could be more code shared between this applet and > > our image wallpaper, perhaps even "just" allow the image wallpaper to > > function also as an applet. > > > > You ha

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/ --- (Updated Feb. 5, 2016, 12:47 p.m.) Review request for Plasma. Changes -

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote: > > applets/mediaframe/package/contents/config/main.xml, line 9 > > > > > > Where does this come from? I've set that value based on what I found a resonable default

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 56 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 05 Feb 2016 11:58:30 + Build duration: 1 min 47 sec CHANGE SET Revision fe639d4e3f9f4d240d9

Re: Review Request 126952: Set layout in kickoff config properly

> On Feb. 2, 2016, 9:29 a.m., Marco Martin wrote: > > applets/kickoff/package/contents/ui/ConfigGeneral.qml, line 39 > > > > > > maybe look and feel package? > > David Edmundson wrote: > right, but all I'm ch

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review92078 --- Ship it! Ship It! - Andrew Lake On Feb. 4, 2016, 11:19

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

> On Feb. 2, 2016, 9:22 a.m., Marco Martin wrote: > > hmm, i don't think i like the back/forward buttons both at the right, it > > looked more nicely symmetric before > > Kai Uwe Broulik wrote: > It also reduces mouse travel :) Placing the "Previous" button left of the > month name would l

Re: QWeakPointer error in DrKonqi

Aleix Pol wrote: > Maybe you can provide the fixes in the shape of a review request? I'm > sure that if somebody found this they would have fixed it before. > > I really have no idea why these issues didn't pop up on my set up but > did on yours anyway. That's weird indeed. I just tried to buil

Feature: remove application by dragging it over the trash icon

Hi, i have discussed this a bit with mck182 and Sho at #plasma IRC channel but i would also other developers to share their opinion abut this feature: mac os allows their users to drag an app icon over the trash and than it gets removed/uninstall. It would be great to have similar functionali