Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-23 Thread Kai Uwe Broulik
> On Jan. 21, 2016, 11:06 vorm., Marco Martin wrote: > > I'm in general in favor of that, mostly for the scenario we find some > > actual rendering bug in the svg rendering code, that then gets cached Is there a better way to store the version? I recall in KCache or so you can store custom pro

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 52 - Still Failing!

2016-01-23 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 23 Jan 2016 13:21:53 + Build duration: 1 min 3 sec CHANGE SET Revision e85aecd08eb4787d349b

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 58 - Still Failing!

2016-01-23 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 23 Jan 2016 13:21:08 + Build duration: 6 min 0 sec CHANGE SET Revision 6f57bbcce2812894f5ba16

[Differential] [Accepted] D851: Port kded plugin to json metadata

2016-01-23 Thread arichardson (Alex Richardson)
arichardson accepted this revision. arichardson added a reviewer: arichardson. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me once the JSON has been changed to use bool INLINE COMMENTS kwrited.json:154 This and the following should be a boolean n

[Powerdevil] [Bug 337674] kded5 is eating CPU

2016-01-23 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #86 from mif...@gmail.com --- (In reply to Francesco from comment #85) > Same here, same bt. Powerdevil 5.5.3 on gentoo amd64. Oh, yep, I use Gentoo too, ~amd64 profile. -- You are receiving this mail because: You are the assignee for the b

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/ --- (Updated Jan. 23, 2016, 3 p.m.) Review request for kde-workspace and Plas

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Kai Uwe Broulik
> On Jan. 23, 2016, 1:22 nachm., Kai Uwe Broulik wrote: > > id isn't particularly better either as that's also a reserved QML keyword. > > > > Also, you can access any role with a name clash by accessing it through > > "model", ie. model.index > > Daniel Faust wrote: > id is the first thin

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
> On Jan. 23, 2016, 2:22 p.m., Kai Uwe Broulik wrote: > > id isn't particularly better either as that's also a reserved QML keyword. > > > > Also, you can access any role with a name clash by accessing it through > > "model", ie. model.index id is the first thing that came to mind, of cause it

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/#review91476 --- id isn't particularly better either as that's also a reserved

Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/ --- Review request for kde-workspace and Plasma. Repository: plasma-workspace

Re: Review Request 120566: Remove CMake cruft.

2016-01-23 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120566/ --- (Updated Jan. 23, 2016, 8:37 a.m.) Status -- This change has been ma

Re: Review Request 120566: Remove CMake cruft.

2016-01-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120566/#review91459 --- Ship it! Ship It! - Martin Gräßlin On Jan. 22, 2016, 7: