Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2015-12-16 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89632 --- Ship it! Ship It! - Lamarque Souza On Dec. 16, 2015, 10:21

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2015-12-16 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89631 --- vpn/l2tp/l2tpwidget.cpp (line 177)

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Sebastian Kügler
> On Dec. 16, 2015, 7:29 p.m., Daniel Vrátil wrote: > > autotests/testkwaylandbackend.cpp, line 240 > > > > > > Use QTRY_COMPARE(configSpy.count(), 1). Hardcoding random timeouts > > tends to randomly fail on ou

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Sebastian Kügler
> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote: > > autotests/testkwaylandbackend.cpp, line 154 > > > > > > nothing is done with ids It's used to verify that the id of the output is unique. > On Dec. 16,

plasmoid visions

2015-12-16 Thread kainz.a
Hi all, I'd like to review the plasmoids and want to know where we can discuss it, if you want. plasma mailing list, irc, telegram, ...? 1. Sidebar - Functionality is in plasma so we should use it, isn't it. 2. Plasmoid size if you click in the system tray at an

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2015-12-16 Thread René Fürst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/ --- (Updated Dez. 16, 2015, 10:21 nachm.) Review request for Network Manageme

Re: notification plasmoid for desktop

2015-12-16 Thread kainz.a
> > > > what's the reason that it will be removed after 10 minutes? wouldn't it > be nice to have also an history? grouped by date and filters for type. > > After 10 minutes a notification is most likely outdated. Otherwise a > status notifier (system tray icon) should be provided instead. Also, t

Re: notification plasmoid for desktop

2015-12-16 Thread Kai Uwe Broulik
Hi,> what's the reason that it will be removed after 10 minutes? wouldn't it be nice to have also an history? grouped by date and filters for type.After 10 minutes a notification is most likely outdated. Otherwise

Re: notification plasmoid for desktop

2015-12-16 Thread kainz.a
2015-12-16 17:21 GMT+01:00 Martin Klapetek : > On Wed, Dec 16, 2015 at 4:43 AM, Marco Martin wrote: > >> >> to have a quick glance at them when the windows don't cover everything, >> just >> the same use case of any other desktop plasmoid. >> in general, all plasmoid should disaplay correctly on

Updated 5.5 packages and ISO

2015-12-16 Thread Jonathan Riddell
I've produced an updated ISO with Plasma 5.5 in it http://files.kde.org/snapshots/unstable-amd64-latest.iso Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89621 --- I just want to say thanks for keeping at this - I feel kinda b

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89616 --- Great job! I can't really comment on the actual Wayland func

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-16 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126373/ --- (Updated Dec. 16, 2015, 7:23 p.m.) Review request for Plasma, Marco Marti

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-16 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126373/ --- (Updated Dec. 16, 2015, 7:19 p.m.) Review request for Plasma, Marco Marti

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-16 Thread Alex Merry
On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote: > > You might want to generate the documentation and look at it (you need the > > Sphinx documentation tool installed, then you just build > > extra-cmake-modules, and look in docs/html in the build directory). In particular, you'll need to add

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89619 --- tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/content

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89618 --- kde-modules/KDEPackageAppTemplates.cmake (line 10)

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-16 Thread Alex Merry
> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-16 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #81 from Martin Klapetek --- > Also I notice that after do `sudo gdb --pid` cpu usage slightly decrease and > after quit this back to 25%. Yes, attaching gdb to it makes the process actually stop, quitting gdb makes the process continue.

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Daniel Vrátil
> On Dec. 16, 2015, 10:08 a.m., Martin Gräßlin wrote: > > backends/kwayland/waylandbackend.cpp, line 46 > > > > > > where does it get deleted? > > Sebastian Kügler wrote: > Nowhere. :/ > > This is in

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-16 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #80 from mif...@gmail.com --- (In reply to Martin Klapetek from comment #79) > Can you check if you have 2 kded5 processes running? Not sure, this issue is very random, but i'll try. Also I notice that after do `sudo gdb --pid` cpu usage slig

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Daniel Vrátil
> On Dec. 16, 2015, 10:08 a.m., Martin Gräßlin wrote: > > backends/kwayland/waylandbackend.cpp, line 46 > > > > > > where does it get deleted? > > Sebastian Kügler wrote: > Nowhere. :/ > > This is in

Re: Evolving Appdash

2015-12-16 Thread Martin Klapetek
On Wed, Dec 16, 2015 at 11:30 AM, Aleix Pol wrote: > > Well you'd still need to blur the windows under it, no? > No, it wouldn't be a live blur, it would simply be a background image for performance reasons. Possibly the live blur could stay too as an option for those with powerful machines. Ch

Re: Evolving Appdash

2015-12-16 Thread Eike Hein
Some relevant IRC log: [15:37] mgraesslin: i wonder if we can get a kwin effect that only blurs in the desktop layer and cuts out the windows, as a fallback or even default for dashboard [15:37] mgraesslin: or we can resurrect the kde3 approach to translucency and have plasma export the wallpap

Re: Evolving Appdash

2015-12-16 Thread Aleix Pol
On Wed, Dec 16, 2015 at 5:00 PM, Martin Klapetek wrote: > On Wed, Dec 16, 2015 at 3:12 AM, Martin Graesslin > wrote: >> >> On Tuesday, December 15, 2015 6:48:32 PM CET Eike Hein wrote: >> > The VDG has offered to join in with some cool mockups to maxi- >> > mize potential. >> >> it would be cool

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-16 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #79 from Martin Klapetek --- Can you check if you have 2 kded5 processes running? Your backtrace again shows no activity at all. -- You are receiving this mail because: You are the assignee for the bug.

Re: notification plasmoid for desktop

2015-12-16 Thread Martin Klapetek
On Wed, Dec 16, 2015 at 4:43 AM, Marco Martin wrote: > > to have a quick glance at them when the windows don't cover everything, > just > the same use case of any other desktop plasmoid. > in general, all plasmoid should disaplay correctly on the desktop and when > they don't it tends to be a bug

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126373/#review89605 --- I really think the motivation behind this change is ill-formed

Re: Evolving Appdash

2015-12-16 Thread Martin Klapetek
On Wed, Dec 16, 2015 at 3:12 AM, Martin Graesslin wrote: > On Tuesday, December 15, 2015 6:48:32 PM CET Eike Hein wrote: > > The VDG has offered to join in with some cool mockups to maxi- > > mize potential. > > it would be cool if the VDG could also look into a non-blur variant for the > appdash

Draft split for qpt plugin from frameworkintegration

2015-12-16 Thread Martin Graesslin
Hi all, following up on [1] I have prepared a split of frameworkintegration to move the QPT plugin into a dedicated repository. You can find it in [2]. Please have a look at the split repo to verify that it looks fine. If everything is OK, I'll request a new repo from sysadmins. Some general n

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Sebastian Kügler
> On Dec. 16, 2015, 9:08 a.m., Martin Gräßlin wrote: > > good work! I omitted the tests/kwayland from review as I need a break after > > reading through all the unknown code. Hi Martin, No problem, that's not the critical part, anyway. I've gone over the list of issues and dropped a few (comm

Re: Review Request 126380: Fix OutputDevice::edid()

2015-12-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126380/ --- (Updated Dec. 16, 2015, 12:54 p.m.) Status -- This change has been m

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 16, 2015, 12:25 p.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-16 Thread Marco Martin
> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2015-12-16 Thread Lamarque Souza
> On Dec. 13, 2015, 10:45 p.m., René Fürst wrote: > > vpn/l2tp/l2tpwidget.cpp, line 183 > > > > > > That's actually not my code. I just indented it because it went into an > > if. Fixed it anyway. > > Lamarque

Re: Plasma 5.5.1

2015-12-16 Thread Jonathan Riddell
Well spotted, the plasma-workspace tar was updated shortly before release but for some reason that didn't make it through to the server although it did for the tar. I've now put the correct tar up as 5.5.1.1 and linked to it from 5.5.1. sha256 is 7e91dac2301975ae8ee788deddc9e4ac8c5f699865e85d09c

Re: Review Request 126301: Add protocol for server side decoration

2015-12-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/ --- (Updated Dec. 16, 2015, 12:07 p.m.) Review request for Plasma and Sebasti

Re: Review Request 126301: Add protocol for server side decoration

2015-12-16 Thread Martin Gräßlin
> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote: > > src/client/server_decoration.h, line 179 > > > > > > apidocs missing > > > > It would be useful to explain the modes here, and possibly mention

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126373/#review89590 --- i think it makes it look too much disabled/minimized, it would

Re: notification plasmoid for desktop

2015-12-16 Thread Marco Martin
On Wednesday 16 December 2015, Martin Klapetek wrote: > Hey, > > On Tue, Dec 15, 2015 at 7:26 PM, kainz.a wrote: > > Hi Martin, > > > > would it be possible or a good idea to have the notifications in the > > panel and in addition on the desktop. for the desktop the notifications > > from the po

Re: Review Request 126276: Disable ptrace on kdesu

2015-12-16 Thread Martin Gräßlin
> On Dec. 16, 2015, 10:15 a.m., Harald Sitter wrote: > > CMakeLists.txt, line 93 > > > > > > description needs update for kdesu good spot! - Martin ---

Re: activity manager plasmoid for desktop

2015-12-16 Thread Marco Martin
On Wednesday 16 December 2015, kainz.a wrote: > Hi Ivan, > > you make a great sidebar for the activities. you can come to this "sidebar" > via the activity manger or an shortcut. the activity manager is only > available for the panel would it be possible to use it for the desktop too. > so if you

Re: Review Request 126374: [Activity Pager] Implement drag and drop for Task Manager entries

2015-12-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126374/#review89586 --- Ship it! Ship It! - Marco Martin On Dec. 15, 2015, 11:45 p

Re: Review Request 126276: Disable ptrace on kdesu

2015-12-16 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126276/#review89585 --- CMakeLists.txt (line 93)

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89584 --- good work! I omitted the tests/kwayland from review as I need

Re: color picker plasmoid for the desktop

2015-12-16 Thread kainz.a
when you place the color picker to the desktop it look the same than in the panel (two buttons) as you have more space on the desktop I would like to see the color grid on the desktop and in addition the two buttons to select a new color. 2015-12-16 9:04 GMT+01:00 Kai Uwe Broulik : > Hi, > > I do

Re: notification plasmoid for desktop

2015-12-16 Thread kainz.a
the user case would be to add the plasmoid on the desktop to have something like an dash for the desktop or and that is what I was thinking an sidebar panel (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/Sidebar.png) cheers 2015-12-16 1:46 GMT+01:00 Martin Klapetek : > Hey, > > On Tue, Dec

Re: Evolving Appdash

2015-12-16 Thread Martin Graesslin
On Tuesday, December 15, 2015 8:27:28 PM CET Marco Martin wrote: > > Appdash from edge swipe sounds really cool. Sounds like this would > > be combined with the hot corner KCM? > > it should probably be something kwin-driven, as an invisible window to take > the input is probably too invasive (sho

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-16 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126373/ --- (Updated Dec. 16, 2015, 8:16 a.m.) Review request for Plasma, Marco Marti

Re: Evolving Appdash

2015-12-16 Thread Martin Graesslin
On Tuesday, December 15, 2015 6:48:32 PM CET Eike Hein wrote: > The VDG has offered to join in with some cool mockups to maxi- > mize potential. it would be cool if the VDG could also look into a non-blur variant for the appdash. I'm still very concerned about the full screen blur as the KWin ef

Re: color picker plasmoid for the desktop

2015-12-16 Thread Kai Uwe Broulik
Hi,I don't get your question. You can just place it on your desktop if you like.