Re: Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled

2015-12-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126296/#review89293 --- Ship it! How is it possible to have damage enabled, but compo

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread Martin Gräßlin
> On Dec. 10, 2015, 12:03 a.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-09 Thread Martin Graesslin
On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol wrote: > On Wed, Dec 9, 2015 at 3:56 PM, Mark Gaiser wrote: > > On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin wrote: > >> On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote: > >> > I thought the frameworkintegration plugin was

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread Rex Dieter
> On Dec. 9, 2015, 11:03 p.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (w

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread Martin Klapetek
> On Dec. 10, 2015, 12:03 a.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread Aleix Pol Gonzalez
> On Dec. 10, 2015, 12:03 a.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread Rex Dieter
> On Dec. 9, 2015, 11:03 p.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (w

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread David Edmundson
> On Dec. 9, 2015, 11:03 p.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. Though if you do SDDM will say: Plasma (wayland) (wayland) - David -

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-09 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126275/#review89286 --- I (still) think it should be renamed and Wayland mentioned *so

Re: Review Request 126292: [CompactApplet] Hack to force focus on expanded representation

2015-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126292/#review89285 --- Dialog has the focus correctly to its mainItem, right? so in h

Re: Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled

2015-12-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126296/#review89283 --- Ship it! Ship It! - David Edmundson On Dec. 9, 2015, 10:03

Re: Review Request 126294: [Clipboard Plasmoid] Fix import to use StandardKeys

2015-12-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126294/#review89284 --- Ship it! Ship It! - David Edmundson On Dec. 9, 2015, 9:21

Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled

2015-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126296/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-framewor

Review Request 126293: [System Tray] Forward key events to expanded task

2015-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126293/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 126292: [CompactApplet] Hack to force focus on expanded representation

2015-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126292/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 126294: [Clipboard Plasmoid] Fix import to use StandardKeys

2015-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126294/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspac

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Failing!

2015-12-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Dec 2015 19:08:26 + Build duration: 1 min 54 sec CHANGE SET Revision 5c5bbc3f8c4297cfd686

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Failing!

2015-12-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Dec 2015 18:32:01 + Build duration: 2 min 15 sec CHANGE SET Revision 2b59ccd531dcdb7d8657

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-09 Thread Aleix Pol
On Wed, Dec 9, 2015 at 3:56 PM, Mark Gaiser wrote: > On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin wrote: >> >> On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote: >> > I thought the frameworkintegration plugin was exactly that and usable >> > for >> > any platform if they wish to u

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-09 Thread Mark Gaiser
On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin wrote: > On Tuesday, December 8, 2015 6:03:47 PM CET Mark Gaiser wrote: > > I thought the frameworkintegration plugin was exactly that and usable for > > any platform if they wish to use it. > > Or is my assumption wrong and is it really only for P

Re: [plasma-devel] Re: 5.5 video

2015-12-09 Thread Mario Fux
Am Tuesday 08 December 2015, 09.21:05 schrieb Lucas S: > Hi, Morning Lucas > -Fixed a typo "managment" => "management". > > Thanks for spotting this > > Link > https://youtu.be/3wFTo34mCj0 So you're video is in the announcement and I wanted to tel you: thanks a lot for your work and construct

Re: Error compiling the framework

2015-12-09 Thread Sebastian Kügler
On Wednesday, December 09, 2015 07:23:39 Alfonso Hernandez wrote: > QT_PLUGIN_PATH=/root/qt5/qtbase/plugins > LD_LIBRARY_PATH=/root/qt5/qtbase/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} > QMAKE=/root/qt5/qtbase/bin/qmake /root/qt5/qtbase/bin/lrelease > qtxmlpatterns_uk.ts –qm /root/qt5/qtbase/transl

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Aleix Pol Gonzalez
> On Dec. 9, 2015, 1:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > > > > > Naming them .zip on windows, won't make it a zip file, if you use tar > > j. I suggest just

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Marco Martin
> On Dec. 9, 2015, 12:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > > > > > Naming them .zip on windows, won't make it a zip file, if you use tar > > j. I suggest just

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 9, 2015, 12:12 p.m.) Review request for Build System, KDE F

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89275 --- kde-modules/KDETemplateGenerator.cmake (line 59)

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Marco Martin
> On Dec. 8, 2015, 11:08 a.m., Alex Merry wrote: > > kde-modules/KDETemplateMacro.cmake, line 45 > > > > > > To make this slightly more general, consider passing in the install > > destination as an argument, or

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 9, 2015, 11:27 a.m.) Review request for Build System, KDE F

Re: Plasma 5.5.0

2015-12-09 Thread Jonathan Riddell
Sorry my fault I think, I had to reroll breeze-gtk and the script reset the permissions, open now New breeze-gtk 5.5.0.1 sha256 96d80eea894d95b7360f4ccf9385a7d5c65340b4aad50fbfeb670a01025a5212 Jonathan On Wed, Dec 09, 2015 at 08:49:12AM +0100, T.C.Berner wrote: > Hi > > The 5.5.0/ subdirect

Re: Review Request 126283: Use KDE_INSTALL_DATADIR to install update script

2015-12-09 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126283/ --- (Updated Dec. 9, 2015, 11:18 a.m.) Status -- This change has been ma