Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

> On Nov. 11, 2015, 8:14 a.m., Martin Gräßlin wrote: > > personal comment from X world: this is horrible, horrible ;-) What we > > should try is to make the desktop file available to the window. With KF > > 5.16 we will have all that's needed available. Let's try to improve this in > > Plasma

Re: Review Request 126234: Fix build with Qt 5.6

> On Dec. 3, 2015, 6:51 p.m., Hrvoje Senjan wrote: > > 2nd best solution after not using Qt5PlatformSupport at all :D well we have to :-( I wanted to not rely on it, but we need it to get working fonts. - Martin --- This is an automati

Re: Review Request 126234: Fix build with Qt 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126234/#review89103 --- Ship it! - Martin Gräßlin On Dec. 3, 2015, 6:37 p.m., Jan K

Re: Review Request 126237: make comment role searchable in timezone selection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126237/#review89098 --- applets/digital-clock/plugin/timezonemodel.cpp (line 41)

Review Request 126237: make comment role searchable in timezone selection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126237/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89097 --- kde-modules/KDETemplateMacro.cmake (line 1)

Re: Review Request 126210: [phonon] Do not set RPATH

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126210/#review89096 --- +1 I think RPATH stuff is already set up correctly by extra-c

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote: > > personal comment from X world: this is horrible, horrible ;-) What we > > should try is to make the desktop file available to the window. With KF > > 5.16 we will have all that's needed available. Let's try to improve this in > > Plasma

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126233/ --- (Updated Dec. 3, 2015, 6:12 p.m.) Status -- This change has been mar

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126233/ --- (Updated Dec. 3, 2015, 6:12 p.m.) Review request for Plasma and Elvis Ang

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

> On Dec. 3, 2015, 5:52 p.m., Elvis Angelaccio wrote: > > Thanks for working on this! > > This patch does fix bug 294904 [1], so you could even commit it to > > Applications/15.12 branch. > > > > [1]: https://bugs.kde.org/show_bug.cgi?id=294904 Will do~ - Eike -

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126233/#review89091 --- Ship it! Thanks for working on this! This patch does fix bug

Re: Review Request 126234: Fix build with Qt 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126234/#review89090 --- 2nd best solution after not using Qt5PlatformSupport at all :D

Review Request 126234: Fix build with Qt 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126234/ --- Review request for Plasma, Martin Gräßlin and Hrvoje Senjan. Repository:

Re: Review Request 126166: use stylesheets in breeze icons

> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Pr

Re: How to handle drag-and-drop to the desktop in Plasma 5?

This fixes the Ark side, please review: https://git.reviewboard.kde.org/r/126233/ Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126233/ --- (Updated Dec. 3, 2015, 5:29 p.m.) Review request for Plasma and Elvis Ang

Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126233/ --- Review request for Plasma and Elvis Angelaccio. Repository: ark Descrip

Re: 5.5 video

On Thu, Dec 3, 2015 at 6:02 AM, Jonathan Riddell wrote: > > Updated video > > https://youtu.be/AAPE_G-FVBc The window that opens at 00:20 still doesn't make any sense. As a viewer I have no idea what is that window showing me and it quickly clicks through and stays overall 2 seconds only on the

Re: Review Request 126166: use stylesheets in breeze icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/ --- (Updated Dec. 3, 2015, 5:20 p.m.) Status -- This change has been mar

Re: How to handle drag-and-drop to the desktop in Plasma 5?

4018e27a in plasma-desktop fixes the FV side. It's still not really working for the Desktop folder though. Ark claims to be extracting to desktop:/, but just dumps the file into $HOME. It's the same with desktop:/ in Dolphin though. Cheers, Eike ___ P

Re: Plasma 5.5 tars

On 04/12/15 01:30, Jonathan Riddell wrote: > 5.5.0 tars are up now on depot available to packagers, will be made > public along with the release scheduled for Tuesday > > Jonathan > ___ > release-team mailing list > release-t...@kde.org > https://mail.kd

Plasma 5.5 tars

5.5.0 tars are up now on depot available to packagers, will be made public along with the release scheduled for Tuesday Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.5 video

Am Thursday 03 December 2015, 11.02:45 schrieb Jonathan Riddell: > Updated video > > https://youtu.be/AAPE_G-FVBc Looks nice. Some remarks: - Overlay text at 0:09 has a typo: "Enahanced" => "Enhanced" - Filtering of activities doesn't really make sense with 3 of them... - Overlay text at 0:58. Ba

Re: How to handle drag-and-drop to the desktop in Plasma 5?

On 12/03/2015 12:04 PM, Weng Xuetian wrote: > Just tried to debug it a little bit, looks like FolderModel::drop is > not called at all. > > From the observed visual behavior, plasmashell seems to takes the drop > as a new plasmoid request so FolderModel doesn't get the drop event. > > Probably

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Dec 2015 12:28:05 + Build duration: 1 min 30 sec CHANGE SET Revision 4b597be8216d985798f3

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Dec 2015 11:31:30 + Build duration: 3 min 56 sec CHANGE SET Revision 8aa71030c2ac2f607b0e

Jenkins-kde-ci: kinfocenter Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Dec 2015 11:14:15 + Build duration: 4 min 9 sec CHANGE SET Revision 8ac14b77bb706c8bdf16b16b36

Jenkins-kde-ci: kinfocenter Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Dec 2015 11:14:15 + Build duration: 4 min 9 sec CHANGE SET Revision 8ac14b77bb706c8bdf16b16b36

Re: How to handle drag-and-drop to the desktop in Plasma 5?

Just tried to debug it a little bit, looks like FolderModel::drop is not called at all. From the observed visual behavior, plasmashell seems to takes the drop as a new plasmoid request so FolderModel doesn't get the drop event. Probably it is blocked by following code in desktop containment. if (

Re: 5.5 video

Updated video https://youtu.be/AAPE_G-FVBc Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Dec 2015 10:38:35 + Build duration: 1 min 47 sec CHANGE SET Revision 0ef5a3c367194d8df220

Re: Review Request 126221: Rework the notifications positioning a bit

> On dec 2, 2015, 11:36 p.m., Mark Gaiser wrote: > > I had this issue for quite a while! > > It's in bug #349669, i have high hopes that this change fixes my case as > > well :) > > > > Will try this out somewhere this weekend. > > Martin Klapetek wrote: > No, unfortunately this will not f

Re: Review Request 126221: Rework the notifications positioning a bit

> On Dez. 2, 2015, 11:36 nachm., Mark Gaiser wrote: > > I had this issue for quite a while! > > It's in bug #349669, i have high hopes that this change fixes my case as > > well :) > > > > Will try this out somewhere this weekend. > > Martin Klapetek wrote: > No, unfortunately this will no