Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-11-20 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/#review88661 --- with current master of both p-f and p-d it's pretty difficult

Re: Review Request 126101: allow loading backends in-process

2015-11-20 Thread Àlex Fiestas
> On nov. 20, 2015, 7:03 p.m., Àlex Fiestas wrote: > > src/backendmanager.cpp, lines 114-120 > > > > > > Is this code duplicated? It seems like the code I wrote years ago and I > > guess now we need it in two pl

Re: Review Request 126101: allow loading backends in-process

2015-11-20 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88659 --- Ship it! Ship It! - Àlex Fiestas On nov. 20, 2015, 12:16 a

Re: Review Request 126101: allow loading backends in-process

2015-11-20 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88657 --- src/backendmanager.cpp (lines 114 - 120)

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88649 --- src/plasma/svg.cpp (line 581)

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 1:27 p.m.) Status -- This change has been ma

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread David Edmundson
> On Nov. 20, 2015, 12:35 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 590 > > > > > > we may as well remove this method then? Edit. obviously we can't. Ignore me. - David --

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88643 --- Ship it! src/plasma/svg.cpp (line 590)

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 12:19 p.m.) Review request for KDE Frameworks and

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
> On Nov. 19, 2015, 5:38 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 47 > > > > > > An SVG with colours will have a Theme object (via > > SvgPrivate::cacheAndColorsTheme()) > > > > ThemePri

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 11:18 a.m.) Review request for KDE Frameworks and

Re: Review Request 126119: remove unused platformstatus kded

2015-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126119/ --- (Updated Nov. 20, 2015, 10:19 a.m.) Status -- This change has been m

Re: Review Request 126101: allow loading backends in-process

2015-11-20 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88635 --- Ship it! Looks good! Some minor comments left, but no need to

[Differential] [Changed Subscribers] D409: new mobile components

2015-11-20 Thread andric (Simon Andric)
andric added a subscriber: andric. REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: andric, davidedmundson, plasma-devel _

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-11-20 Thread Andrea Del Sarto
> On Nov. 17, 2015, 9:42 a.m., Kai Uwe Broulik wrote: > > Heh, I got quoted by various magazines saying we've matured and are no > > longer obsessed with the K in everything :D > > > > Overall I like it. > > - shine-heart: kinda looks like it has a disease rather than shining > > - face-smile:

Re: Review Request 126121: [greeter] Use PlasmaShellSurface to position the views

2015-11-20 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126121/#review88633 --- Ship it! Ship It! - Bhushan Shah On Nov. 20, 2015, 2:02 p.

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-11-20 Thread andreas kainz
> On Nov. 17, 2015, 9:42 vorm., Kai Uwe Broulik wrote: > > Heh, I got quoted by various magazines saying we've matured and are no > > longer obsessed with the K in everything :D > > > > Overall I like it. > > - shine-heart: kinda looks like it has a disease rather than shining > > - face-smile:

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-11-20 Thread Andrea Del Sarto
> On Nov. 17, 2015, 9:42 a.m., Kai Uwe Broulik wrote: > > Heh, I got quoted by various magazines saying we've matured and are no > > longer obsessed with the K in everything :D > > > > Overall I like it. > > - shine-heart: kinda looks like it has a disease rather than shining > > - face-smile:

Review Request 126121: [greeter] Use PlasmaShellSurface to position the views

2015-11-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126121/ --- Review request for Plasma and Bhushan Shah. Repository: kscreenlocker D