Re: Review Request 126060: Fix krunner crash when open "/"

2015-11-13 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126060/ --- (Updated Nov. 14, 2015, 12:40 a.m.) Status -- This change has been m

Re: Review Request 126060: Fix krunner crash when open "/"

2015-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126060/#review88341 --- Ship it! Ship It! - David Edmundson On Nov. 13, 2015, 10:1

Review Request 126060: Fix krunner crash when open "/"

2015-11-13 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126060/ --- Review request for Plasma and Sebastian Kügler. Bugs: 355290 https://

Re: Plasma 5.5 alpha

2015-11-13 Thread Nicolas Lécureuil
Le 2015-11-06 13:28, Jonathan Riddell a écrit : It was suggested to celebrate repo freeze I make alpha tars of Plasma 5.5 just to check we know what's being released so here's some tars, please check it includes all the tars you expect and if you're incharge of a new tar then check it contains th

Re: RFC: plasmoid templates in plasma-sdk

2015-11-13 Thread Marco Martin
On Friday 13 November 2015 14:05:50 Aleix Pol wrote: > > I'm planning to move it to plasma-sdk (together with a new one for an > > hybrid QML/C++) that it gets a bit less forgotten than the > > long-forgotten kapptemplate > > > > thoughts? > > Maybe it should be installed by plasma-framework? I

Re: RFC: plasmoid templates in plasma-sdk

2015-11-13 Thread Luca Beltrame
In data venerdì 13 novembre 2015 14:05:50 CET, Aleix Pol ha scritto: > This way the template would be installed together with the -dev distro > packages. +1 to that. As a packager, that would probably make things easier. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: A29D2

Re: RFC: plasmoid templates in plasma-sdk

2015-11-13 Thread Aleix Pol
On Fri, Nov 13, 2015 at 1:24 PM, Marco Martin wrote: > Hi, > After someone again asked how to make a new plasmoid, i rememebered > there used to be a plasmoid template for kapptemplate/kdevelop, but > while it's ported to kf5, it's a bit abandoned. > I'm planning to move it to plasma-sdk (together

RFC: plasmoid templates in plasma-sdk

2015-11-13 Thread Marco Martin
Hi, After someone again asked how to make a new plasmoid, i rememebered there used to be a plasmoid template for kapptemplate/kdevelop, but while it's ported to kf5, it's a bit abandoned. I'm planning to move it to plasma-sdk (together with a new one for an hybrid QML/C++) that it gets a bit less

Re: Review Request 125973: Remove completely duplicated function

2015-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125973/ --- (Updated Nov. 13, 2015, 12:19 p.m.) Review request for Plasma. Reposito

Review Request 126052: Quicklaunch: Switch to vertical mode when height > width

2015-11-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126052/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-13 Thread Eike Hein
> On Nov. 12, 2015, 11:27 a.m., David Edmundson wrote: > > applets/kicker/plugin/computermodel.cpp, line 81 > > > > > > you don't want the mapToSource > > > > indexes here are already source indexes. Ah

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-13 Thread Eike Hein
> On Nov. 12, 2015, 5:19 p.m., Ivan Čukić wrote: > > applets/kicker/plugin/recentusagemodel.h, line 42 > > > > > > - What about contacts? > > - Why not Apps, Docs flags, they could be used below for appData,

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-13 Thread Eike Hein
> On Nov. 12, 2015, 10:29 p.m., Kai Uwe Broulik wrote: > > Nice! > > > > It doesn't seem to show recently launched apps, though, and the number of > > recent documents is too large imo. It shows recently launched apps just fine for me FWIW. - Eike --

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 13, 2015, 9:27 a.m.) Review request for Plasma, Ashish Bans

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Ashish Bansal
> On Nov. 13, 2015, 9:23 a.m., Ashish Bansal wrote: > > libs/mediacenter/lastfmimagefetcher.cpp, line 158 > > > > > > As imageFetcher is a signal, append "emit" word in the beginning. > > Although it is an emp

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88315 --- libs/mediacenter/lastfmimagefetcher.cpp (line 156)